Skip to content

[loader] Fix zombie creation#3683

Merged
bwoebi merged 3 commits intomasterfrom
luc/loader-fix-zombies
Mar 21, 2026
Merged

[loader] Fix zombie creation#3683
bwoebi merged 3 commits intomasterfrom
luc/loader-fix-zombies

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Mar 3, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 3, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 13 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bdd82b000000001d01316c0bf71918
tid: 69bdd82b00000000
hexProcessTraceId: 1d01316c0bf71918
hexProcessSpanId: 96c1533363ae654c
processTraceId: 2090006042203592984
processSpanId: 10863055256375158092

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bdd860000000006d163e5b3a0f1e11
tid: 69bdd86000000000
hexProcessTraceId: 6d163e5b3a0f1e11
hexProcessSpanId: 21347434734cf4f9
processTraceId: 7860538761158794769
processSpanId: 2392665070662120697

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8f69fee | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.73%. Comparing base (ec92fdf) to head (8f69fee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
- Coverage   68.76%   68.73%   -0.04%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
- Hits        13086    13080       -6     
- Misses       5128     5135       +7     
+ Partials      816      815       -1     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (ø)
helper-rust-unit 49.36% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec92fdf...8f69fee. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 4, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-17 17:06:52

Comparing candidate commit b88cc42 in PR branch luc/loader-fix-zombies with baseline commit 8cd0131 in branch master.

Found 3 performance improvements and 2 performance regressions! Performance is the same for 187 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-8.884µs; -7.516µs] or [-7.985%; -6.756%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.064µs; -3.476µs] or [-4.632%; -3.179%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+7.708µs; +11.562µs] or [+3.530%; +5.295%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+5.630µs; +8.923µs] or [+2.576%; +4.083%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-20.632µs; -9.368µs] or [-4.688%; -2.129%]

@bwoebi bwoebi marked this pull request as ready for review March 17, 2026 15:56
@bwoebi bwoebi requested a review from a team as a code owner March 17, 2026 15:56
iamluc and others added 3 commits March 21, 2026 00:18
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the luc/loader-fix-zombies branch from b88cc42 to 8f69fee Compare March 20, 2026 23:18
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are successful, so merging.

@bwoebi bwoebi merged commit b9a49fa into master Mar 21, 2026
2079 of 2082 checks passed
@bwoebi bwoebi deleted the luc/loader-fix-zombies branch March 21, 2026 01:11
@github-actions github-actions Bot added this to the 1.17.0 milestone Mar 21, 2026
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants