Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3708 +/- ##
==========================================
- Coverage 68.74% 68.73% -0.02%
==========================================
Files 166 166
Lines 19030 19030
Branches 1797 1797
==========================================
- Hits 13082 13080 -2
- Misses 5132 5135 +3
+ Partials 816 815 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
99f54be to
5f12f9e
Compare
|
✨ Fix all issues with BitsAI or with Cursor
|
Benchmarks [ tracer ]Benchmark execution time: 2026-03-20 18:08:49 Comparing candidate commit 2dda062 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 192 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
|
ee4cded to
a3550c4
Compare
1317582 to
0534aa3
Compare
4a1ab2c to
d655269
Compare
bwoebi
left a comment
There was a problem hiding this comment.
Thanks, looks correct to me, ship it!
…dd-update * 'master' of github.com:DataDog/dd-trace-php: [loader] Fix zombie creation (#3683) Adds container tags support for DBM (#3708) Enables process tags propagation by default (#3706) Fix windows panic at startup time Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> clippy Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…dd-update * 'master' of github.com:DataDog/dd-trace-php: [loader] Fix zombie creation (#3683) Adds container tags support for DBM (#3708) Enables process tags propagation by default (#3706) Fix windows panic at startup time Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> clippy Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This PR implements the container tags support for DBM as described in this RFC.
Tracers communicate their containerID through a request http header that can be back propagate by the agent. This feature is implemented in the agent in this libdatadog PR: DataDog/libdatadog#1700.
We use this container tags hash alongside process tags to compute a hash called
base_hash. This base_hash is injected in DBM comments and DBM spans.Note that the base_hash should be computed as soon as process tags are available because if the tracer is not run within a container, it will never receive a container_tags_hash.