Skip to content

Enables process tags propagation by default#3706

Merged
dubloom merged 5 commits intomasterfrom
dubloom/enable-process-tags-by-default
Mar 20, 2026
Merged

Enables process tags propagation by default#3706
dubloom merged 5 commits intomasterfrom
dubloom/enable-process-tags-by-default

Conversation

@dubloom
Copy link
Copy Markdown
Contributor

@dubloom dubloom commented Mar 17, 2026

Description

Sets process tags config to true by default.

We set it to false by default in test, otherwise we would have to modify almost all the tests to add process_tags in them.

Tests that want to test the feature must activate it manually. For each product there is at least one test testing process tags (i.e activating the flag).

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.68%. Comparing base (5404b05) to head (a5b9a97).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
- Coverage   68.79%   68.68%   -0.12%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
- Hits        13092    13070      -22     
- Misses       5125     5145      +20     
- Partials      813      815       +2     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (ø)
helper-rust-unit 49.17% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5404b05...a5b9a97. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-4
Copy link
Copy Markdown

datadog-prod-us1-4 Bot commented Mar 17, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 13 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bd2abe0000000089b51c3b783f63c2
tid: 69bd2abe00000000
hexProcessTraceId: 89b51c3b783f63c2
hexProcessSpanId: d66524d3bf4b279e
processTraceId: 9922868395726824386
processSpanId: 15448794588630427550

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69bd2ba2000000009d56c22785a85b4b
tid: 69bd2ba200000000
hexProcessTraceId: 9d56c22785a85b4b
hexProcessSpanId: b04de3b535958238
processTraceId: 11337462586953718603
processSpanId: 12704060491309613624
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a5b9a97 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-20 12:14:26

Comparing candidate commit a5b9a97 in PR branch dubloom/enable-process-tags-by-default with baseline commit 5404b05 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 191 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+4.209µs; +5.271µs] or [+4.057%; +5.080%]

@dubloom dubloom force-pushed the dubloom/enable-process-tags-by-default branch 2 times, most recently from 6c6012e to f1de79b Compare March 18, 2026 16:22
@dubloom dubloom marked this pull request as ready for review March 18, 2026 18:26
@dubloom dubloom requested review from a team as code owners March 18, 2026 18:26
@bwoebi bwoebi force-pushed the dubloom/process-tags-rc branch 4 times, most recently from ee4cded to a3550c4 Compare March 19, 2026 15:20
Base automatically changed from dubloom/process-tags-rc to master March 19, 2026 21:52
@bwoebi bwoebi requested review from a team as code owners March 19, 2026 21:52
@dubloom dubloom force-pushed the dubloom/enable-process-tags-by-default branch from 4386ee1 to 32f108c Compare March 20, 2026 09:28
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dubloom dubloom merged commit a8ee11d into master Mar 20, 2026
2085 of 2086 checks passed
@dubloom dubloom deleted the dubloom/enable-process-tags-by-default branch March 20, 2026 15:57
@github-actions github-actions Bot added this to the 1.17.0 milestone Mar 20, 2026
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this pull request Mar 21, 2026
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants