-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
umbrellaAn umbrella issueAn umbrella issue
Description
Here is an initial list of input data validation checks for process-related input files, organised by input data CSV file.
PROCESSES
No duplicate ID(already implemented)
PROCESS_PARAMETERS
no duplicate process_id - only one set of parameters for each agent (BUG:Processerroneously allows for multipleProcessParameters#137)process_id must exist in processes.csv file(already implemented)lifetime must be positive (Add more validation for process parameters #163)discount_rate must be positive. Warning if it is >1 to say discount rate for the process is more than 100%. (Add more validation for process parameters #163)cap2act must be positive (Add more validation for process parameters #163)
PROCESS_FLOWS
process_id must exist in processes.csv file (duplicates are allowed)(already implemented)commodity_id must exist in commodities.csv (MakeProcessFlow::commodity_idintoRc<Commodity>#166)flow_type can be "fixed" or "flexible" (defaults to "fixed" if not supplied) only(already implemented)
PROCESS_PACS
process_id must exist in processes.csv file (duplicates are allowed)(already implemented)Any identified PAC must exist in commodities.csv (i.e. PAC is the commodity_id) (process.rs: Check all PACs are valid commodity IDs #164)every process must have at least one PAC(already implemented - empty CSV files are not allowed)if more than one PAC is identified for one process, all PACs must be either all output flows or all input flows (i.e. can't be a combination of inputs and outputs). Important not to skip this check! (Check that all PACs for a process are inputs or outputs #165)
PROCESS_AVAILABILITIES
process_id must exist in processes.csv file (duplicates are allowed)(already implemented)limit_type must be "fx", "lo" or "up"(already implemented)time_slice must be a time slice (a season.time_of_day, whole season, or annual level)value must be between 0 and 1(already implemented)
PROCESS_REGIONS
process_id must exist in processes.csv file (duplicates are allowed as process can be available in several regions)(already implemented)region_id must exist in regions.csv (Check process region IDs are valid #138)
ASSET (putting this here as it's mainly process-related) (all should be done with #63)
process_id must exist in processes.csv file (duplicates are allowed as assets of the same process type can be in different regions, or in the same region with different commission_year or different owner agents)region_id must exist in regions.csv file and process_regions.csv must have an entry with that process_id / region_idagent_id must exist in agents.csv filecommission_year must be on or before the 1st milestone year- decommission_year must be after the 1st milestone year
GENERAL PROCESS-RELATED CONSISTENCY CHECKS
- For every commodity of "SED" type, there must be at least one process that consumes the commodity and one process that produces the commodity. #167
- For every commodity of "SVD" type, there must be at least one process that can produce the commodity #168
- For every commodity of "SVD" type, there must be at least one asset in the base year that can produce the commodity for every region where the SVD>0 for the base year. #169
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
umbrellaAn umbrella issueAn umbrella issue
Type
Projects
Status
✅ Done