Deploy Checklist: New Expensify 2024-06-14

[github-actions]

Release Version: 1.4.84-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [Mentions v2] Support mentions in editing comments #40565
• Fix status bar of mWeb Safari doesn't match the splash screen background color #41830
• Removing compose.ts #42069
• feat: ordered mention suggestions #42553
• [TS Migration] Define a concise way to access or default to an inexistent record #42634
• Align inline icons with text in Android LHN #42801
• fix LHN - Thread chat with violation is not removed from LHN #42809
• Fix User is shown option to submit expense using group #42977
• feat: add loading state to the SettlementButton #42981
• Prevent removal of admin and default members from workspace chats #43065
• fix: empty category illustration is not center aligned #43161
• Update en.ts #43321
• Fix subscription size value not trim able to add spaces before the value #43328
• Make <Avatar> related code more consistent #43366
• Opening a transaction thread can be slow to load sometimes #43384
• Add user's accountID to the api/ping command #43385
• Show year as well in date column #43413
• Don't show leave button in report details page if it's a thread #43454
• fix: Abracadabra page briefly displayed when login via 'Sign in here' link #43457
• Fix chat with your setup specialist message not aligned and gets out of box #43479
• feat: Subscription size backend integration #43484
• feat: add universal build for desktop app #43505
• Update Spanish translation for "Journal Entry" to "Asiento Contable" #43506
• [Performance] Improve getOrderedReportIDs performance #43539
• fix New workspace button does not create new WS if previous WS is selected first #43545
• Fix integrations setup on Android #43547
• Fix label style for push rows that are empty #43595
• [NoQA] Shift around utils to deduplicate code without circular dependencies #43608
• fixes "Refreshing the page with the onboarding flow closes it and never shows it again" #43648
• Fix empty screen when transferring ownership of the workplace #43651
• [No QA] Sending -1 instead of 0 in case we don't have the localUpdateID #43654
• [HybridApp] Fix android back button behaviour - NewDot part #43658
• [NoQA] Typescript check fix #43714
• Remove Magic Code Animation #43732
• [No QA] Revert back to Device import #43745
• [NoQA] Fix the TS in suggestionMentions #43781
• [CP Staging] Check for -1 default value for delegateAccountID #43817
• [CP Staging] Remove withPolicyAndFullscreenLoading from WorkspacesListPage #43818
• Fix deploy blocker where people can leave their own workspace chats #43870

Deploy Blockers:

• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Mention - Report mention #admins is not styled when editing comment in room chat #42521
• [$250] [HOLD for payment 2024-06-20] Hold expense - Unable to hold expense with failed scanning when there is only one expense #43207
• Subscription size - Offline indicator show ups on RHP on web layout #43795
• [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Workspace - Workspace list reloads when returning online #43799
• [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - "as copilot for" is displayed in avatar tooltip #43800
• [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Workspace - Workspace chat reappears in LHN after leaving the chat and relogin #43828
• Task – Hidden appears as task assignee for user B when user A create a task without assignee #43833
• [$500] Track expense - Expense preview isn't displayed for request next to failed one #43836
• Track expense - "Only visible to you" whisper appears after scanning is complete #43839
• [HOLD for payment 2024-08-09] [$250] Mention List - Users are not alphabetically ordered #43845
• [$250] Don't allow the Approver on a policy to leave a workspace chat #43852

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.84-0 🚀

[kbecciv]

TR is 30% only!

#40565 is failing with #42521, repro in Prod - checking off
#42069 is pending verification on Desktop
#42553 is pending verification
#42977 is pending verification on IOS app
#42981 is pending verification on Android and IOS app
#43065 is pending verification
#43328 is blocked on Android and IOS app with #43555 (comment)
#43384 is pending verification on Desktop and IOS app
#43413 is pending verification on Android and IOS app
#43505 is pending verification
#43648 is pending verification on Desktop

Deploy Blockers:
#42521
#43795
#43799
#43800

[mountiny]

demoted #42521 and #43795

[kbecciv]

TR is 25% left!

#40565 is failing with #42521, repro in Prod - checking off
#42069 is failing with #43798 and #43799
#42553 is pending verification
#42977 is pending verification on IOS app
#42981 is pending verification on IOS app
#43065 is pending verification
#43328 is blocked on Android and IOS app with #43555 (comment)
#43384 is pending verification on IOS app
#43413 is pending verification on IOS app
#43648 is failing with #43803 on Android and IOS app, repro in Prod - checking off

[grgia]

Demoting #43833

[Julesssss]

Demoting #43836 as it's likely a side-effect of the pre-requisite bug

[kbecciv]

TR is 15% left!

#40565 is failing with #42521, repro in Prod - checking off
#42069 is failing with #43798 and #43799
#42553 is failing on mWeb and Desktop with #43845
#43065 is failing with #43845 on mWeb, Desktop and IOS app, and failing with #35391 on Web - left comment #43065 (comment)
#43328 is blocked on Android and IOS app with #43555 (comment)

[rlinoz]

Closed #43839 in favor of already ongoing issue #42169

[AndrewGable]

#42069 is failing with #43798 and #43799

Doesn't seem like we have any blockers on this one, OK to check off.

#42553 is failing on mWeb and Desktop with #43845

This blocker was demoted, so seems safe to check off.

#43065 is failing with #43845 on mWeb, Desktop and IOS app, and failing with #35391 on Web - left comment #43065 (comment)

Can you retest @kbecciv with new test steps?

#43328 is blocked on Android and IOS app with #43555 (comment)

This seems expected, can you check it off?

[jasperhuangg]

Checking off #43828, CP'd a fix!

[AndrewGable]