fix: 29056 Back from request money details page does not open request money page by tienifr · Pull Request #29268 · Expensify/App

tienifr · 2023-10-11T08:56:24Z

Details

Fixed Issues

$ #29056
PROPOSAL: #29056 (comment)

Tests

Open the app
Open any report with request money IOU message
Click on request money IOU message
Click in header, it will open details page
Copy the URL and logout
Paste URL and login
On details page, click back and observe that now app does not display report for which we had opened details page
Verify that app displays report for which details page is opened in background if we login with details page URL

Note: We don't need to test on native because after login successfully, we always return to LHN page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Open any report with request money IOU message
Click on request money IOU message
Click in header, it will open details page
Copy the URL and logout
Paste URL and login
On details page, click back and observe that now app does not display report for which we had opened details page
Verify that app displays report for which details page is opened in background if we login with details page URL

Note: We don't need to test on native because after login successfully, we always return to LHN page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screenrecorder-2023-10-11-15-35-31-206.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-11.at.15.32.01.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-10-11.at.15.26.08.mp4

MacOS: Desktop

Screen.Recording.2023-10-11.at.15.41.02.mov

… money page

melvin-bot · 2023-10-11T08:56:45Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-10-11T09:01:27Z

@burczu I want to change the original proposal a bit, we just should navigate to report for which details page is opened if we open detail page from deeplink. That why I have the condition to check if we have the topMostReportID. If we don't do that, when press back button, we'll navigate to duplicated report

burczu · 2023-10-12T08:27:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-12.at.11.04.16.mov

Mobile Web - Chrome

Screen.Recording.2023-10-12.at.13.24.45.mov

Mobile Web - Safari

Screen.Recording.2023-10-12.at.13.17.45.mov

Desktop

n/a

iOS

n/a

Android

n/a

burczu · 2023-10-12T10:58:27Z

@tienifr It looks like it does not work on iOS using uri-scheme - is that intended? Also for Android:native you've posted the same video as for iOS.

tienifr · 2023-10-12T11:00:13Z

@burczu I also try to use uri-scheme but it doesn't work even on main

burczu · 2023-10-12T11:09:38Z

@tienifr I think for this PR it would be enough to test on mobile and desktop web and leave other environments with the information why it was no tested.

burczu · 2023-10-12T11:33:11Z

src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.js

+    if (!state) {
+        return;
+    }
+    const topmostRightPane = lodashFindLast(state.routes, (route) => route.name === 'RightModalNavigator');


I would suggest using NAVIGATORS.RIGHT_MODAL_NAVIGATOR here

burczu · 2023-10-16T11:18:31Z

@tienifr The last thing: please update your PR's Author Checklist according to this comment.

tienifr · 2023-10-16T14:05:53Z

@burczu Just updated. Thanks

burczu

LGTM

OSBotify · 2023-10-18T02:08:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-19T00:33:49Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-19T00:59:30Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:08:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:41:09Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:53:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: 29056 Back from request money details page does not open request…

8463cb0

… money page

tienifr marked this pull request as ready for review October 11, 2023 08:56

tienifr requested a review from a team as a code owner October 11, 2023 08:56

melvin-bot bot requested review from burczu and removed request for a team October 11, 2023 08:56

burczu reviewed Oct 12, 2023

View reviewed changes

fix: change to use constant

c09537e

burczu approved these changes Oct 17, 2023

View reviewed changes

melvin-bot bot requested a review from francoisl October 17, 2023 08:04

francoisl approved these changes Oct 18, 2023

View reviewed changes

francoisl merged commit f0d2d08 into Expensify:main Oct 18, 2023

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

bernhardoj mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Concierge not highlights on login #30080

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 20, 2023

[PAID] [$500] Back from request money details page does not open request money page #29056

Closed

6 tasks

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

suneox mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-12-07] [$500] Go back from Flag as offensive doesn't display correct report page #30101

Closed

6 tasks

ntdiary mentioned this pull request Jan 19, 2024

[HOLD for payment 2024-02-26] [$500] Workspace name in Distance request flow is wrong color #33976

Closed

6 tasks

bernhardoj mentioned this pull request May 13, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - Unable to navigate to LHN, back button loops between WS details & main chat page #41514

Closed

6 tasks

Conversation

tienifr commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 11, 2023

Uh oh!

tienifr commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

burczu commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

burczu commented Oct 12, 2023

Uh oh!

tienifr commented Oct 12, 2023

Uh oh!

burczu commented Oct 12, 2023

Uh oh!

burczu Oct 12, 2023

Choose a reason for hiding this comment

Uh oh!

burczu commented Oct 16, 2023

Uh oh!

tienifr commented Oct 16, 2023

Uh oh!

burczu left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

OSBotify commented Oct 20, 2023

Uh oh!

OSBotify commented Oct 20, 2023

Uh oh!

OSBotify commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Oct 11, 2023 •

edited

Loading

tienifr commented Oct 11, 2023 •

edited

Loading

burczu commented Oct 12, 2023 •

edited

Loading