[Form Provider Refactor] RoomNameInput fixes by kowczarz · Pull Request #30996 · Expensify/App

kowczarz · 2023-11-07T14:36:48Z

Details

Followup to #29771

Fixed Issues

$ #28877
$ #31566

Tests

IMPORTANT: User needs to have the permission to use policy rooms enabled.

Workspace new room:

Log in
Press + button > Press Start chat > Switch to # Room
Check if errors appears when incorrect data is typed in
Check if when spaces are replaced with -
Type correct data and create a new room

Room name:

Log in
If there are no rooms, create a new one (steps above)
In the chat room press its name > Press Settings > Press Room name
Check if the room name is propagated
Check if errors appears when incorrect data is typed in
Check if when spaces are replaced with -
Type correct data and update the name of the room

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.create_H.265.mp4

android.native.edit_H.265.mp4

Android: mWeb Chrome

android.web.create_H.265.mp4

android.web.edit_H.265.mp4

iOS: Native

ios.native.create_H.265.mp4

ios.native.rename_H.265.mp4

iOS: mWeb Safari

ios.web.create_H.265.mp4

ios.web.edit_H.265.mp4

MacOS: Chrome / Safari

web.create_H.265.mp4

web.edit_H.265.mp4

MacOS: Desktop

desktop.create_H.265.mp4

desktop.edit_H.265.mp4

This reverts commit c01af10

melvin-bot · 2023-11-07T14:36:53Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js # src/pages/workspace/WorkspaceNewRoomPage.js

…-page-migration-fixes

melvin-bot · 2023-11-08T15:00:16Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-11-08T15:16:41Z

Hello @luacmartins! I reverted the revert of room name input and fixed issues caused by the changes:

[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] Room - When entering a "Space" while writing Room name "-" is not added #30500
[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] [$500] Room - Room name field is not populated with existing room name in room name editor #30504

But I couldn't reproduce #30507

luacmartins · 2023-11-08T17:08:56Z

Thanks for working on this! Let's retest the PR and make sure those cases are fixed!

allroundexperts · 2023-11-10T09:07:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-01.at.12.55.30.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-22.at.12.11.20.AM.mov

iOS: Native

Screen.Recording.2023-12-01.at.12.53.21.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-21.at.11.48.22.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-21.at.11.44.18.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-21.at.11.46.56.PM.mov

kowczarz · 2023-11-15T12:56:01Z

Hey @luacmartins I did some tests and @blazejkustra did a cross check, so now we are quite confident that there should be no more issues.

luacmartins · 2023-11-19T21:26:38Z

Thanks for checking. @allroundexperts do you think you'll be able to review this soon?

allroundexperts · 2023-11-19T21:27:50Z

Hi @luacmartins!
Waiting for the conflicts to get resolved.

luacmartins · 2023-11-19T21:39:57Z

@kowczarz could you please fix conflicts?

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js # src/pages/settings/Report/RoomNamePage.js

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js

kowczarz · 2023-11-20T16:26:55Z

@allroundexperts done. I see there are lot of changes in src/components/RoomNameInput/index.native.js - I had to resolve conflicts twice there, but it will be removed anyways, so if you will spot another conflict in that file, feel free to review the PR, it most likely won't affect the final version of the code.

luacmartins · 2023-11-20T16:27:12Z

Thanks for fixing the conflicts @kowczarz. @allroundexperts this should be ready for review

…-page-migration-fixes

allroundexperts · 2023-11-21T19:02:08Z

@kowczarz I'm getting the following crash on native devices when trying to open the new chat option.

Screen.Recording.2023-11-22.at.12.00.41.AM.mov

luacmartins · 2023-11-21T21:48:19Z

Maybe it came from this blocker? #31654

luacmartins · 2023-11-22T22:28:07Z

@kowczarz can you merge main to fix the issue above?

luacmartins · 2023-11-27T18:36:08Z

bump @kowczarz

…-page-migration-fixes # Conflicts: # src/components/Form/FormProvider.js # src/components/RoomNameInput/index.native.js

…ge-migration-fixes # Conflicts: # src/components/Form/InputWrapper.js

kowczarz · 2023-11-28T11:42:24Z

Now it's fine

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-28.at.11.51.06.mp4

luacmartins

LGTM!

luacmartins · 2023-11-28T20:03:06Z

All yours @allroundexperts

kowczarz · 2023-11-30T09:24:15Z

@allroundexperts bump

allroundexperts

Looks good!

OSBotify · 2023-11-30T20:52:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:56:28Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.7-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkuoch · 2023-12-04T11:46:10Z

This PR caused this regression.

luacmartins · 2023-12-04T19:43:24Z

@kowczarz we reverted this PR because it caused the following regressions:

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] [$500] BA - Last character of input fields is removed after coming back to BA form #32386
[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] [$500] Room - Error shows up when saving existing and valid room name with any changes #32398
[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] Room - Inconsistent error message when entering [[<<> in the room name field #32399
[HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears #32402 (comment)

OSBotify · 2023-12-05T02:26:51Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kowczarz added 2 commits November 6, 2023 17:15

Revert "Revert "[Form Provider Refactor] RoomNameInput""

f2302a6

This reverts commit c01af10

Fix room name parsing and not displaying room name in room name editor

1b637a6

kowczarz added 4 commits November 7, 2023 15:38

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

7146428

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js # src/pages/workspace/WorkspaceNewRoomPage.js

Lint fixes

f0a6fd1

Fix lint issues

690cd86

Fix lint

580c689

kowczarz force-pushed the kowczarz/room-name-page-migration-fixes branch from 1461e72 to 580c689 Compare November 8, 2023 10:20

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

0889a62

…-page-migration-fixes

kowczarz marked this pull request as ready for review November 8, 2023 15:00

kowczarz requested a review from a team as a code owner November 8, 2023 15:00

melvin-bot bot requested review from allroundexperts and removed request for a team November 8, 2023 15:00

luacmartins self-requested a review November 8, 2023 17:08

blazejkustra approved these changes Nov 10, 2023

View reviewed changes

kowczarz added 2 commits November 20, 2023 12:49

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

059e7e2

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js # src/pages/settings/Report/RoomNamePage.js

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

cc473e7

…-page-migration-fixes # Conflicts: # src/components/RoomNameInput/index.native.js

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

9d117d6

…-page-migration-fixes

kowczarz added 3 commits November 28, 2023 10:59

Merge remote-tracking branch 'expensify/main' into kowczarz/room-name…

03003b7

…-page-migration-fixes # Conflicts: # src/components/Form/FormProvider.js # src/components/RoomNameInput/index.native.js

Remove unused file after wrong conflicts resolve

dd94359

Merge remote-tracking branch 'origin/main' into kowczarz/room-name-pa…

c75f332

…ge-migration-fixes # Conflicts: # src/components/Form/InputWrapper.js

kowczarz mentioned this pull request Nov 28, 2023

[HOLD for payment 2023-12-12] [Form Provider Refactor] WorkspaceNewRoomPage #31566

Closed

luacmartins approved these changes Nov 28, 2023

View reviewed changes

allroundexperts approved these changes Nov 30, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins November 30, 2023 20:13

luacmartins approved these changes Nov 30, 2023

View reviewed changes

luacmartins merged commit 6a95f03 into Expensify:main Nov 30, 2023

github-actions bot mentioned this pull request Dec 1, 2023

Deploy Checklist: New Expensify 2023-12-01 #32342

Closed

53 tasks

lanitochka17 mentioned this pull request Dec 1, 2023

Android - Room creation - Workspace list in room creation page is misaligned #32377

Closed

6 tasks

bernhardoj mentioned this pull request Dec 2, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] [$500] BA - Last character of input fields is removed after coming back to BA form #32386

Closed

6 tasks

ishpaul777 mentioned this pull request Dec 2, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] [$500] Room - Error shows up when saving existing and valid room name with any changes #32398

Closed

6 tasks

shubham1206agra mentioned this pull request Dec 2, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-12] Room - Inconsistent error message when entering [[<<> in the room name field #32399

Closed

6 tasks

This was referenced Dec 4, 2023

Revert "[Form Provider Refactor] RoomNameInput fixes" #32440

Merged

[HOLD for payment 2023-12-12] Android - Room - Hard to focus the name input field after the error message appears #32402

Closed

melvin-bot bot mentioned this pull request Dec 5, 2023

[HOLD for payment 2023-12-12] [HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] RoomNamePage and WorkspaceNewRoomPage #28877

Closed

kowczarz mentioned this pull request Dec 5, 2023

[Form Provider Refactor] RoomNameInput fixes #32432

Merged

47 tasks

Conversation

kowczarz commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 7, 2023

Uh oh!

melvin-bot bot commented Nov 8, 2023

Uh oh!

kowczarz commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Nov 8, 2023

Uh oh!

allroundexperts commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

kowczarz commented Nov 15, 2023

Uh oh!

luacmartins commented Nov 19, 2023

Uh oh!

allroundexperts commented Nov 19, 2023

Uh oh!

luacmartins commented Nov 19, 2023

Uh oh!

kowczarz commented Nov 20, 2023

Uh oh!

luacmartins commented Nov 20, 2023

Uh oh!

allroundexperts commented Nov 21, 2023

Uh oh!

luacmartins commented Nov 21, 2023

Uh oh!

luacmartins commented Nov 22, 2023

Uh oh!

luacmartins commented Nov 27, 2023

Uh oh!

kowczarz commented Nov 28, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Nov 28, 2023

Uh oh!

kowczarz commented Nov 30, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 30, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

nkuoch commented Dec 4, 2023

Uh oh!

luacmartins commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Dec 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kowczarz commented Nov 7, 2023 •

edited

Loading

kowczarz commented Nov 8, 2023 •

edited

Loading

allroundexperts commented Nov 10, 2023 •

edited

Loading

luacmartins commented Dec 4, 2023 •

edited

Loading