Refactor/36648 wallet enablement flow connect steps

[koko57]

Details

Fixed Issues

$ #36648
PROPOSAL: -

Tests

1. Go to Settings/Wallet
2. Click on Enable Wallet button
3. Verify that you're redirected to /settings/wallet/enable-payments page.
4. Go through the flow, verify that you can pass the flow successfully and the fields are validated properly.

• Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

1. Go to Settings/Wallet
2. Click on Enable Wallet button
3. Verify that you're redirected to /settings/wallet/enable-payments page.
4. Go through the flow, verify that you can pass the flow successfully and the fields are validated properly.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[koko57]

@DylanDylann lint error fixed

[koko57]

@Pujan92 fixed

[mountiny]

@Pujan92 @DylanDylann are you happy with the changes?

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42589/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42589/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42589/NewExpensify.dmg	https://42589.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[DylanDylann]

Please give me an hour to review the change

[Pujan92]

@Pujan92 @DylanDylann are you happy with the changes?

Yes @mountiny, changes look good to me.

[jamesdeanexpensify]

Hi all - apologies for the late copy suggestions, but I have a few. Let me know if this isn't the right place or time:

• Under "What's your address?" could we do "No PO boxes or mail-drop addresses, please."
• The first "Fees and terms" screen, maybe the header could just be "Please review the fees below"
• The second "Fees and terms" screen, maybe the header could just be "Please check the boxes below"

[jamesdeanexpensify]

Getting Spanish translations for the suggestions above, hold tight!

[koko57]

@jamesdeanexpensify ping me when you will have the translations ready, I will add them to this PR, thanks!

[jamesdeanexpensify]

• No PO boxes or mail-drop addresses, please. > Nada de apartados de correos ni direcciones de envío, por favor.
• Please review the fees below > Por favor, revisa las siguientes tarifas
• Please check the boxes below > Por favor, marca las siguientes casillas

[jamesdeanexpensify]

ready for you @koko57 !

[koko57]

@jamesdeanexpensify thanks! applying them to this PR!

[koko57]

@jamesdeanexpensify changes applied - the first pair of translations (No PO boxes...) was already in the app, but I needed to swap the translation key. The other translations were added.

[jamesdeanexpensify]

Thank you!

[mountiny]

Thanks @koko57 @DylanDylann @Pujan92 for getting this across the finish line 🙇

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[hoangzinh]

We missed wrapping those into ScreenWrapper, therefore it caused a UI bug here #44805

[ahmedGaber93]

isEmptyObject(bankAccountList) ? CONST.WALLET.STEP.ADD_BANK_ACCOUNT

Coming from #71437, the add bank account step in enable wallet flow is mistakenly skipped because it incorrectly assumes that user already has a valid personal bank account even though he only has a business account.