fix: update volume to 0.25 if unmute but volume is 0 by dominictb · Pull Request #46795 · Expensify/App

dominictb · 2024-08-05T08:01:21Z

Details

Fixed Issues

$ #45277
PROPOSAL: #45277 (comment)

Tests

Go to NewDot in Android Chrome
Log in new account
Tap join
In Get started video, note video is muted
Enable video to full screen
Try to unmute in full screen

Verify that: the user can unmute video and video volume is 25%

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to NewDot in Android Chrome
Log in new account
Tap join
In Get started video, note video is muted
Enable video to full screen
Try to unmute in full screen

Verify that: the user can unmute video and video volume is 25%

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

compressed_android.webm.mp4

Android: mWeb Chrome

compressed_androidweb.webm.mp4

iOS: Native

compressed_ios.mp4.mp4

iOS: mWeb Safari

compressed_iosweb.mp4.mp4

MacOS: Chrome / Safari

compressed_web.mov.mp4

MacOS: Desktop

compressed_web.mov.mp4

melvin-bot · 2024-08-05T08:01:26Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2024-08-06T15:17:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

0-android.mp4

Android: mWeb Chrome

0-mobile-chrome.mp4

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

0-desktop.mp4

eh2077 · 2024-08-06T15:55:11Z

@dominictb Should we treat it as muted when volume is 0? I tested following steps

Turn on video with sound, like 50% volume
Drag volume bar to zero
Click the audio icon to enable sound
I found that I have to click the audio icon twice to turn on audio to 25% volume
- The first click makes unmuted icon changed to muted state
- The second click turn on audio with 25% volume (when meet condition volumne = 0 and icon is muted)

Screen.Recording.2024-08-06.at.11.41.36.PM.mov

I found that YouTube treats volume=0 as muted.

Screen.Recording.2024-08-06.at.11.42.52.PM.mov

dominictb · 2024-08-07T15:29:05Z

I found that I have to click the audio icon twice to turn on audio to 25% volume

It is because in full-screen mode when we set the volume to 0, the isMuted is not set to true as it is in normal mode.

I pushed commit to fix that issue.

eh2077 · 2024-08-08T16:56:06Z

The diffs looks good to me. I'm preparing recordings

eh2077

LGTM

OSBotify · 2024-08-09T09:26:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

IuliiaHerets · 2024-08-13T06:34:05Z

This PR is failing for Android app because of issue #47295

eh2077 · 2024-08-13T06:40:18Z

@dominictb Can you take a look at the linked issue?

dominictb · 2024-08-13T08:11:15Z

@eh2077 This PR was not deployed to the staging, right?

Beamanator · 2024-08-14T20:52:48Z

FYI I believe this was deployed to prod yesterday, from this checklist - #47219

hungvu193 · 2024-12-18T11:00:37Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+            if (prevIsMutedRef.current && prevVolumeRef.current === 0 && !status.isMuted) {
+                updateVolume(0.25);
+            }


This line caused this issue:
#52858

More details in: #52858 (comment)

eh2077 · 2025-04-22T15:01:25Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

                return;
            }
+
+            if (prevIsMutedRef.current && prevVolumeRef.current === 0 && !status.isMuted) {


This caused #60117, see #60117 (comment)

fix: update volume to 0.25 if unmute but volume is 0

9972b71

dominictb requested a review from a team as a code owner August 5, 2024 08:01

melvin-bot bot requested review from eh2077 and removed request for a team August 5, 2024 08:01

fix: manually set isMuted to true one volume is 0 in full screen mode

da5edf8

chore: fix react-compiler checks

44ff609

eh2077 approved these changes Aug 9, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval August 9, 2024 08:57

cristipaval approved these changes Aug 9, 2024

View reviewed changes

cristipaval merged commit 7d9203b into Expensify:main Aug 9, 2024

github-actions bot mentioned this pull request Aug 12, 2024

Deploy Checklist: New Expensify 2024-08-12 #47219

Closed

90 tasks

IuliiaHerets mentioned this pull request Aug 13, 2024

[$250] Android – Sign in–Sound option is missing when Get started modal video opened to full screen #47295

Closed

6 tasks

blazejkustra mentioned this pull request Dec 5, 2024

Fix unstable sound level #53449

Merged

50 tasks

hungvu193 reviewed Dec 18, 2024

View reviewed changes

eh2077 reviewed Apr 22, 2025

View reviewed changes

Conversation

dominictb commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 5, 2024

Uh oh!

eh2077 commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Aug 6, 2024

Uh oh!

dominictb commented Aug 7, 2024

Uh oh!

eh2077 commented Aug 8, 2024

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 9, 2024

Uh oh!

IuliiaHerets commented Aug 13, 2024

Uh oh!

eh2077 commented Aug 13, 2024

Uh oh!

dominictb commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented Aug 14, 2024

Uh oh!

hungvu193 Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eh2077 Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dominictb commented Aug 5, 2024 •

edited

Loading

eh2077 commented Aug 6, 2024 •

edited

Loading

dominictb commented Aug 13, 2024 •

edited

Loading

hungvu193 Dec 18, 2024 •

edited

Loading