Skip to content

fix: update volume to 0.25 if unmute but volume is 0 #46795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 3 commits into from
Aug 9, 2024
Merged

fix: update volume to 0.25 if unmute but volume is 0 #46795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9972b71
fix: update volume to 0.25 if unmute but volume is 0
dominictb Aug 5, 2024
da5edf8
fix: manually set isMuted to true one volume is 0 in full screen mode
dominictb Aug 7, 2024
44ff609
chore: fix react-compiler checks
dominictb Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/VideoPlayer/BaseVideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ function BaseVideoPlayer({
[playVideo, videoResumeTryNumberRef],
);

const prevIsMutedRef = useRef(false);
const prevVolumeRef = useRef(0);

const handlePlaybackStatusUpdate = useCallback(
(status: AVPlaybackStatus) => {
if (!status.isLoaded) {
Expand All @@ -142,6 +145,16 @@ function BaseVideoPlayer({
onPlaybackStatusUpdate?.(status);
return;
}

if (prevIsMutedRef.current && prevVolumeRef.current === 0 && !status.isMuted) {
Copy link
Contributor

@eh2077 eh2077 Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused #60117, see #60117 (comment)

updateVolume(0.25);
}
Comment on lines +149 to +151
Copy link
Contributor

@hungvu193 hungvu193 Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line caused this issue:
#52858

More details in: #52858 (comment)

if (isFullScreenRef.current && prevVolumeRef.current !== 0 && status.volume === 0 && !status.isMuted) {
currentVideoPlayerRef.current?.setStatusAsync({isMuted: true});
}
prevIsMutedRef.current = status.isMuted;
prevVolumeRef.current = status.volume;

const isVideoPlaying = status.isPlaying;
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const currentDuration = status.durationMillis || videoDuration * 1000;
Expand Down