[Workspace Chats for All] Default QAB to primary workspace if no value by ishpaul777 · Pull Request #51836 · Expensify/App

ishpaul777 · 2024-10-31T20:58:32Z

Explanation of Change

it looks for NVP_ACTIVE_POLICY_ID and policychat associated with that policy id where reportOwnerId is currentUserID and then if NVP_QUICK_ACTION_GLOBAL_CREATE not present we show Scan receipt QAB

Fixed Issues

$ #50728
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Sign up with a new account and complete the onboarding process
Create a new workspace
Open FAB "+" menu, Verify that the Scan receipt QAB is shown

Offline tests

QA Steps

Verify that no errors appear in the JS console

Sign up with a new account and complete the onboarding process
Create a new workspace
Open FAB "+" menu, Verify that the Scan receipt QAB is shown

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-01.at.10.05.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-01.at.10.11.20.PM.mov

iOS: Native

Screen.Recording.2024-11-01.at.9.59.07.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-01.at.9.57.39.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-01.at.9.54.53.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-01.at.10.14.02.PM.mov

melvin-bot · 2024-11-01T16:55:40Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

ishpaul777 · 2024-11-01T18:56:22Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

+                        }, true);
+                    }),
+                shouldShowSubscriptRightAvatar: true,
+                shouldRenderTooltip: false,


i am not sure about this one if we should show tool tip or not, my understanding is this QAB will be the first default QAB for new user so we should show but we also have quickAction.isFirstQuickAction logic so when its true it will show it again

thoughts? @puneetlath @dukenv0307

Can you share the video when shouldRenderTooltip: quickAction.isFirstQuickAction? BTW I think we should show the tooltip for the first quick action, but I don't see it in your video

I like the idea of showing it from the start.

actually i have noticed that tooltip is not showing on staging even on first QAB action, might be a bug how we show it, but i am still investigating

@dukenv0307 Can you please confirm ^ this on staging

okay confirmed, showing green tooltip inside a Popover menu is broken at Base component on staging also, it came from #49913

Ok maybe we fix that separately then?

i think yes that's better, it seems to be tricky i can fix it by removing this logic here

https://github.com/Expensify/App/pull/49913/files#diff-947af496a4b67d6f1108d999ee2c45a718ba739e3605410e3c689cd89e06bb4d, but that might bring back the issue the PR solves

ishpaul777 · 2024-11-01T20:24:19Z

Previously we reverted withOnyx -> useOnyx migration becuase it caused a regression #51242, so i feel little hesitant to do it again given that we already have dedicated PR to handle migration for this component also #51700

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

dukenv0307 · 2024-11-02T03:25:52Z

Alright, for the tooltip bug for quick action, let's create a separate issue

dukenv0307 · 2024-11-02T03:42:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-02.at.10.36.53.mov

Android: mWeb Chrome

Screen.Recording.2024-11-02.at.10.35.22.mov

iOS: Native

Screen.Recording.2024-11-02.at.10.37.45.mov

iOS: mWeb Safari

Screen.Recording.2024-11-02.at.10.34.04.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-02.at.10.29.29.mov

MacOS: Desktop

Screen.Recording.2024-11-02.at.10.41.01.mov

dukenv0307 · 2024-11-02T03:42:28Z

LGTM, just left one minor comment

…pover.tsx Co-authored-by: dukenv0307 <129500732+dukenv0307@users.noreply.github.com>

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

…pover.tsx

ishpaul777 · 2024-11-04T17:00:40Z

@puneetlath ready for you review

puneetlath

Sorry for the delay. Looks like you have a conflict. Thanks for the quick work though!

ishpaul777 · 2024-11-05T21:27:23Z

i need to retest after merge but site seems down requests are processig very slow will try again after few minutes

ishpaul777 · 2024-11-05T22:51:46Z

src/libs/ReportUtils.ts


-function getWorkspaceChats(policyID: string, accountIDs: number[]): Array<OnyxEntry<Report>> {
-    const allReports = ReportConnection.getAllReports();
+function getWorkspaceChats(policyID: string, accountIDs: number[], allReports: OnyxCollection<Report> = ReportConnection.getAllReports()): Array<OnyxEntry<Report>> {


this is because ReportConnection.getAllReports() not always have latest snapshot of collection and has stale data which might cause to newly create workspace chat to never exist instead we subscribed to allreports in component using useOnyx which gurantees to have get latest data

more details:

App/tests/actions/EnforceActionExportRestrictions.ts

Lines 7 to 10 in 3c1a533

// There are some methods that are OK to use inside an action file, but should not be exported. These are typically methods that look up and return Onyx data.

// The correct pattern to use is that every file will use it's own withOnyx or Onyx.connect() to access the Onyx data it needs. This prevents data from becoming stale

// and prevents side-effects that you may not be aware of. It also allows each file to access Onyx data in the most performant way. More context can be found in

// https://github.com/Expensify/App/issues/27262

puneetlath · 2024-11-06T17:23:42Z

Ready for a re-review?

ishpaul777 · 2024-11-06T17:40:43Z

yes it is @puneetlath

OSBotify · 2024-11-06T18:08:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-07T13:09:08Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-11T18:14:43Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

allroundexperts · 2024-12-25T19:25:39Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

+                                const isValidReport = !(isEmptyObject(policyChatForActivePolicy) || ReportUtils.isArchivedRoom(policyChatForActivePolicy, reportNameValuePairs));
+                                const quickActionReportID = isValidReport ? policyChatForActivePolicy?.reportID ?? '-1' : ReportUtils.generateReportID();
+                                IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID ?? '-1', CONST.IOU.REQUEST_TYPE.SCAN, true);


Addition of this caused You no longer have access to your previous... to be displayed when first expense was submitted via QAB.

v1 changes

71e37a5

ishpaul777 changed the title ~~v1 changes~~ [Workspace Chats for All] Default QAB to primary workspace if no value Oct 31, 2024

ishpaul777 marked this pull request as ready for review November 1, 2024 16:55

ishpaul777 requested a review from a team as a code owner November 1, 2024 16:55

melvin-bot bot requested review from dukenv0307 and removed request for a team November 1, 2024 16:55

fixes

62fe24c

dukenv0307 reviewed Nov 1, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 1, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 1, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

dukenv0307 reviewed Nov 1, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

ishpaul777 commented Nov 1, 2024

View reviewed changes

ishpaul777 added 7 commits November 2, 2024 00:29

fixes avatar handling

060c3cc

resolve review comments

32aaff8

merge usememos

a00c2e2

lint

9462bbd

fix lint

0b6e497

remove console

508065a

use isEmptyObject

c80ae45

ishpaul777 requested a review from dukenv0307 November 1, 2024 20:07

ishpaul777 requested a review from puneetlath November 1, 2024 20:25

dukenv0307 reviewed Nov 2, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

Update src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPo…

92bb507

…pover.tsx Co-authored-by: dukenv0307 <129500732+dukenv0307@users.noreply.github.com>

ishpaul777 commented Nov 2, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

Update src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPo…

f4992c7

…pover.tsx

dukenv0307 approved these changes Nov 4, 2024

View reviewed changes

puneetlath previously approved these changes Nov 5, 2024

View reviewed changes

Merge branch 'main' into feat/50728

552885a

ishpaul777 dismissed puneetlath’s stale review via 552885a November 5, 2024 21:03

minor improvements

ccee92f

ishpaul777 requested review from dukenv0307 and puneetlath November 5, 2024 22:46

ishpaul777 commented Nov 5, 2024

View reviewed changes

Merge branch 'Expensify:main' into feat/50728

4395c5f

puneetlath approved these changes Nov 6, 2024

View reviewed changes

puneetlath merged commit 1551bac into Expensify:main Nov 6, 2024

github-actions bot mentioned this pull request Nov 7, 2024

Deploy Checklist: New Expensify 2024-11-07 #52178

Closed

60 tasks

IuliiaHerets mentioned this pull request Nov 7, 2024

[HOLD for payment 2024-11-21] QAB - Scan QAB is not displayed for offline created workspace #52186

Closed

8 tasks

melvin-bot bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-18] [Workspace Chats for All] Default QAB to primary workspace if no value #50728

Closed

allroundexperts reviewed Dec 25, 2024

View reviewed changes

	// There are some methods that are OK to use inside an action file, but should not be exported. These are typically methods that look up and return Onyx data.
	// The correct pattern to use is that every file will use it's own withOnyx or Onyx.connect() to access the Onyx data it needs. This prevents data from becoming stale
	// and prevents side-effects that you may not be aware of. It also allows each file to access Onyx data in the most performant way. More context can be found in
	// https://github.com/Expensify/App/issues/27262

Conversation

ishpaul777 commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dukenv0307 commented Nov 2, 2024

Uh oh!

dukenv0307 commented Nov 2, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Nov 2, 2024

Uh oh!

Uh oh!

ishpaul777 commented Nov 4, 2024

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Nov 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Nov 6, 2024

Uh oh!

ishpaul777 commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Nov 6, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 11, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ishpaul777 commented Oct 31, 2024 •

edited

Loading

ishpaul777 Nov 1, 2024 •

edited

Loading

ishpaul777 Nov 1, 2024 •

edited

Loading

ishpaul777 commented Nov 1, 2024 •

edited

Loading

ishpaul777 commented Nov 6, 2024 •

edited

Loading