Rename Money Request/Split/Pay step header names by c3024 · Pull Request #53004 · Expensify/App

c3024 · 2024-11-23T13:35:52Z

Explanation of Change

This PR updates the step details as per the details here.

Fixed Issues

$ #52502
PROPOSAL:

Tests

Test all these flows and verify that the names in screen headers appear as per the document.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

headerAndroid.mov

Android: mWeb Chrome

Screenrecorder-2024-11-25-13-49-42-926.mp4

iOS: Native

headeriOS.mov

iOS: mWeb Safari

RPReplay_Final1732522667.MP4

MacOS: Chrome / Safari

headersChrome1.mov

headersChrome3.mov

MacOS: Desktop

headerDesktop.mov

melvin-bot · 2024-11-23T13:44:08Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-11-24T11:24:49Z

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

        }
-        return translate('iou.submitExpense');
-    }, [iouType, report, translate, isSharingTrackExpense, isCategorizingTrackExpense, isSubmittingFromTrackExpense]);
+        return translate('iou.confirmDetails');


We should remove isSubmittingFromTrackExpense, CONST.IOU.TYPE.SPLIT, CONST.IOU.TYPE.TRACK, PAY blocks

dukenv0307 · 2024-11-24T11:25:03Z

src/pages/iou/request/step/IOURequestStepParticipants.tsx

            return translate('workspace.invoices.sendInvoice');
        }
-        return translate('iou.submitExpense');
+        return translate('iou.chooseRecipient');


Same as above

dukenv0307 · 2024-11-25T07:14:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

safari.mp4

MacOS: Chrome / Safari

Track expense

track-expense.mp4

Create expense

create-expense.mp4

Split expense

split-expense.mp4

Pay someone

Pay.mp4

MacOS: Desktop

desktop.mp4

dukenv0307 · 2024-11-25T07:15:32Z

@c3024 Can you please complete your screenshots/videos on all platforms? Thanks

c3024 · 2024-11-25T08:41:09Z

@dukenv0307 Done!

OSBotify · 2024-11-25T22:09:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-26T16:42:03Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.67-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mountiny · 2024-11-28T07:52:33Z

@c3024 @dukenv0307 apparently this is still failing the original issue #53142 (comment)

mountiny · 2024-11-28T07:52:52Z

Can you please look into fixing it in a follow up? thanks!

c3024 · 2024-11-28T07:57:09Z

@mountiny

What QA raised is different. This PR only changes headers of the money request flow steps. It cannot cause that bug.

"Create expense" shows up in FAB and the composer picker instead of "Submit expense" or "Track expense" for even number account ids.

App/src/libs/Permissions.ts

Lines 32 to 36 in 10a7be8

    
           function canUseCombinedTrackSubmit(): boolean { 
        
               // We don't need to show this to all betas since this will be used for developing a feature for A/B testing. 
        
               const session = SessionUtils.getSession(); 
        
               return isAccountIDEven(session?.accountID ?? -1); 
        
           }

mountiny · 2024-11-28T08:00:21Z

@c3024 ok thanks for confirming!

mvtglobally · 2024-11-28T13:35:16Z

Ki #52897 reproduced when running this PR

trim.18A3D59B-9F70-46BE-8108-BE933756E95A.MOV

github-actions · 2024-11-28T14:23:06Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.67-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

c3024 added 2 commits November 23, 2024 19:01

rename IOU request step header names

45dfede

fix lint

3288634

c3024 mentioned this pull request Nov 23, 2024

[HOLD for payment 2024-12-05] [$250] Update headers in certain flows to match their screens #52502

Closed

5 tasks

c3024 marked this pull request as ready for review November 23, 2024 13:44

c3024 requested a review from a team as a code owner November 23, 2024 13:44

melvin-bot bot requested a review from dukenv0307 November 23, 2024 13:44

melvin-bot bot removed the request for review from a team November 23, 2024 13:44

dukenv0307 reviewed Nov 24, 2024

View reviewed changes

c3024 added 3 commits November 24, 2024 17:29

remove redundant code

bb4ed92

fix lint

4895a2d

remove unused variable

7700226

dukenv0307 approved these changes Nov 25, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam November 25, 2024 15:34

thienlnam approved these changes Nov 25, 2024

View reviewed changes

thienlnam merged commit f97808a into Expensify:main Nov 25, 2024

github-actions bot mentioned this pull request Nov 26, 2024

Deploy Checklist: New Expensify 2024-11-26 #53142

Closed

75 tasks

Conversation

c3024 commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 23, 2024

Uh oh!

dukenv0307 Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Nov 25, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Nov 25, 2024

Uh oh!

c3024 commented Nov 25, 2024

Uh oh!

OSBotify commented Nov 25, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

mountiny commented Nov 28, 2024

Uh oh!

mountiny commented Nov 28, 2024

Uh oh!

c3024 commented Nov 28, 2024

Uh oh!

mountiny commented Nov 28, 2024

Uh oh!

mvtglobally commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

c3024 commented Nov 23, 2024 •

edited

Loading

mvtglobally commented Nov 28, 2024 •

edited

Loading