Adding animation for children of switch components by sumo-slonik · Pull Request #53938 · Expensify/App

sumo-slonik · 2024-12-11T14:42:36Z

Explanation of Change

These PR add animations of the appearance and disappearance of elements after the switch using reanimated.

Fixed Issues

$ #53759

PROPOSAL:

Tests

Go to settings
Launch workflows
Enter workflows
Click the switches and check if the content below appears with a smooth animation

Verify that no errors appear in the JS console

Offline tests

Offline tests are not needed.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

web.android.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

web.ios.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

github-actions · 2024-12-12T15:59:23Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

Kicu

Looks mostly ok. There is one thing with the translation keys and state that is a bit confusing. If you cannot rewrite it in any way, then at least drop a comment.
Otherwise lgtm 👍

You have a typo in name of the PR: childreans -> childrens

Kicu · 2024-12-13T09:34:39Z

src/components/Acordition/index.tsx

+import type {SharedValue} from 'react-native-reanimated';
+import Animated, {useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated';
+
+function AccordionItem({isExpanded, children, duration = 300}: {isExpanded: SharedValue<boolean>; children: ReactNode; duration?: number}) {


Please make sure the file and main export are named the same:
Component is called AccordionItem but the file is Accordion/index.ts (you have a type in the name).

Kicu · 2024-12-13T09:37:55Z

src/components/Acordition/index.tsx

+    }));
+
+    return (
+        <Animated.View style={[bodyStyle, {overflow: 'hidden'}]}>


Suggested change

<Animated.View style={[bodyStyle, {overflow: 'hidden'}]}>

<Animated.View style={[bodyStyle, styles.overflowHidden]}>

where styles come from:
const styles = useThemeStyles();

Kicu · 2024-12-13T09:39:56Z

src/components/Switch.tsx

    disabledAction?: () => void;
+
+    /**
+     * onStateChange: Callback function triggered only after the external state of the switch has successfully changed.


Suggested change

* onStateChange: Callback function triggered only after the external state of the switch has successfully changed.

* Callback function triggered only after the external state of the switch has successfully changed.

repeating the name is not needed, as the name of prop is right below this comment

I feel like this comment is a bit inaccurate.
This callback is triggered inside Switch component after the external state has changed AND the animation has finished, right?

Because if it was only after state change, then the external component could handle this itself. So I'm guessing it is important that this runs after the line:
offsetX.set(withTiming([...])...

Does this make sense?

Yes after the animation of moving the circle inside the switch, but it is this callback that actually triggers in our case the animation of rolling up and unrolling children

Kicu · 2024-12-13T09:47:42Z

src/pages/workspace/accounting/intacct/import/SageIntacctToggleMappingsPage.tsx

+        if (!isImportMappingEnable) {
+            return;
+        }
+        setTranslationKey(getDisplayTypeTranslationKeys(config?.mappings?.[mappingName]));


This line will be confusing, since assigning translation keys to state is quite uncommon.
Perhaps we could add a short 1-line comment to at least say its done for animation purpose?

The problem here is that changing the switch changes the content of the object:
config.mappings
which resulted in changing the content of the translation itself, that's why I changed the assignment here to only non-empty values, I was afraid of operating on the config logic itself so I think it's safe to leave a comment here

github-actions · 2024-12-13T18:06:19Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-13T18:34:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53938/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53938/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53938/NewExpensify.dmg	https://53938.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Kicu

LGTM 👍 the animation is tricky but I was not able to come up with a better solution

melvin-bot · 2024-12-16T08:38:34Z

@dubielzyk-expensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra

Great work @sumo-slonik 🚀

blazejkustra · 2024-12-16T10:29:57Z

src/pages/workspace/accounting/intacct/import/SageIntacctToggleMappingsPage.tsx

+    // We are storing translation keys in the local state for animation purposes.
+    // Otherwise, the values change to undefined immediately after clicking, before the closing animation finishes,
+    // resulting in a janky animation effect.
+


Suggested change

blazejkustra · 2024-12-16T10:32:52Z

src/components/Switch.tsx

        offsetX.set(withTiming(isOn ? OFFSET_X.ON : OFFSET_X.OFF, {duration: 300}));
-    }, [isOn, offsetX]);
+        if (onStateChange) {
+            onStateChange(isOn);


Can't we use onToggle for this? 🤔

Unfortunately it seems to me that it does not, because doing it in onToggle called the animation trigger at the wrong time, but I will make sure that in the final version of the code it did not become possible

I was able to remove the use of this method and it is no longer needed.

blazejkustra · 2024-12-16T10:33:54Z

src/components/Accordion/index.tsx

+import Animated, {useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated';
+import useThemeStyles from '@hooks/useThemeStyles';
+
+function Accordion({isExpanded, children, duration = 300}: {isExpanded: SharedValue<boolean>; children: ReactNode; duration?: number}) {


Let's extract props type to a separate type above, a good rule of thumb is to always do it for complex types like this

blazejkustra · 2024-12-16T10:35:27Z

src/components/Accordion/index.tsx

+                onLayout={(e) => {
+                    height.set(e.nativeEvent.layout.height);
+                }}
+                style={{position: 'absolute', left: 0, right: 0, top: 0}}


Let's use styling utilities here:

styles.pAbsolute, styles.t0 ...

dubielzyk-expensify · 2024-12-17T05:05:21Z

The animation works well, but the padding here is wrong:

All rows go to the end and the padding should be like this:

sumo-slonik · 2024-12-17T08:47:27Z

@dubielzyk-expensify good catch, I'll fix it

sumo-slonik · 2024-12-17T09:58:12Z

@dubielzyk-expensify
Is it good now?

Screen.Recording.2024-12-17.at.10.53.55.mov

…itch_childreans

sumo-slonik · 2025-01-13T14:57:18Z

@mountiny
I reverted all changes unrelated to workflows. If QA confirms that everything works as expected, I have the changes ready for the remaining areas and will create a PR for them.

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

adamgrzybowski · 2025-01-14T09:51:01Z

src/libs/Navigation/linkTo/index.ts

+    if (
+        action &&
+        'payload' in action &&
+        action.payload &&
+        'name' in action.payload &&
+        (isSideModalNavigator(action.payload.name) || action.payload.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR)
+    ) {


These navigation changes were consulted with me. We need to PUSH screens in FullScreenNavigator instead of NAVIGATE to ensure animations and history work properly

…itch_childreans

mountiny

Thanks! Asked @thesahindia for final check over and testing

src/components/Accordion/index.tsx

thesahindia · 2025-01-14T16:51:09Z

@sumo-slonik, it's not working on the native

Screen.Recording.2025-01-14.at.10.04.59.PM.mov

sumo-slonik · 2025-01-14T17:02:35Z

@thesahindia I'm looking on it.

sumo-slonik · 2025-01-15T11:36:47Z

@thesahindia Everything should be fine now, you can check and let me know what you think.

mountiny · 2025-01-15T12:21:05Z

@thesahindia should be ready again

thesahindia · 2025-01-15T21:17:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-16.at.1.44.35.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-16.at.1.48.52.AM.mov

iOS: Native

Screen.Recording.2025-01-16.at.1.26.04.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-14.at.8.55.59.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-14.at.8.50.38.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-14.at.8.54.02.PM.mov

thesahindia

Tests well!

mountiny

Thank you!

OSBotify · 2025-01-16T22:14:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-17T13:54:35Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-21T08:07:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Krishna2323 · 2026-03-18T00:37:28Z

src/components/Accordion/index.native.tsx

+        }
+        return {
+            height: !isToggleTriggered.get() ? height.get() : derivedHeight.get(),
+            opacity: derivedOpacity.get(),


This PR introduced a regression: #79463

The Accordion component used absolute positioning for children without setting overflow: 'hidden' on the animated container. This caused collapsed (invisible) content to still intercept taps — e.g., tapping the empty area below a disabled Import toggle in Sage Intacct settings would open the "Displayed as" page.

Fixed in #83651 by adding overflow: 'hidden' when the accordion is collapsed.

sumo-slonik added 5 commits December 11, 2024 10:46

smooth animation

dad3f55

work in progress

457b549

clean code before PR

eaa7d47

animation works in all places

d852938

refactor before PR

2b2b451

sumo-slonik mentioned this pull request Dec 12, 2024

[Due for payment 2025-02-26] [HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections #53759

Closed

mountiny assigned sumo-slonik Dec 12, 2024

mountiny added the Ready To Build label Dec 12, 2024

This comment has been minimized.

Sign in to view

Kicu reviewed Dec 13, 2024

View reviewed changes

changes after code review

c2fb131

sumo-slonik changed the title ~~Feature/kuba nowakowski/add animation for switch childreans~~ Feature/kuba nowakowski/add animation for switch childrens Dec 16, 2024

Kicu approved these changes Dec 16, 2024

View reviewed changes

sumo-slonik marked this pull request as ready for review December 16, 2024 08:38

sumo-slonik requested a review from a team as a code owner December 16, 2024 08:38

melvin-bot bot requested review from dubielzyk-expensify and thesahindia December 16, 2024 08:38

melvin-bot bot removed the request for review from a team December 16, 2024 08:38

blazejkustra suggested changes Dec 16, 2024

View reviewed changes

changes after Blazej review

4473400

fix padding problem in toggle page

7443bc5

sumo-slonik added 2 commits December 17, 2024 11:02

Merge branch 'main' into feature/kuba_nowakowski/add_animation_for_sw…

6c8771d

…itch_childreans

fix eslint

24cd3ca

Revert changes different from the workflows page.

a23be73

sumo-slonik force-pushed the feature/kuba_nowakowski/add_animation_for_switch_childreans branch from fe701f5 to a23be73 Compare January 13, 2025 14:51

blazejkustra approved these changes Jan 14, 2025

View reviewed changes

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx Show resolved Hide resolved

adamgrzybowski reviewed Jan 14, 2025

View reviewed changes

Merge branch 'main' into feature/kuba_nowakowski/add_animation_for_sw…

67a6187

…itch_childreans

mountiny reviewed Jan 14, 2025

View reviewed changes

src/components/Accordion/index.tsx Show resolved Hide resolved

change suggested by Vit

a65661f

sumo-slonik added 3 commits January 14, 2025 20:37

works almost perfect

d7e1334

works perfect

a174547

ready for tests

8c39088

thesahindia approved these changes Jan 15, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny January 15, 2025 21:18

mountiny approved these changes Jan 16, 2025

View reviewed changes

mountiny merged commit 9500fec into Expensify:main Jan 16, 2025

github-actions bot mentioned this pull request Jan 17, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

AndrewGable mentioned this pull request Jan 17, 2025

[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature #55413

Closed

8 tasks

samranahm mentioned this pull request Jan 19, 2025

iOS - Swiping back after enabling feature returns to features page instead of workspace list #55414

Closed

8 tasks

dubielzyk-expensify mentioned this pull request Jan 21, 2025

Add animation for switch children #55478

Merged

50 tasks

sumo-slonik mentioned this pull request Jan 21, 2025

Added working animation to switch in accounting page #55412

Merged

50 tasks

Krishna2323 reviewed Mar 18, 2026

View reviewed changes

Krishna2323 mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-11] [$250] Android - Intacct - Empty area below Import opens Displayed as page when Import is disabled #79463

Closed

7 tasks

	<Animated.View style={[bodyStyle, {overflow: 'hidden'}]}>
	<Animated.View style={[bodyStyle, styles.overflowHidden]}>

	* onStateChange: Callback function triggered only after the external state of the switch has successfully changed.
	* Callback function triggered only after the external state of the switch has successfully changed.

Conversation

sumo-slonik commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

This comment has been minimized.

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

github-actions bot commented Dec 13, 2024

Uh oh!

Kicu left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 16, 2024

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Dec 17, 2024

Uh oh!

sumo-slonik commented Dec 17, 2024

Uh oh!

sumo-slonik commented Dec 17, 2024

Uh oh!

sumo-slonik commented Jan 13, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thesahindia commented Jan 14, 2025

Uh oh!

sumo-slonik commented Jan 14, 2025

Uh oh!

sumo-slonik commented Jan 15, 2025

Uh oh!

mountiny commented Jan 15, 2025

Uh oh!

thesahindia commented Jan 15, 2025

Reviewer Checklist

sumo-slonik commented Dec 11, 2024 •

edited

Loading