Add animation for switch children by sumo-slonik · Pull Request #55478 · Expensify/App

sumo-slonik · 2025-01-20T14:52:12Z

Explanation of Change

These PR add animations of the appearance and disappearance of elements after the switch using reanimated.

Fixed Issues

$ #53759
Fixed also reason to reverse previous revert:
$ #55451

PROPOSAL:

Tests

Go to Settings.
Launch Workflows.
Check if workflows appear correctly with animations (especially on iOS).
Enter Workflows.
Click the switches and check if the content below appears with smooth animation.

Verify that no errors appear in the JS console

Offline tests

Offline tests are not needed.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-21.at.12.12.57.mp4

Android: mWeb Chrome

Screen.Recording.2025-01-21.at.12.38.23.mp4

iOS: Native

Screen.Recording.2025-01-20.at.16.07.39.mp4

iOS: mWeb Safari

Screen.Recording.2025-01-20.at.16.13.57.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-20.at.16.17.23.mp4

MacOS: Desktop

Screen.Recording.2025-01-20.at.16.40.29.mp4

…itch_childreans

blazejkustra

LGTM!

blazejkustra · 2025-01-20T16:03:41Z

src/pages/workspace/WorkspaceInitialPage.tsx

                    prevPendingFields?.[key] !== policy?.pendingFields?.[key] || isOffline || !policy?.pendingFields?.[key] ? isFeatureEnabled : currentFeatureStates[key];
            });
+
+            setHighlightedFeature(Object.keys(newFeatureStates).at(0) ?? '');


NAB: instead of empty string we could use undefined.

melvin-bot · 2025-01-20T20:22:48Z

@dubielzyk-expensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2025-01-21T04:21:28Z

Same thing as we discussed in this draft PR but the padding is off here on the Android recording:

The workflow animations looks pretty great 😄

Also MacOS Desktop, iOS mWeb, and Android mWeb videos didn't upload or display properly.

…itch_childreans

sumo-slonik · 2025-01-21T11:50:50Z

@dubielzyk-expensify

Same thing as we discussed in this draft PR but the padding is off here on the Android recording:

The workflow animations looks pretty great 😄

Also MacOS Desktop, iOS mWeb, and Android mWeb videos didn't upload or display properly.

here are not these changes for accounting tabs, they will be in a separaten PR, I added the wrong recording. It is already corrected

mountiny · 2025-01-21T21:41:48Z

@thesahindia What is your eta for this review?

@sumo-slonik could you please highligh in the diff the changes made to fix the issue found in staging? thanks!

dubielzyk-expensify · 2025-01-22T04:38:56Z

here are not these changes for accounting tabs, they will be in a separaten #55412, I added the wrong recording. It is already corrected

Ahh all good then. It looks good to me on the workflow page 👍

sumo-slonik · 2025-01-22T09:32:41Z

here are not these changes for accounting tabs, they will be in a separaten #55412, I added the wrong recording. It is already corrected

Ahh all good then. It looks good to me on the workflow page 👍

if you want to see what the other tabs will look like you can check PR:
PR
That PR is ready but I'm not opening it because first we need to merge this one.

thesahindia · 2025-01-22T11:51:39Z

There's an issue in navigation.

Navigate to "More features"
Enable any feature (e.g., Workflows)
Click on "Workflows"
Return to "More features"
Disable "Workflows"
Click the browser back button

Screen.Recording.2025-01-22.at.4.54.31.PM.mov

thesahindia · 2025-01-22T12:02:11Z

Currently, there's a sliding animation when a newly enabled feature appears in the list. Are we okay with just highlighting the new feature instead?

Current behaviour:

Screen.Recording.2025-01-22.at.5.20.33.PM.mov

New behaviour:

Screen.Recording.2025-01-22.at.5.19.14.PM.mov

sumo-slonik · 2025-01-22T13:31:01Z

There's an issue in navigation.

Navigate to "More features"

Enable any feature (e.g., Workflows)

Click on "Workflows"

Return to "More features"

Disable "Workflows"

Click the browser back button

Screen.Recording.2025-01-22.at.4.54.31.PM.mov

This also occurs on https://new.expensify.com, so I think it's not due to this PR

sumo-slonik · 2025-01-22T13:58:16Z

src/pages/workspace/WorkspaceInitialPage.tsx

    const [featureStates, setFeatureStates] = useState(policyFeatureStates);
+    const [highlightedFeature, setHighlightedFeature] = useState<string | undefined>(undefined);
+
+    const workspaceMenuItems: WorkspaceMenuItem[] = useMemo(() => {


@mountiny

@sumo-slonik could you please highligh in the diff the changes made to fix the issue found in staging? thanks!

The addition of mnemonization here eliminates the problem that caused unnecessary rerendering and caused the flag responsible for highlighting to be removed.

github-actions · 2025-01-22T14:10:10Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-22T14:10:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

blazejkustra · 2025-01-22T16:50:17Z

@mountiny this looks weird, ad hoc builds are failing with a surprising error:

mountiny · 2025-01-24T20:47:50Z

@sumo-slonik thanks! Can you please fix the lint?

@thesahindia please feel free to review and test even with the failing action. Thanks

sumo-slonik · 2025-01-27T10:23:28Z

Hi, it seems to me that this is a rather large PR and in the changes I added there is already a risk of regression, I would prefer to avoid correcting imports not related to my PR in order not to increase this risk unnecessarily. What do you think about this @mountiny ?

thesahindia · 2025-01-27T11:02:15Z

src/libs/PolicyUtils.ts

 }

+function goBackWhenEnableFeature(policyID: string) {
+    setTimeout(() => {


I'm a bit concerned about using setTimeout, we try to avoid it unless absolutely necessary.

cc: @mountiny

is exactly the same solution as it was before in the navigate function:

function navigateWhenEnableFeature(policyID: string) { setTimeout(() => { Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID)); }, CONST.WORKSPACE_ENABLE_FEATURE_REDIRECT_DELAY); }

which we replacing here

Ah, my bad. Let's not make any changes here then.

thesahindia · 2025-01-27T11:47:29Z

This one needs to be updated as well.

App/src/libs/actions/Policy/Tag.ts

Line 695 in b59f23b

navigateWhenEnableFeature(policyID);

Please remove the function as well.

App/src/libs/PolicyUtils.ts

Line 1066 in b59f23b

function navigateWhenEnableFeature(policyID: string) {

mountiny · 2025-01-27T13:55:14Z

@sumo-slonik sounds fine, if all the lint issues are about the import rule then dont worry about it

…itch_childreans # Conflicts: # src/pages/workspace/WorkspaceInitialPage.tsx

sumo-slonik · 2025-01-28T10:43:22Z

I've already resolved the conflict but I'm checking if it still works on all platforms after attaching the master

sumo-slonik · 2025-01-28T13:38:45Z

@thesahindia
Everything is working, and you can start testing.

thesahindia · 2025-01-29T12:26:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-01-29.at.5.50.00.PM.mov

iOS: Native

Screen.Recording.2025-01-25.at.9.54.21.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-25.at.10.12.42.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-25.at.10.14.39.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-25.at.10.17.30.PM.mov

thesahindia

Works well!

mountiny

The PR is large enough already so we decided not ot fix all the libs import lint errors.

melvin-bot · 2025-01-29T15:57:02Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2025-01-29T15:57:15Z

Explained above

OSBotify · 2025-01-29T16:06:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-30T01:59:08Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-31T06:48:57Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

ikevin127 · 2025-01-31T20:36:36Z

src/libs/Navigation/linkTo/index.ts

+        'payload' in action &&
+        action.payload &&
+        'name' in action.payload &&
+        (isSideModalNavigator(action.payload.name) || action.payload.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR)


Looks like this line was missing 1 extra check which led to the causation of this issue:

[HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings #56025
which was addressed in PR:

[CP Staging] Fix navigation loop on the members csv import page #56088

ishpaul777 · 2025-02-21T18:05:35Z

src/pages/workspace/WorkspaceInitialPage.tsx

+            protectedMenuItems.push({
+                translationKey: 'common.perDiem',
+                icon: CalendarSolid,
+                action: singleExecution(waitForNavigate(() => Navigation.navigate(ROUTES.WORKSPACE_PER_DIEM.getRoute(policyID)))),
+                routeName: SCREENS.WORKSPACE.PER_DIEM,
+            });


there was a regression, we did not added highlighted prop which caused #56149

sumo-slonik added 3 commits January 20, 2025 15:30

fix problem in WorkspaceInitialPage when adding new feature

20b38b2

Merge branch 'main' into feature/kuba_nowakowski/add_animation_for_sw…

8736bbd

…itch_childreans

add accordion component

91e739a

sumo-slonik changed the title ~~[Draft] Add animation for switch childreans~~ [Draft] Add animation for switch children Jan 20, 2025

blazejkustra approved these changes Jan 20, 2025

View reviewed changes

fix imports

6ac60f3

sumo-slonik marked this pull request as ready for review January 20, 2025 20:22

sumo-slonik requested a review from a team as a code owner January 20, 2025 20:22

melvin-bot bot requested review from dubielzyk-expensify and thesahindia and removed request for a team January 20, 2025 20:22

sumo-slonik changed the title ~~[Draft] Add animation for switch children~~ Add animation for switch children Jan 20, 2025

blazejkustra mentioned this pull request Jan 21, 2025

[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature #55413

Closed

8 tasks

mountiny self-requested a review January 21, 2025 07:54

Merge branch 'main' into feature/kuba_nowakowski/add_animation_for_sw…

760362c

…itch_childreans

mountiny assigned sumo-slonik Jan 21, 2025

sumo-slonik commented Jan 22, 2025

View reviewed changes

mountiny added the Ready To Build label Jan 22, 2025

sumo-slonik added 3 commits January 24, 2025 16:10

rename function

aa3e3b7

better naming for function parameters

9839df6

fix import

e84be2a

thesahindia reviewed Jan 27, 2025

View reviewed changes

sumo-slonik added 2 commits January 28, 2025 10:24

remove unused function

2f73c2f

Merge branch 'main' into feature/kuba_nowakowski/add_animation_for_sw…

bd90b09

…itch_childreans # Conflicts: # src/pages/workspace/WorkspaceInitialPage.tsx

sumo-slonik added 2 commits January 28, 2025 13:05

resolve conflicts

44a9e2c

fix linter

a278e11

thesahindia approved these changes Jan 29, 2025

View reviewed changes

mountiny approved these changes Jan 29, 2025

View reviewed changes

mountiny merged commit ced121a into Expensify:main Jan 29, 2025
14 of 15 checks passed

melvin-bot bot added the Emergency label Jan 29, 2025

mountiny removed the Emergency label Jan 29, 2025

github-actions bot mentioned this pull request Jan 30, 2025

Deploy Checklist: New Expensify 2025-01-30 #56018

Closed

48 tasks

melvin-bot bot mentioned this pull request Jan 31, 2025

[Due for payment 2025-02-26] [HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections #53759

Closed

ikevin127 reviewed Jan 31, 2025

View reviewed changes

nkdengineer mentioned this pull request Feb 11, 2025

[$250] Rules - Empty area next to "Prevent self-approvals" toggle button opens not here page #56643

Closed

8 tasks

ishpaul777 reviewed Feb 21, 2025

View reviewed changes

Conversation

sumo-slonik commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jan 20, 2025

Uh oh!

dubielzyk-expensify commented Jan 21, 2025

Uh oh!

sumo-slonik commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 21, 2025

Uh oh!

dubielzyk-expensify commented Jan 22, 2025

Uh oh!

sumo-slonik commented Jan 22, 2025

Uh oh!

thesahindia commented Jan 22, 2025

Uh oh!

thesahindia commented Jan 22, 2025

Uh oh!

sumo-slonik commented Jan 22, 2025

Uh oh!

sumo-slonik Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 22, 2025

Uh oh!

blazejkustra commented Jan 22, 2025

Uh oh!

mountiny commented Jan 24, 2025

Uh oh!

sumo-slonik commented Jan 27, 2025

Uh oh!

thesahindia Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sumo-slonik Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

thesahindia Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 27, 2025

Uh oh!

sumo-slonik commented Jan 28, 2025

Uh oh!

sumo-slonik commented Jan 28, 2025

Uh oh!

thesahindia commented Jan 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jan 29, 2025

sumo-slonik commented Jan 20, 2025 •

edited

Loading

sumo-slonik commented Jan 21, 2025 •

edited

Loading

thesahindia Jan 27, 2025 •

edited

Loading

thesahindia commented Jan 27, 2025 •

edited

Loading