Added working animation to switch in accounting page by sumo-slonik · Pull Request #55412 · Expensify/App

sumo-slonik · 2025-01-17T15:21:30Z

Explanation of Change

Adding animation to the switch in the Accounting tab.

A request to split into two PRs: #53938 (comment)

Fixed Issues

$ #53759

PROPOSAL:

Tests

Go to the "More Features" section.
Activate the accounting page if it is not already activated.
Navigate to the accounting page.
Connect with one of the accounting vendors.
Go to the advanced page.
Toggle some switches and check if the animation is working correctly.

Verify that no errors appear in the JS console

Offline tests

Unnecessary

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-21.at.16.01.18.mov

Android: mWeb Chrome

Screen.Recording.2025-01-21.at.14.21.33.mov

iOS: Native

Screen.Recording.2025-01-21.at.15.17.52.mov

iOS: mWeb Safari

Screen.Recording.2025-01-21.at.14.06.44.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

Screen.Recording.2025-01-21.at.16.04.53.mov

…e first animation.

blazejkustra

It looks very clean this way, great refactor @sumo-slonik. I left couple comments but I think you are very close 👍

src/hooks/useAccordionAnimation.ts

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

…eans' into feature/kuba_nowakowski/add_switch_animations_to_acounting

…s_to_acounting

…s_to_acounting # Conflicts: # src/pages/workspace/accounting/netsuite/advanced/NetSuiteAdvancedPage.tsx

…s_to_acounting

melvin-bot · 2025-01-31T13:21:58Z

@dubielzyk-expensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sumo-slonik · 2025-01-31T13:22:18Z

PR is ready to check.

thesahindia · 2025-01-31T22:58:20Z

Will review it in the morning.

thesahindia · 2025-02-01T16:18:39Z

The background color needs to cover the entire area in the hovered and pressed states. It's only at Xero and Qbo.

sumo-slonik · 2025-02-05T10:57:17Z

@thesahindia can you check it now? it seems to me to be working fine already

dubielzyk-expensify · 2025-02-05T16:01:37Z

Other than the issue called out above, this is looking good to me 👍

sumo-slonik · 2025-02-06T09:57:45Z

@dubielzyk-expensify hover problem is now fixed.

dubielzyk-expensify · 2025-02-06T18:27:21Z

Could I get a new video?

thesahindia · 2025-02-06T22:24:38Z

@sumo-slonik, looks like we need to update "Custom form ID" switch.

NetSuite > Advanced > Custom form ID

Screen.Recording.2025-02-07.at.3.31.38.AM.mov

NAB: If you hover over the children just after you enable the switch, you can see the hoverable area expanding. It's hard to notice and very minor.

Screen.Recording.2025-02-07.at.3.30.09.AM.online-video-cutter.com.1.mp4

sumo-slonik · 2025-02-07T11:58:33Z

@sumo-slonik, looks like we need to update "Custom form ID" switch.
NetSuite > Advanced > Custom form ID

I'm already looking at it.

sumo-slonik · 2025-02-07T13:25:32Z

NetSuite > Advanced > Custom form ID
It seems to me that it's already fixed

Screen.Recording.2025-02-07.at.14.21.24.mov

…s_to_acounting # Conflicts: # src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

thesahindia · 2025-02-11T21:34:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-02-12.at.2.10.16.AM.mov

iOS: Native

Screen.Recording.2025-02-12.at.1.40.50.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-12.at.1.44.23.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-12.at.12.41.23.AM.mov

MacOS: Desktop

Screen.Recording.2025-02-12.at.12.52.08.AM.mov

thesahindia · 2025-02-11T21:48:31Z

In a few places, you may notice the value reverting to the default when you disable the switch. Is it worth fixing?

Screen.Recording.2025-02-12.at.12.37.45.AM.online-video-cutter.com.mp4

cc: @sumo-slonik @dubielzyk-expensify

mountiny

Thank you!

mountiny · 2025-02-17T08:59:39Z

This touches many files to avoid regressions we are not migrating the default ids in the lint, not emergency

melvin-bot · 2025-02-17T08:59:53Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2025-02-18T06:30:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-19T03:19:58Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.0-2 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

jayeshmangwani · 2025-04-21T10:08:04Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

                        switchAccessibilityLabel={translate('workspace.qbo.defaultVendorDescription')}
                        wrapperStyle={[styles.ph5, styles.mb3, styles.mt1]}
                        isActive={!!qboConfig?.autoCreateVendor}
-                        shouldPlaceSubtitleBelowSwitch


Looks like shouldPlaceSubtitleBelowSwitch prop was removed during a bad merge, and that caused the issue #59479

sumo-slonik added 2 commits January 17, 2025 16:11

Added working animation to switch in accounting page with configurabl…

50a5f90

…e first animation.

describe types

e83ddb6

sumo-slonik changed the title ~~Added working animation to switch in accounting page with configurabl…~~ [DRAFT] Added working animation to switch in accounting page with configurabl… Jan 17, 2025

add hook to ToggleRow to

07bdd50

blazejkustra suggested changes Jan 17, 2025

View reviewed changes

sumo-slonik changed the title ~~[DRAFT] Added working animation to switch in accounting page with configurabl…~~ [DRAFT] Added working animation to switch in accounting page Jan 21, 2025

sumo-slonik mentioned this pull request Jan 21, 2025

Add animation for switch children #55478

Merged

50 tasks

sumo-slonik added 5 commits January 21, 2025 12:58

Merge branch 'feature/kuba_nowakowski/add_animation_for_switch_childr…

abe3617

…eans' into feature/kuba_nowakowski/add_switch_animations_to_acounting

changes after review, fix imports

b529661

Merge branch 'main' into feature/kuba_nowakowski/add_switch_animation…

688df4f

…s_to_acounting

Merge branch 'main' into feature/kuba_nowakowski/add_switch_animation…

ab7e7f2

…s_to_acounting

Merge branch 'main' into feature/kuba_nowakowski/add_switch_animation…

6519991

…s_to_acounting # Conflicts: # src/pages/workspace/accounting/netsuite/advanced/NetSuiteAdvancedPage.tsx

stephanieelliott mentioned this pull request Jan 29, 2025

[Due for payment 2025-02-26] [HOLD for payment 2025-02-07] [$250] Implement animation to the switch expandable sections #53759

Closed

Merge branch 'main' into feature/kuba_nowakowski/add_switch_animation…

8711e60

…s_to_acounting

sumo-slonik marked this pull request as ready for review January 31, 2025 13:21

sumo-slonik requested a review from a team as a code owner January 31, 2025 13:21

melvin-bot bot requested review from dubielzyk-expensify and thesahindia January 31, 2025 13:21

melvin-bot bot removed the request for review from a team January 31, 2025 13:21

sumo-slonik changed the title ~~[DRAFT] Added working animation to switch in accounting page~~ Added working animation to switch in accounting page Jan 31, 2025

blazejkustra approved these changes Jan 31, 2025

View reviewed changes

fix hover files

5d8f8f2

fix eslint

562ee23

fixed custom id

a0a2843

Merge branch 'main' into feature/kuba_nowakowski/add_switch_animation…

dc6671f

…s_to_acounting # Conflicts: # src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

thesahindia approved these changes Feb 17, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny February 17, 2025 08:46

mountiny assigned sumo-slonik Feb 17, 2025

mountiny approved these changes Feb 17, 2025

View reviewed changes

mountiny merged commit c52ed2b into Expensify:main Feb 17, 2025
14 of 16 checks passed

melvin-bot bot added the Emergency label Feb 17, 2025

mountiny removed the Emergency label Feb 17, 2025

github-actions bot mentioned this pull request Feb 18, 2025

Deploy Checklist: New Expensify 2025-02-18 #56992

Closed

27 tasks

jayeshmangwani reviewed Apr 21, 2025

View reviewed changes

jayeshmangwani mentioned this pull request Apr 21, 2025

[$125] - QBO - Hint text is not below the toggle #59479

Closed

8 tasks

Conversation

sumo-slonik commented Jan 17, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Jan 31, 2025

Uh oh!

sumo-slonik commented Jan 31, 2025

Uh oh!

thesahindia commented Jan 31, 2025

Uh oh!

thesahindia commented Feb 1, 2025

Uh oh!

sumo-slonik commented Feb 5, 2025

Uh oh!

dubielzyk-expensify commented Feb 5, 2025

Uh oh!

sumo-slonik commented Feb 6, 2025

Uh oh!

dubielzyk-expensify commented Feb 6, 2025

Uh oh!

thesahindia commented Feb 6, 2025

Uh oh!

sumo-slonik commented Feb 7, 2025

Uh oh!

sumo-slonik commented Feb 7, 2025

Uh oh!

thesahindia commented Feb 11, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia commented Feb 11, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Feb 17, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

jayeshmangwani Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sumo-slonik commented Jan 17, 2025 •

edited by mountiny

Loading