Edge-to-edge Bottom Safe Area Padding: Modals

[chrispader]

Explanation of Change

Based on the Base PR edge-to-edge bottom safe area padding handling.

Adds necessary changes to enable edge-to-edge bottom safe area padding in modals and enables edge-to-edge mode for specific modals to fix current issues with these modals:

Done ✅

• DatePickerModal
• EmojiPicker

TODO 🏗️

• SearchRouterModal
• ThreeDotsMenu
• SearchAutocompleteList
• PopoverMenu
• AccountSwitcher
• ... (in progress)

Fixed Issues

$ #64241
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[shubham1206agra]

@chrispader Have you found workaround for the weird whitebar in Android?

[chrispader]

@chrispader Have you found workaround for the weird whitebar in Android?

yes, you mean in the SearchRouter modal?

[shubham1206agra]

@chrispader This one #57281 (comment)

[chrispader]

@chrispader This one #57281 (comment)

no not yet, i'm continuing working on this now. Would be good to fix this alongside with this PR, because it affects all modals across the app

[chrispader]

@chrispader Have you found workaround for the weird whitebar in Android?

just found and pushed a fix for this issue, so all modals should now have the same navigation bar style

[shubham1206agra]

@chrispader Can you please share the progress here?

[chrispader]

I'll reduce the scope of this PR to get this merged this week! Initially i wanted to handle edge-to-edge bottom safe area padding handling for all modals across the app in this PR, but there are some issues waiting on this one.

[chrispader]

I extracted some of the logic fixing #58955 to #64229, to make this PR leaner and get it merged faster!

cc @shubham1206agra

[shubham1206agra]

@chrispader Can we re-prioritise this PR again?

[chrispader]

I'm mostly OOO in July with 5-10h availability. Will get back to this as soon as possible, hopefully next week!

[chrispader]

@shubham1206agra i'm back on this PR. Hopefully we can merge it this week!

[chrispader]

@shubham1206agra i've extracted the fix for the issue with the translucent navigation bar on Android to #69004.

[chrispader]

Still working on finishing #69430 after it got reverted. Once this is merged, i'll continue here!

[chrispader]

@shubham1206agra I'm getting back to this PR now!

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ConfirmContent.tsx	82.50% <100.00%> (+0.44%)	⬆️
src/components/ConfirmModal.tsx	100.00% <ø> (ø)
src/components/Modal/BaseModal.tsx	86.50% <100.00%> (ø)
src/components/ThreeDotsMenu/index.tsx	91.11% <ø> (ø)
src/styles/utils/generators/ModalStyleUtils.ts	35.87% <100.00%> (+0.49%)	⬆️
src/components/AccountSwitcher.tsx	0.00% <0.00%> (ø)
src/components/Popover/index.tsx	0.00% <0.00%> (ø)
src/components/PopoverMenu.tsx	77.43% <75.00%> (+0.11%)	⬆️
src/components/PopoverWithoutOverlay/index.tsx	0.00% <0.00%> (ø)
... and 217 files with indirect coverage changes

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[chrispader]

@mountiny i'll extract parts of this PR that fix navigation bar translucency and behavior on Android into a separate PR, so we can merge this and get other people to work on migrating all of the modals.

I'll set up a list of what components need to be updated and how to migrate it properly. There are lots of modals, so it might be good to split this up into multiple batches that can be merged independently.

Aside from modals, there are also lots of other types of components, that need to be migrated for better bottom safe area handling, which i will also try to cover in my guide.

[mountiny]

ok that would be great, thank you