feat: Padding in VBA flows by MrMuzyk · Pull Request #58279 · Expensify/App

MrMuzyk · 2025-03-12T11:57:44Z

Explanation of Change

Moved to usage of useStyledSafeAreaInsets() hook

Fixed Issues

$ #58087
PROPOSAL:

Tests

USD flow

create fresh USD workspace
start connecting bank account
go through the whole process
there should be no visible shift (when page isn't scrollable) to position of submit button across all steps

non USD flow

create CAD workspace
start connecting bank account
go through the whole process
there should be no visible shift (when page isn't scrollable) to position of submit button across all steps
Verify that no errors appear in the JS console

Offline tests

QA Steps

USD flow

create fresh USD workspace
start connecting bank account
go through the whole process
there should be no visible shift (when page isn't scrollable) to position of submit button across all steps
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mov

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…87-padding-in-vba

melvin-bot · 2025-03-13T12:24:05Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2025-03-14T14:11:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

// error live mark down library

Android: mWeb Chrome

Screen.Recording.2025-03-16.at.21.50.22.mov

iOS: Native

Screen.Recording.2025-03-16.at.15.46.20.mov

iOS: mWeb Safari

Screen.Recording.2025-03-16.at.21.47.17.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-16.at.21.35.24.mov

MacOS: Desktop

Screen.Recording.2025-03-16.at.21.35.57.mov

Pujan92 · 2025-03-17T09:59:11Z

@MrMuzyk are you getting a compile time error as useStyledSafeAreaInsets hook isn't there in the code?

hungvu193 · 2025-03-17T10:00:30Z

@MrMuzyk are you getting a compile time error as useStyledSafeAreaInsets hook isn't there in the code?

He's working on a fix, useStyledSafeAreaInsets was renamed in another PR.

Pujan92 · 2025-03-17T10:00:54Z

Ah, Ok. Thanks @hungvu193

MrMuzyk · 2025-03-17T10:09:53Z

Fix is merged now. I'm not quite sure how we didn't get any conflicts here

github-actions · 2025-03-17T12:02:28Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-03-17T16:39:06Z

@MrMuzyk QA facing with issue #40770

https://utest-dl.s3-accelerate.amazonaws.com/testRunStepMinAttachmentsResult/52581242/1742225302273%2158279-Android.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20250317T163824Z&X-Amz-SignedHeaders=host&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%2F20250317%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Expires=86400&X-Amz-Signature=6a648b9b03e06c102c5a9a8b3a49fe4312fefc19aa63ddb5dcef61a4618152c1

MrMuzyk · 2025-03-18T07:15:33Z

Hey @izarutskaya, Im looking into it

MrMuzyk · 2025-03-18T07:29:10Z

I did not change this screen in particular, this is a regression from - #57128

This screen like many others is using a FormProvider, which inside has FormWrapper which uses useSafeAreaPaddings that got updated in the PR I've linked above

hungvu193 · 2025-03-18T08:31:02Z

I did not change this screen in particular, this is a regression from - #57128

This screen like many others is using a FormProvider, which inside has FormWrapper which uses useSafeAreaPaddings that got updated in the PR I've linked above

Yes. It's being fixed here:
#58600

github-actions · 2025-03-18T21:29:31Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.14-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

parasharrajat · 2025-08-13T11:38:38Z

src/pages/ReimbursementAccount/NonUSD/Country/subSteps/Confirmation.tsx

+            />
+            <Text style={[styles.ph5, styles.mb3, styles.mutedTextLabel]}>
+                {`${translate('countryStep.yourBusiness')} ${translate('countryStep.youCanChange')}`}{' '}
+                <TextLink


There was rendering issue with this link which caused #67378

feat: Padding in VBA flows

edaf212

MrMuzyk changed the title ~~feat: 58087 Padding in VBA flows~~ feat: Padding in VBA flows Mar 12, 2025

MrMuzyk added 4 commits March 12, 2025 15:49

fix: prettier

2589a3b

fix: requestor step paddings

84088a7

fix: lint

9b0a59d

Merge branch 'main' of https://github.com/Expensify/App into feat/580…

e8dc1e9

…87-padding-in-vba

MrMuzyk marked this pull request as ready for review March 13, 2025 12:23

MrMuzyk requested a review from a team as a code owner March 13, 2025 12:24

melvin-bot bot requested review from hungvu193 and removed request for a team March 13, 2025 12:24

hungvu193 approved these changes Mar 16, 2025

View reviewed changes

melvin-bot bot requested a review from madmax330 March 16, 2025 07:09

madmax330 approved these changes Mar 17, 2025

View reviewed changes

madmax330 merged commit 40dcff2 into Expensify:main Mar 17, 2025
17 checks passed

This was referenced Mar 17, 2025

Investigate workflow job failing on main: lint / ESLint check #58545

Closed

Investigate workflow job failing on main: typecheck / typecheck #58546

Closed

mkzie2 mentioned this pull request Mar 17, 2025

Improve eReceipt visually in New Dot #55803

Merged

50 tasks

github-actions bot mentioned this pull request Mar 17, 2025

Deploy Checklist: New Expensify 2025-03-17 #58550

Closed

72 tasks

parasharrajat reviewed Aug 13, 2025

View reviewed changes

Conversation

MrMuzyk commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2025

Uh oh!

hungvu193 commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Pujan92 commented Mar 17, 2025

Uh oh!

hungvu193 commented Mar 17, 2025

Uh oh!

Pujan92 commented Mar 17, 2025

Uh oh!

MrMuzyk commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

izarutskaya commented Mar 17, 2025

Uh oh!

MrMuzyk commented Mar 18, 2025

Uh oh!

MrMuzyk commented Mar 18, 2025

Uh oh!

hungvu193 commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

parasharrajat Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MrMuzyk commented Mar 12, 2025 •

edited

Loading

hungvu193 commented Mar 14, 2025 •

edited

Loading