Change Invite whisper actions

[parasharrajat]

Explanation of Change

Fixed Issues

#58811
$ #60690
$ #60689
PROPOSAL: #60690 (comment)

Tests

1. Open a workspace expense chat.
2. Mention a user which is not a member of chat and workspace.
3. Verify a whisper message should pop up that asks:

"Invite <@user> to this workspace so they can submit expenses?"
[Invite to submit expenses]
[Invite to chat only]
[Do Nothing]

4. If they choose [Invite to submit expenses]:

   • verify Whisper is removed.
   • User is added to the workspace as member.
   • The system confirms the invite via a new whisper:

      “Great, you chose to invite them to the workspace! I've invited them and they'll 
       submit expenses in [invitee's workspace chat name](link new user’s workspace chat). 
       If you need to make them an admin, you can do that in the [workspace member 
       settings] (link to workspace member settings).”
       [Got it]
   

   • Clicking/tapping [Got it] will remove the confirmation whisper.

5. If they choose [Invite to chat only]

   • The whisper is dismissed, and the system posts a message from the inviter like it does today: “invited @user”

6. If no selection is made, the mentioned user isn’t invited to the workspace chat and the whisper remains.

7. If Do Nothing is selected, whisper hides and nothing happens.

• Verify that no errors appear in the JS console

Offline tests

You can't take actions on whispers while offline.

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[carlosmiceli]

One small change: could we use singular or plural consistently? Either expense or expenses:

INVITE_TO_SUBMIT_EXPENSES: 'inviteToSubmitExpense'

[parasharrajat]

Singular is fine.

[carlosmiceli]

Singular is fine.

Sounds good, let's change it to INVITE_TO_SUBMIT_EXPENSE then in both FE and BE.

[parasharrajat]

@carlosmiceli I have incorporated changes as you suggested. I noticed when I add the member to workspace on Invite to Submit Expense action, it is added to that workspace but not that workspace expense chat. Is this the expected behaviour?

[carlosmiceli]

Are you asking about the new resolution that invites the mentioned user to the workspace? If so, that's the expected behaviour, we want Invite to Chat to invite the user to the chat where it's being tagged, and Invite to Submit Expense to invite the user to the workspace and create a policy expense chat for that user. If we're calling AddMembersToWorkspace with Invite to Submit Expense, then we should see a new member in the workspace panel and a new expense chat created for the invited user.

[parasharrajat]

Ok, thanks for the explanation. It's ready. You can test this whenever the backend changes are done.

[melvin-bot]

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

@rushatgabhane We are waiting on backend changes to test this.

[rushatgabhane]

okayy thank you for letting me know

[carlosmiceli]

Tested it locally, seems to work great, @rushatgabhane feel free to review :)

[parasharrajat]

@carlosmiceli We can't test this until your changes are deployed to staging server.

[carlosmiceli]

Oh, I meant to review, but will let you know once it's ready. I'm troubleshooting still because I realized that the text in the whispers is not coming through yet, so will report back.

[parasharrajat]

@carlosmiceli Any update on backend PR?

[rushatgabhane]

let's retest

@parasharrajat please merge main

[parasharrajat]

Thanks for waiting. ON it.

[parasharrajat]

For this bug #61289 (comment)

Should I just hide the invite to submit expenses action if the user is not a admin if the policy of that workspace chat? @carlosmiceli

If you think that it should be admin only whisper then backend needs to stop sending this whisper for non-admin users.

[parasharrajat]

I just noticed that a non-admin user can invite a user to the workspace via this prompt when we select Invite to submit expenses, which is the opposite of ⬆️ issue. But it is wrong. We should not allow this from a non-admin user.

The addMemberToWorksapce API does not prevent this.
I should hide that options for non-admin users.

But I need confirmation. @carlosmiceli

[carlosmiceli]

Should I just hide the invite to submit expenses action if the user is not a admin if the policy of that workspace chat?

Yes, this should be only for admins. Would this solve the issue completely or do we also need the BE change?

[carlosmiceli]

@parasharrajat to clarify, we should keep the existing behavior as it is right now for non-admin users. Admins should get both options of inviting to workspace and also just to chat.

[parasharrajat]

Yes, this should be only for admins. Would this solve the issue completely or do we also need the BE change?

It should as we won't show the button at all that invites to workspace. Only admins will see that.

#61289 (comment)

Yes

[parasharrajat]

Made that change.

[parasharrajat]

@rushatgabhane Ready for testing.

[carlosmiceli]

@rushatgabhane think we can get a final review and test today/tomorrow so we can have this live before EOW?

[rushatgabhane]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

WhatsApp.Video.2025-07-09.at.01.53.08.mp4

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-07-09.at.01.55.28.mov

iOS: mWeb Safari

Screen.Recording.2025-07-09.at.01.59.27.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-09.at.02.01.42.mov

MacOS: Desktop

[rushatgabhane]

LGTM!!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[carlosmiceli]

@parasharrajat can we get a new PR up to fix the reason we reverted this one?

[parasharrajat]

Yes. I will do that asap

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[parasharrajat]

I have created a new PR here #66049