Change Invite whisper actions by parasharrajat · Pull Request #66049 · Expensify/App

parasharrajat · 2025-07-14T12:28:34Z

Explanation of Change

Fixed Issues

#58811
$ #60690
$ #60689
PROPOSAL: #60690 (comment)

Tests

Open a workspace expense chat.
Mention a user which is not a member of chat and workspace.
Verify a whisper message should pop up that asks:

"Invite <@user> to this workspace so they can submit expenses?"
[Invite to submit expenses]
[Invite to chat only]
[Do Nothing]

If they choose [Invite to submit expenses]:

verify Whisper is removed.
User is added to the workspace as member.
The system confirms the invite via a new whisper:

   “Great, you chose to invite them to the workspace! I've invited them and they'll 
    submit expenses in [invitee's workspace chat name](link new user’s workspace chat). 
    If you need to make them an admin, you can do that in the [workspace member 
    settings] (link to workspace member settings).”
    [Got it]

Clicking/tapping [Got it] will remove the confirmation whisper.

If they choose [Invite to chat only]
- The whisper is dismissed, and the system posts a message from the inviter like it does today: “invited @user”
If no selection is made, the mentioned user isn’t invited to the workspace chat and the whisper remains.
If Do Nothing is selected, whisper hides and nothing happens.

Verify that no errors appear in the JS console

Offline tests

You can't take actions on whispers while offline.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-14T12:28:40Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-07-14T12:28:57Z

cc: @rushatgabhane.

rushatgabhane · 2025-07-17T02:49:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-07-28.at.14.34.14.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-07-28.at.14.33.28.mov

MacOS: Desktop

Screen.Recording.2025-07-28.at.14.38.20.mov

rushatgabhane · 2025-07-17T10:49:24Z

Also testing #65812

rushatgabhane · 2025-07-17T11:00:35Z

@parasharrajat should the whisper show in threads in a personal DM

go to personal DM
go to a chat thread
mention a user not in chat

Screen.Recording.2025-07-17.at.13.59.05.mov

rushatgabhane · 2025-07-17T11:05:52Z

same with IOU

parasharrajat · 2025-07-17T11:07:26Z

This is where I am unsure of where this prompt is actually shown. @carlosmiceli, can you please check the backend and let us know on which type of chats/reports show this prompt?

rushatgabhane · 2025-07-17T11:35:50Z

rest looks good btw, @carlosmiceli let us know if this is a blocking issue

garrettmknight · 2025-07-22T14:52:16Z

I don't think users are able to add any other members, so neither!

carlosmiceli · 2025-07-23T01:29:47Z

@garrettmknight sorry, to confirm, you're saying that the whisper with the invite option that @rushatgabhane is showing in personal DMs and IOUs shouldn't be displayed in either, right?

parasharrajat · 2025-07-23T08:10:28Z

Moved the discussion to Slack https://expensify.slack.com/archives/C08CZDJFJ77/p1753258146051999. This is taking a lot of time to wrap up this issue.

parasharrajat · 2025-07-23T16:23:38Z

#66049 (comment)
#66049 (comment)

These are no blocker for these PR.

…ert-61289-parasharrajat/workspace-chat-invite-whisper

parasharrajat · 2025-07-24T16:22:52Z

Bump @rushatgabhane

carlosmiceli · 2025-07-28T10:48:43Z

@rushatgabhane can we try to review this today/tomorrow so we can finalize this feature? 💪
@parasharrajat there seems to be some spell error btw

rushatgabhane · 2025-07-28T11:39:27Z

LGTM

…ert-61289-parasharrajat/workspace-chat-invite-whisper

OSBotify · 2025-07-28T12:18:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-29T10:03:31Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.87-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ert-61289-parasharrajat/workspace-chat-invite-whisper" This reverts commit 2927406, reversing changes made to b231e15.

github-actions · 2025-07-31T11:52:16Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.87-14 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-31T12:16:56Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-04T19:23:51Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "[CP Staging] Revert "Change Invite whisper actions""

80a91f6

parasharrajat requested a review from a team as a code owner July 14, 2025 12:28

melvin-bot bot requested review from fedirjh and removed request for a team July 14, 2025 12:28

parasharrajat mentioned this pull request Jul 14, 2025

Change Invite whisper actions #61289

Merged

50 tasks

parasharrajat added 3 commits July 14, 2025 18:15

Only show submit expenses button on expenseReports

fac06e5

Fix conditions

17463b6

Remove unused

6209a71

carlosmiceli requested review from carlosmiceli and rushatgabhane and removed request for fedirjh July 14, 2025 14:30

Merge branch 'main' of github.com:Expensify/App into revert-65864-rev…

9ee1460

…ert-61289-parasharrajat/workspace-chat-invite-whisper

rushatgabhane approved these changes Jul 28, 2025

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into revert-65864-rev…

dcafd26

…ert-61289-parasharrajat/workspace-chat-invite-whisper

carlosmiceli approved these changes Jul 28, 2025

View reviewed changes

carlosmiceli merged commit 2927406 into Expensify:main Jul 28, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 29, 2025

Deploy Checklist: New Expensify 2025-07-29 #67304

Closed

jponikarchuk mentioned this pull request Jul 29, 2025

[Due for payment 2025-08-11] Room - When inviting two users to submit expenses, only one is invited and whisper reappears #67353

Closed

8 tasks

chuckdries added a commit that referenced this pull request Jul 29, 2025

Revert "Merge pull request #66049 from parasharrajat/revert-65864-rev…

b6ba6ec

…ert-61289-parasharrajat/workspace-chat-invite-whisper" This reverts commit 2927406, reversing changes made to b231e15.

chuckdries mentioned this pull request Jul 29, 2025

[CP Staging] Revert workspace-chat-invite-whisper #67361

Merged

51 tasks

BlameGPT mentioned this pull request Jul 29, 2025

">" Symbol Replaced with ">" in Chat Messages #67335

Closed

16 tasks

BlameGPT mentioned this pull request Aug 1, 2025

Mention list is placed at the top of the screen - Gap between mention list and compose box #67651

Closed

8 tasks

Conversation

parasharrajat commented Jul 14, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 14, 2025

Uh oh!

parasharrajat commented Jul 14, 2025

Uh oh!

rushatgabhane commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Jul 17, 2025

Uh oh!

rushatgabhane commented Jul 17, 2025

Uh oh!

rushatgabhane commented Jul 17, 2025

Uh oh!

parasharrajat commented Jul 17, 2025

Uh oh!

rushatgabhane commented Jul 17, 2025

Uh oh!

garrettmknight commented Jul 22, 2025

Uh oh!

carlosmiceli commented Jul 23, 2025

Uh oh!

parasharrajat commented Jul 23, 2025

Uh oh!

parasharrajat commented Jul 23, 2025

Uh oh!

parasharrajat commented Jul 24, 2025

Uh oh!

carlosmiceli commented Jul 28, 2025

Uh oh!

rushatgabhane commented Jul 28, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rushatgabhane commented Jul 17, 2025 •

edited

Loading