Unify hybrid & standalone deeplink navigation by war-in · Pull Request #64056 · Expensify/App

war-in · 2025-06-12T10:38:28Z

Explanation of Change

When implementing HybridAppHandler we extracted HybridApp deeplink navigation to a separate function in setup/hybridApp. It turns out that we already have a deeplink handling function in the standalone app (openReportFromDeepLink) and can use it for hybrid app too.

Fixed Issues

$ #62857
PROPOSAL:

Tests

HybridApp:
Check if clicking on a ND shortcut or deeplink redirects to the correct place:

shortcuts:
1. Have app in a ND experience
2. Click on a shortcut (long press on an app icon and select Manually create or any other)
3. Verify that you're being redirected to the correct place
deeplinks:
1. Click on a ND deeplink (e.g. https://new.expensify.com/settings or any other)
2. Verify that you're being redirected to the correct place

All platforms:

Navigate to https://staging.new.expensify.com/a/hello
while app is open
Verify that Not found page is opened once

Offline tests

QA Steps

Check if clicking on a ND shortcut or deeplink redirects to the correct place:

shortcuts:
1. Have app in a ND experience
2. Click on a shortcut (long press on an app icon and select Manually create or any other)
3. Verify that you're being redirected to the correct place
deeplinks:
1. Click on a ND deeplink (e.g. https://new.expensify.com/settings or any other)
2. Verify that you're being redirected to the correct place

PR Author Checklist

Screenshots/Videos

Android: Native

android.-.native.mp4

Android: mWeb Chrome

android.-.web.mp4

iOS: Native

ios.-.native.mov

iOS: mWeb Safari

ios.-.web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

dangrous

Generally this makes sense to me! I have one question, and then I think we can go ahead and grab a C+ for testing!

src/libs/actions/Report.ts

melvin-bot · 2025-06-25T08:13:56Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-06-26T18:51:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-07-01.at.5.59.01.PM.mov

iOS: HybridApp

Screen.Recording.2025-07-01.at.5.26.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-07-01.at.5.50.35.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-01.at.4.05.01.PM.mov

MacOS: Desktop

Screen.Recording.2025-07-01.at.4.38.18.PM.mov

allgandalf · 2025-06-26T19:30:33Z

@war-in I think we need to test on adhoc, I'll ask someone to trigger the built

allgandalf · 2025-06-26T19:30:45Z

Also can you please update platform recordings ?

github-actions · 2025-06-26T20:41:38Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

allgandalf · 2025-06-27T04:25:31Z

@war-in can you merge latest main?

war-in · 2025-06-27T07:54:08Z

@allgandalf main merged! I'll try to post the videos today

war-in · 2025-06-27T15:46:35Z

@allgandalf videos updated!

github-actions · 2025-06-27T17:23:30Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-06-27T18:03:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64056.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/64056/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/64056/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/64056/NewExpensify.dmg	https://64056.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2025-06-30T16:40:03Z

@allgandalf AdHoc builds generated and ready for your testing here

Julesssss

This is working nicely for app actions. But I noticed that the second action doesn't work if you remain on the expense/distance/scan page after the first link, and then you attempt a second action. This is blocking bigger HybridApp changes with tight deadlines, so I'm happy to create an issue for that separately though.

@war-in as we've seen before I don't believe we can verify the deep links until we're on the prod release environment -- as we did with previous testing. Let me know if we managed to get around that issue though

allgandalf · 2025-06-30T20:08:45Z

@allgandalf AdHoc builds generated and ready for your testing here

Testing the adhocs !

mjasikowski

LGTM!

war-in · 2025-07-01T09:38:54Z

@war-in as we've seen before I don't believe we can verify the deep links until we're on the prod release environment -- as we did with previous testing. Let me know if we managed to get around that issue though

@Julesssss I believe we can verify android deeplins by enabling them in the phone settings
Settings -> Apps -> Expensify Adhoc -> default -> enable all links

OSBotify · 2025-07-01T15:07:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2025-07-01T17:11:58Z

Created follow-up issue for the '2nd use fails while remaining on original flow' bug here.

github-actions · 2025-07-02T00:02:56Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.74-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…nify-hybrid-and-standalone-deeplinks" This reverts commit 5a66345, reversing changes made to a8246a8.

github-actions · 2025-07-03T19:43:10Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

QichenZhu · 2025-07-18T14:00:36Z

src/setup/hybridApp/index.native.ts

-        }
-        Navigation.navigate(parsedUrl);
+        const parsedUrl = Navigation.parseHybridAppUrl(state.url as Route);
+        openReportFromDeepLink(parsedUrl);


This opens the URL after onboarding. The logic itself wasn't wrong, but it conflicted with the test drive modal, which also opens after onboarding. (See issue #65508)

App/src/libs/actions/Report.ts

Line 3453 in 139b41c

// We need skip deeplinking if the user hasn't completed the guided setup flow.

Fixed in PRs https://github.com/Expensify/Mobile-Expensify/pull/13613 and #65615.

@QichenZhu thanks for an update! I agree it wasn't perfect and that's why we created another PR to improve it. It was merged yesterday

war-in added 4 commits June 12, 2025 12:36

unify hybrid & standalone deeplinks

6cbb3d2

Merge branch 'main' into war-in/unify-hybrid-and-standalone-deeplinks

c432ca9

Merge branch 'main' into war-in/unify-hybrid-and-standalone-deeplinks

d54130c

fix prettier

888aec3

dangrous self-requested a review June 23, 2025 16:46

dangrous reviewed Jun 23, 2025

View reviewed changes

src/libs/actions/Report.ts Show resolved Hide resolved

Merge branch 'main' into war-in/unify-hybrid-and-standalone-deeplinks

85c74a7

war-in marked this pull request as ready for review June 25, 2025 08:13

war-in requested a review from a team as a code owner June 25, 2025 08:13

melvin-bot bot requested a review from allgandalf June 25, 2025 08:13

melvin-bot bot removed the request for review from a team June 25, 2025 08:13

allgandalf mentioned this pull request Jun 26, 2025

[Due for payment 2025-07-10] [Due for payment 2025-06-18] [Due for payment 2025-06-09] [$250] Improve the initialProps implementation #62857

Closed

This comment has been minimized.

Sign in to view

Merge branch 'main' into war-in/unify-hybrid-and-standalone-deeplinks

a900bcf

mountiny assigned war-in Jun 30, 2025

mountiny requested a review from mjasikowski June 30, 2025 07:44

Julesssss self-requested a review June 30, 2025 16:40

Julesssss reviewed Jun 30, 2025

View reviewed changes

Julesssss mentioned this pull request Jun 30, 2025

[Tracking] NewDot SignIn page on HybridApp follow up improvements #64348

Closed

Julesssss mentioned this pull request Jun 30, 2025

[$250] [HybridApp] Improvement to HybridApp TTI / NewDot authentication page #49844

Closed

mjasikowski approved these changes Jul 1, 2025

View reviewed changes

allgandalf approved these changes Jul 1, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss July 1, 2025 12:52

Julesssss approved these changes Jul 1, 2025

View reviewed changes

Julesssss merged commit 5a66345 into Expensify:main Jul 1, 2025
21 of 23 checks passed

Julesssss mentioned this pull request Jul 1, 2025

[HOLD 65506] iOS/Android only - App shortcut not working in on 2nd use #65276

Closed

Julesssss mentioned this pull request Jul 1, 2025

Bring back new sign-in page #64786

Merged

50 tasks

github-actions bot mentioned this pull request Jul 1, 2025

Deploy Checklist: New Expensify 2025-07-01 #65287

Closed

57 tasks

This was referenced Jul 2, 2025

Expense - Not here page opens when launching app via app shortcut #65295

Closed

Deep link - Concierge opens when opening public room link, user is signed out #65297

Closed

jasperhuangg added a commit that referenced this pull request Jul 2, 2025

Revert "Merge pull request #64056 from software-mansion-labs/war-in/u…

a902e62

…nify-hybrid-and-standalone-deeplinks" This reverts commit 5a66345, reversing changes made to a8246a8.

bernhardoj mentioned this pull request Jul 17, 2025

[$250] Duplicate tool tip displayed on page refresh #66525

Closed

16 tasks

QichenZhu reviewed Jul 18, 2025

View reviewed changes

jponikarchuk mentioned this pull request Sep 8, 2025

[$250] Android - App shortcut - "Log distance" option is missing when app is fresh installed #70073

Closed

8 tasks

mitarachim mentioned this pull request Oct 1, 2025

[PAY 16TH OCT][$250] App shortcut - Create manual expense flow opens when launching app via Log distance shortcut #71672

Closed

8 tasks

Conversation

war-in commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Jun 25, 2025

Uh oh!

allgandalf commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Jun 26, 2025

Uh oh!

allgandalf commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

This comment has been minimized.

allgandalf commented Jun 27, 2025

Uh oh!

war-in commented Jun 27, 2025

Uh oh!

war-in commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Julesssss commented Jun 30, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jun 30, 2025

Uh oh!

mjasikowski left a comment

Choose a reason for hiding this comment

Uh oh!

war-in commented Jul 1, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 1, 2025

Uh oh!

Julesssss commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

QichenZhu Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

war-in Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

war-in commented Jun 12, 2025 •

edited

Loading

allgandalf commented Jun 26, 2025 •

edited

Loading

allgandalf commented Jun 26, 2025 •

edited

Loading