LHN-LHN doesn't show the message sent or the system message by thelullabyy · Pull Request #64161 · Expensify/App

thelullabyy · 2025-06-13T10:18:39Z

Explanation of Change

Fixed Issues

$#62991
PROPOSAL:#62991 (comment)

Tests

Create a workspace
Invite a member
Tap Reports - toggle on Prevent members from changing custom report names
In mweb, login as member invited in step 3
Open employee workspace chat
Create a manual expense without category
Note LHN
Send a message to the expense
Verify LHN shows the message

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a workspace
Invite a member
Tap Reports - toggle on Prevent members from changing custom report names
In mweb, login as member invited in step 3
Open employee workspace chat
Create a manual expense without category
Note LHN
Send a message to the expense
Verify LHN shows the message

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_safari.mov

MacOS: Chrome / Safari

chorme.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-06-13T10:27:01Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu

Could you add unit tests as you proposed? These changes don't seem covered by existing tests.

thelullabyy · 2025-06-16T02:23:10Z

Okay, i will add it today

thelullabyy · 2025-06-16T08:30:13Z

@QichenZhu Test is added

QichenZhu · 2025-06-16T10:19:53Z

src/libs/OptionsListUtils.ts

    }

+    if (reportID) {
+        const chatReport = getReportOrDraftReport(report.chatReportID);


I've heard getReportOrDraftReport() will be removed. Please refer to #63731 (comment).

@QichenZhu updated

QichenZhu · 2025-06-17T11:45:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
Found two errors not caused by this PR, will fix or report them later.
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: HybridApp

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

QichenZhu · 2025-06-17T13:04:29Z

src/libs/OptionsListUtils.ts


+    if (reportID) {
+        const chatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`];
+        // If the expense report is the one expense report, get the last message text from the last report action


I don't get this comment. The previous version is clearer if there's no better option.

QichenZhu · 2025-06-17T13:11:06Z

Send a message

Verify LHN show message is sent

Suggest change:

Send a message to the expense
Verify LHN shows the message

thelullabyy · 2025-06-18T02:06:00Z

@QichenZhu Updated

QichenZhu · 2025-06-18T04:23:17Z

src/libs/OptionsListUtils.ts


+    if (reportID) {
+        const chatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`];
+        // If the report is combined report, get the last message text from the last report action


Suggested change

// If the report is combined report, get the last message text from the last report action

// If the report is a one-transaction report, get the last message text from combined report actions so the LHN can display modifications to the transaction thread or the report itself

@QichenZhu Resolved

github-actions · 2025-06-20T13:16:03Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.70-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-24T18:50:09Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:01:50Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T19:22:51Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T20:38:12Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-24T21:18:27Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: LHN not show message sent or system message

3d6b78c

thelullabyy marked this pull request as ready for review June 13, 2025 10:26

thelullabyy requested a review from a team as a code owner June 13, 2025 10:26

melvin-bot bot requested review from QichenZhu and removed request for a team June 13, 2025 10:26

add comment

31469aa

QichenZhu suggested changes Jun 13, 2025

View reviewed changes

add unit test

f78bc2c

QichenZhu reviewed Jun 16, 2025

View reviewed changes

replace deprecated function getReportOrDraftReport

59f771d

QichenZhu reviewed Jun 17, 2025

View reviewed changes

update comment

f3bee72

QichenZhu reviewed Jun 18, 2025

View reviewed changes

update comment

5236a8c

QichenZhu approved these changes Jun 19, 2025

View reviewed changes

melvin-bot bot requested a review from deetergp June 19, 2025 13:28

deetergp approved these changes Jun 19, 2025

View reviewed changes

deetergp merged commit b183a43 into Expensify:main Jun 19, 2025
18 of 19 checks passed

github-actions bot mentioned this pull request Jun 20, 2025

Deploy Checklist: New Expensify 2025-06-20 #64643

Closed

53 tasks

This was referenced Jun 20, 2025

Expense- LHN preview shows "sent x elsewhere" instead of "paid elsewhere" after paying someone #64650

Closed

Expense - LHN shows "You cancelled the reimbursement" is shown instead of "canceled payment" #64653

Closed

mitarachim mentioned this pull request Jun 20, 2025

Expense - LHN shows incomplete "moved the expense to" when moving expense report offline #64655

Closed

8 tasks

thelullabyy mentioned this pull request Jun 20, 2025

[CP Staging] Revert "LHN-LHN doesn't show the message sent or the system message" #64657

Merged

melvin-bot bot mentioned this pull request Jun 24, 2025

[Due for payment 2025-07-14] [Due for payment 2025-07-01] [$250] LHN-LHN doesn't show the message sent or the system message #62991

Closed

8 tasks

Expensify deleted a comment from github-actions bot Jun 27, 2025

	// If the report is combined report, get the last message text from the last report action
	// If the report is a one-transaction report, get the last message text from combined report actions so the LHN can display modifications to the transaction thread or the report itself

Conversation

thelullabyy commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 13, 2025

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 16, 2025

Uh oh!

thelullabyy commented Jun 16, 2025

Uh oh!

QichenZhu Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Jun 17, 2025

Uh oh!

thelullabyy commented Jun 18, 2025

Uh oh!

QichenZhu Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thelullabyy commented Jun 13, 2025 •

edited

Loading

QichenZhu commented Jun 17, 2025 •

edited

Loading