Skip to content

[CP Staging] Revert "LHN-LHN doesn't show the message sent or the system message"#64657

Merged
NikkiWines merged 1 commit intoExpensify:mainfrom
thelullabyy:revert-64161-fix/62991-LHN-not-show-message-sent
Jun 20, 2025
Merged

[CP Staging] Revert "LHN-LHN doesn't show the message sent or the system message"#64657
NikkiWines merged 1 commit intoExpensify:mainfrom
thelullabyy:revert-64161-fix/62991-LHN-not-show-message-sent

Conversation

@thelullabyy
Copy link
Contributor

@thelullabyy thelullabyy commented Jun 20, 2025 •
edited
Loading

@thelullabyy thelullabyy marked this pull request as ready for review June 20, 2025 15:07
@thelullabyy thelullabyy requested a review from a team as a code owner June 20, 2025 15:07
@melvin-bot melvin-bot bot requested review from MariaHCD and removed request for a team June 20, 2025 15:07
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2025

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@thelullabyy thelullabyy mentioned this pull request Jun 20, 2025
Closed
16 tasks
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2025

🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #64663.

@melvin-bot melvin-bot bot mentioned this pull request Jun 20, 2025
Closed
NikkiWines
NikkiWines approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QichenZhu QichenZhu mentioned this pull request Jun 20, 2025
Closed
8 tasks
@NikkiWines NikkiWines changed the title Revert "LHN-LHN doesn't show the message sent or the system message" [CP Staging] Revert "LHN-LHN doesn't show the message sent or the system message" Jun 20, 2025
@NikkiWines NikkiWines merged commit 69dcdff into Expensify:main Jun 20, 2025
15 of 21 checks passed
@melvin-bot melvin-bot bot added the Emergency label Jun 20, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2025

@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 20, 2025

Straight revert to fix blockers

@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 20, 2025

CP requested

OSBotify pushed a commit that referenced this pull request Jun 20, 2025
@NikkiWines @OSBotify
Merge pull request #64657 from thelullabyy/revert-64161-fix/62991-LHN…
f36c63c 
…-not-show-message-sent

[CP Staging] Revert "LHN-LHN doesn't show the message sent or the system message"

(cherry picked from commit 69dcdff)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 20, 2025
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Closed
53 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 20, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 20, 2025

CP run was here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.1.70-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@tgolen tgolen mentioned this pull request Jun 20, 2025
Closed
16 tasks
@MariaHCD MariaHCD mentioned this pull request Jun 21, 2025
Closed
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@MariaHCD MariaHCD Awaiting requested review from MariaHCD

+1 more reviewer

@QichenZhu QichenZhu QichenZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thelullabyy @NikkiWines @OSBotify @QichenZhu