Merged
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Member
|
@luacmartins I was about to complete the checklist 😄 |
Member
|
No bugs. All resolved. |
OSBotify
pushed a commit
that referenced
this pull request
Jun 17, 2025
Surface more locales (cherry picked from commit a40384b) (cherry-picked to staging by roryabraham)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
60 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.1.68-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
8 tasks
8 tasks
8 tasks
8 tasks
16 tasks
8 tasks
16 tasks
8 tasks
16 tasks
8 tasks
16 tasks
This was referenced Jun 18, 2025
8 tasks
16 tasks
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.68-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Surfacing more locales in the locale picker (behind a beta, for now).
Fixed Issues
$ #62804
Tests
Account Settings->Preferences->LanguageSwitch to each language. For each language:
:smileto bring up the emoji picker. For English and Spanish, verify that emojis are found in the current language. For all other languages, verify that English emoji keywords still work.Offline tests
Account Settings->Preferences->Language.QA Steps
Account Settings->Preferences->Languageand verify that you see English and Spanish only.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov