Merge expenses phase 1

[hoangzinh]

Explanation of Change

Design doc: https://docs.google.com/document/d/1RXJyOVsX2AgKWNViLSxNm3PH2bSnJCuo6K_jcOxUGuo/edit?pli=1&tab=t.0#heading=h.4ipw72mqhwe3

Fixed Issues

$ #65574
PROPOSAL:

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Case 1: Merge cash expense and IOU

1. Sign in to a new account
2. Create one cash expense via scanning a receipt
3. Wait until scanning is completed
4. Go to cash expense -> Tap More button
5. Verify App shows "Merge" option
6. Tap "Merge"
7. Verify App shows empty screen "You don’t have any expenses that can be merged..."
8. Scan another receipt as an IOU for the same money report
9. Open the first expense > More > Merge
10. Verify App now shows "Select an eligible expense to merge…"
11. Verify the IOU from your self DM is listed
12. Select the IOU and tap "Continue"
13. Verify both receipts are shown to select from
14. Select a receipt to keep and tap "Continue"
15. Verify all details that differ between the two expenses are shown in a list
16. Select all details but one to keep and tap "Continue"
17. Verify that the selected details show in the confirmation page
18. Tap "Merge expenses" button
19. Verify the expense created matches all details selected

Case 2: Merge scan expense with manual expense

1. Sign in to a new account
2. Create one scan expense and one manual expense
3. Go to scan expense transaction thread
4. Tap "More" -> "Merge" option
5. Select the manual expense to merge
6. Verify it doesn't display the review receipt page
7. Select details you want to keep
8. Tap Continue
9. Verify that the Confirmation page, it displays the receipt of scan expense

Case 3: Merge expense from Self DM

1. Sign in to any account
2. Go to Self DM
3. Create an expense
4. Tap on that expense
5. Tap on "More" button
6. Verify App shows "Merge" option
7. Continue go through merging expenses, verify it works normally

Case 4: Merge open expense from a report that contains multiple expenses

1. Sign in to any account
2. Go to any workspace chat
3. Create 2 expenses
4. Go to expense report
5. Tap on "More" button
6. Verify that App doesn't show "Merge" option in dropdown list
7. Select an expense
8. Tap on "1 selected" button
9. Verify that App now shows "Merge" option

Case 5: Merge processing expense

1. Sign in to any account
2. Go to any workspace chat
3. Create an expenses
4. Go to expense report
5. Tap on "Submit" button
6. Tap on "More" button
7. Verify that App shows "Merge" option
8. Tap on "Approve" button
9. Tap on "More" button again
10. Verify that App won't show "Merge" option

Case 6: Merge card expense and cash expense
Pre-requisite: Connect a third-party card to your submitter account

1. Sign in to account above
2. Submit a cash expense in your Self DM
3. Scan a receipt in the expense chat
4. Open a card expense
5. Tap "More" => "Merge" option
6. Verify the cash expense from your Self DM is listed
7. Verify no other card expenses are listed
8. Select the cash expense and tap ‘Continue’
9. Verify the ‘Choose receipt’ screen is skipped since only one of the expenses has a receipt.
10. Select details to keep and tap ‘Continue’
11. Verify that the selected details show in the confirmation page
12. Tap "Merge expenses" button
13. Verify the expense created matches all details selected and that the expense is still a card expense

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1752731949833979
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-25.at.07.25.24.android.mov

Android: mWeb Chrome

Screen.Recording.2025-07-25.at.07.17.17.android.chrome.mov

iOS: Native

Screen.Recording.2025-07-25.at.09.04.21.ios.mp4

iOS: mWeb Safari

Screen.Recording.2025-07-25.at.07.37.34.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-25.at.06.00.48.web.mov

MacOS: Desktop

Screen.Recording.2025-07-25.at.06.24.54.desktop.mov

[Julesssss]

Here's another issue. Can't merge tracked expense with iou receipt expense

[github-actions]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[bernhardoj]

Not all report has policyID, which causes the onyx data can be missing, but canBeMissing is set to false here causing #73418