feat: Followup show link existing account page when attempting to pay by MrMuzyk · Pull Request #69437 · Expensify/App

MrMuzyk · 2025-08-28T10:56:53Z

Explanation of Change

Updated routing in order to show page to link existing bank account in RHP without redirecting user to workflows
Show page to link existing bank account when user tries to pay expense on workspace that doesnt have connected bank account but has existing accounts that could be connected

Fixed Issues

$ #65912
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Be on account that has connected business bank account

Create brand new workspace that has the uses the same currency as business bank account connected to different workspace on this account
Create an expense for new workspace
Try to pay for this expense by clicking on Pay -> Pay with business account
Page showing already existing linked accounts should be displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

MrMuzyk · 2025-08-28T14:17:24Z

ON HOLD until #68365 is merged

…12-followup-link-existing-account-on-paying

melvin-bot · 2025-09-17T13:21:39Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-09-17T13:34:37Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

joekaufmanexpensify · 2025-09-17T15:07:38Z

BUG: We're initially showing wrong linked bank account after selecting one on modal

Steps:

Login to an account with two different business bank accounts.
Create a workspace and submit a report for payment.
Try to pay the report.
Select the second account added (in this case the account x0000).

Expected result:

You immediately see the correct bank account shown in the split pay button.

Actual result:

You initially see the bank account you didn't select listed. We do show the correct bank account when you click away and back though. I could only reproduce this when I had two bank accounts setup.

2025-09-17_10-53-28.mp4

joekaufmanexpensify · 2025-09-17T15:12:25Z

BUG: Incorrectly showing split pay button with partially setup bank account

Steps

Submit a report on a workspace from an account with a business bank account setup.
Tap to pay the report.
Tap the "Add new bank account" button on the connect existing account modal.
Begin setting up the new bank account.
Back out of the setup flow.

Expected result

We don't show the split pay button yet because you don't have a fully setup bank account linked to the workspace.

Actual result

We show the split pay button. Please see the second video below for how this works on staging when setting up a partially setup bank account from the pay button (which is what we want here).

Adhoc

2025-09-17_11-00-38.mp4

Staging

2025-09-17_11-00-11.mp4

joekaufmanexpensify · 2025-09-17T15:17:07Z

BUG: we show connect existing account modal after you begin setting up new account

Steps

Submit a report on a workspace from an account where you have an existing business bank account.
Pay the report.
Select to add a new account from the connect existing account modal.
Begin adding the business bank account.
Back out of the flow.
Tap Pay again.

Expected result

We go directly to the "continue setup" page for the bank account you started setting up, skipping the connect existing account modal. This is how the connect existing account modal works on the workflows page, and it should work the same way in both places.

Actual result

We show the connect existing account modal again, even though you already started the process of setting up a new account.

2025-09-17_11-03-57.mp4

joekaufmanexpensify · 2025-09-17T15:17:37Z

That's all I found during my testing @MrMuzyk, it otherwise worked great!

…se view

…12-followup-link-existing-account-on-paying

MrMuzyk · 2025-09-22T14:08:07Z

@joekaufmanexpensify Ive pushed fixes for 1st and 3rd bug. Discussion regarding 2nd is ongoing as you've seen on slack :) Hopefully tomorrow situation will clear out and we will be able to wrap this up soon

joekaufmanexpensify · 2025-09-22T16:18:38Z

Great! I will retest them 👍

github-actions · 2025-09-22T16:19:26Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-22T16:54:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69437.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69437/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69437/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69437/NewExpensify.dmg	https://69437.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-09-22T17:53:31Z

Retested and confirmed the first and third bugs are fixed. Just the second left 👍

dominictb · 2025-09-23T16:04:18Z

src/ROUTES.ts

        },
    },
+    BANK_ACCOUNT_CONNECT_EXISTING_BUSINESS_BANK_ACCOUNT: {
+        route: 'bank-account/:policyID/connect-existing-business-bank-account',


I think this should follow the BANK_ACCOUNT_ENTER_SIGNER_INFO route convention where policyID is a param instead of a path name.

src/components/SettlementButton/index.tsx

src/components/KYCWall/BaseKYCWall.tsx

github-actions · 2025-09-26T13:34:01Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-26T14:19:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69437.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69437/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69437/NewExpensify.dmg	https://69437.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-09-26T20:34:36Z

Retested and looking good. Asked one question there and then good with me to proceed 👍

dominictb · 2025-09-29T02:17:57Z

src/pages/settings/Wallet/PaymentMethodList.tsx

+
+                if (filterType && account.accountData?.type !== filterType) {
+                    return false;
+                }
+
+                if (filterCurrency && account.bankCurrency !== filterCurrency) {
+                    return false;
+                }
+
+                return true;


Suggested change

if (filterType && account.accountData?.type !== filterType) {

return false;

}

if (filterCurrency && account.bankCurrency !== filterCurrency) {

return false;

}

return true;

return (!!filterType && account.accountData?.type === filterType) || (!!filterCurrency && account.bankCurrency === filterCurrency);

dominictb · 2025-09-29T02:31:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-29.at.10.13.07-compressed.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-09-29.at.22.05.21-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-09-29.at.09.42.19.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-29.at.09.30.28-compressed.mov

MacOS: Desktop

dominictb · 2025-09-29T02:36:37Z

@MrMuzyk Can you merge main because I cannot log in iOS rn?

…12-followup-link-existing-account-on-paying

codecov · 2025-09-29T07:11:27Z

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/KYCWall/BaseKYCWall.tsx	0.00%	10 Missing ⚠️
src/components/SettlementButton/index.tsx	0.00%	10 Missing ⚠️
src/pages/settings/Wallet/PaymentMethodList.tsx	0.00%	4 Missing ⚠️
...rkspace/ConnectExistingBusinessBankAccountPage.tsx	0.00%	2 Missing ⚠️
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	0.00%	2 Missing ⚠️
src/ROUTES.ts	0.00%	1 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

MrMuzyk · 2025-09-29T08:09:44Z

@dominictb Done

dominictb

srikarparsi

code looks good to me :)

OSBotify · 2025-09-29T19:33:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-29T20:37:48Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.20-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-09-30T22:20:52Z

Failing in Web, mWeb, Android and iOS #71602

Julesssss · 2025-09-30T22:23:38Z

@srikarparsi FYI this wasn't able to be verified on staging, see this issue

Please can you follow up and make sure this is verified.

OSBotify · 2025-09-30T22:53:36Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.20-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

srikarparsi · 2025-10-06T08:15:55Z

Thanks @Julesssss, we ended up reverting this PR but I added a comment in the follow up PR to make sure this doesn't occur.

feat: Show page to link existing accounts on payment attempt

7959c53

melvin-bot bot assigned MrMuzyk Aug 28, 2025

feat: pt2

08f4d04

srikarparsi self-requested a review September 3, 2025 04:22

MrMuzyk added 3 commits September 17, 2025 14:07

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

fa67b50

…12-followup-link-existing-account-on-paying

fix: TS fix

5a4fc0d

drop Mobile-Expensify changes

5fbf1a7

MrMuzyk marked this pull request as ready for review September 17, 2025 13:21

MrMuzyk requested a review from a team as a code owner September 17, 2025 13:21

melvin-bot bot requested review from dominictb and removed request for a team September 17, 2025 13:21

joekaufmanexpensify self-requested a review September 17, 2025 13:33

This comment has been minimized.

Sign in to view

fix: immediately display correct BA number when connecting from expen…

b9df26c

…se view

joekaufmanexpensify mentioned this pull request Sep 19, 2025

[Due for payment 2026-01-20] [Better BBA] Link existing bank account to workspace for reimbursements #65912

Closed

MrMuzyk added 3 commits September 22, 2025 14:15

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

859a775

…12-followup-link-existing-account-on-paying

fix: skip showing existing account

6c774ae

submodule

ce1a870

dominictb suggested changes Sep 23, 2025

View reviewed changes

fix: CR fixes

72ad384

MrMuzyk requested a review from dominictb September 24, 2025 12:06

fix: filter accounts by currency

4968883

dominictb suggested changes Sep 29, 2025

View reviewed changes

MrMuzyk added 2 commits September 29, 2025 08:54

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

ef1847f

…12-followup-link-existing-account-on-paying

fix: simplify condition

0d7aa98

dominictb approved these changes Sep 29, 2025

View reviewed changes

joekaufmanexpensify approved these changes Sep 29, 2025

View reviewed changes

srikarparsi approved these changes Sep 29, 2025

View reviewed changes

srikarparsi merged commit 65c4b29 into Expensify:main Sep 29, 2025
21 checks passed

OSBotify mentioned this pull request Sep 29, 2025

Deploy Checklist: New Expensify 2025-09-29 #71500

Closed

69 tasks

This was referenced Sep 30, 2025

Expense - Personal bank account can be selected when paying workspace expense #71524

Closed

Reports - No connected bank account list when selecting Pay with business account on Reports #71525

Closed

Beamanator mentioned this pull request Sep 30, 2025

[CP Staging] Revert "feat: Followup show link existing account page when attempting to pay" #71588

Merged

jponikarchuk mentioned this pull request Sep 30, 2025

Pay with business bank account - Existing bank account missing in new workspace #71602

Closed

8 tasks

srikarparsi mentioned this pull request Oct 6, 2025

feat: Show page to link existing account when attempting to pay #71659

Merged

54 tasks

Conversation

MrMuzyk commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MrMuzyk commented Aug 28, 2025

Uh oh!

melvin-bot bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

This comment has been minimized.

joekaufmanexpensify commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BUG: We're initially showing wrong linked bank account after selecting one on modal

Steps:

Expected result:

Actual result:

Uh oh!

joekaufmanexpensify commented Sep 17, 2025

BUG: Incorrectly showing split pay button with partially setup bank account

Steps

Expected result

Actual result

Adhoc

Staging

Uh oh!

joekaufmanexpensify commented Sep 17, 2025

BUG: we show connect existing account modal after you begin setting up new account

Steps

Expected result

Actual result

Uh oh!

joekaufmanexpensify commented Sep 17, 2025

Uh oh!

MrMuzyk commented Sep 22, 2025

Uh oh!

joekaufmanexpensify commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

joekaufmanexpensify commented Sep 22, 2025

Uh oh!

dominictb Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

joekaufmanexpensify commented Sep 26, 2025

Uh oh!

dominictb Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Sep 29, 2025

Uh oh!

codecov bot commented Sep 29, 2025

Codecov Report

Uh oh!

MrMuzyk commented Sep 29, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

MrMuzyk commented Aug 28, 2025 •

edited

Loading

joekaufmanexpensify commented Sep 17, 2025 •

edited

Loading

dominictb commented Sep 29, 2025 •

edited

Loading