feat: Show page to link existing account when attempting to pay by MrMuzyk · Pull Request #71659 · Expensify/App

MrMuzyk · 2025-10-01T10:35:39Z

Explanation of Change

Updated routing in order to show page to link existing bank account in RHP without redirecting user to workflows
Show page to link existing bank account when user tries to pay expense on workspace that doesnt have connected bank account but has existing accounts that could be connected

Fixed Issues

$ #65912

PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Scenario A:

Precondition:

User has a workspace connected to business bank account.

Create brand new workspace that has the uses the same currency as business bank account connected to different workspace on this account
Create an expense for new workspace
Try to pay for this expense by clicking on Pay -> Pay with business account
Page showing already existing linked accounts should be displayed

Scenario B:

Precondition:

User has a workspace connected to business bank account.
User has added a personal bank account.

Create a new USD workspace.
Go to workspace chat.
Create an expense in workspace chat.
Click Submit and Approve.
Click Pay button.
Click Pay with business account.
Personal bank account should not appear in the list.

Scenario C:

Sign in to ND with a new account, validate the account
Create a workspace
Submit an expense in the workspace chat and approve it
Click the "Pay" button, then "Mark as paid"
Expense gets marked as paid correctly

Scenario D:

Precondition:

User has a workspace connected to business bank account.

Create a new USD workspace.
Go to workspace chat.
Create an expense in workspace chat.
Click Submit and Approve.
Click Pay button.
Click Pay with business account.
→ Existing connected bank account list opens.
Close the RHP.
Go to Reports > Expenses.
Click Pay button.
Click Pay with business account.
Page showing already existing linked accounts should be displayed

Scenario E:

Create a worskspace
Go to the workspace > Workflows > Add bank account
Complete the flow adding a Wells Fargo bank account
Go to Workspaces. Create a new workspace with USD currency (same currency as the first workspace)
Go to the new workspace chat > Create a manual expense > Submit > Approve > Pay > Pay with business bank account
The bank account added in the first workspace should be displayed as an option to connect existing bank account

Scenario F:

Create a new workspace on an account with an existing bank account.
Submit an expense and try to pay it.
Begin adding a new bank account.
Back out of the flow before completing.
Go to workflows page, notice you see partially setup account linked to the workspace (this is correct)
Go back to report, notice you don't see split pay button (this is correct).
Tap pay.
Tap pay with business account.
You should be prompted to continue with partially setup account, because it's linked to the workspace at this point.

Scenario G:

Login to an account with a partially setup bank account.
Create a new workspace.
Submit an expense and try to pay it.
Select the partially setup account on the connect existing account modal.
We link the partially setup account to the workspace, allowing user to continue setting up the account there. User should remain on the same view though because it is possible to continue setting the account up from the report view.

Scenario H:

Precondition: User has no connected or partially connected GBP accounts

Create a GBP workspace.
Submit a report on it.
Try to pay the report and select business account.
RHP opens and user is asked to connect bank account

Scenario I:

Sign into a new account.
Create a workspace and add a business bank account.
Delete the workspace.
Create a new workspace.
Submit a report and approve it.
Pay the report and select the bank account.
Verify you now see the split pay button with the bank account listed in the main portion of the button.
Go to Workflows and disconnect the bank account.
Go back to the report.
You should no longer see the split pay button or the bank account listed in the pay button because it was removed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…ng to pay" This reverts commit f44b425.

codecov · 2025-10-01T10:47:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/libs/actions/Report.ts	`54.16% <ø> (ø)`
src/libs/actions/Search.ts	`21.77% <100.00%> (ø)`
...ges/ReimbursementAccount/USD/BankInfo/BankInfo.tsx	`0.00% <ø> (ø)`
.../pages/workspace/WorkspaceOverviewCurrencyPage.tsx	`0.00% <ø> (ø)`
...pages/workspace/WorkspaceResetBankAccountModal.tsx	`0.00% <ø> (ø)`
.../workspace/invoices/WorkspaceInvoiceVBASection.tsx	`0.00% <ø> (ø)`
... and 13 more
... and 6 files with indirect coverage changes

…12-reapply-followup

srikarparsi · 2025-10-06T08:15:07Z

Hey @MrMuzyk, just wanted to flag this comment which brought up this issue with the previous PR

MrMuzyk · 2025-10-06T08:33:48Z

@srikarparsi Thanks for letting me know, I haven't seen this one. I'll repro steps as one of the testing scenarios to be sure this won't happen again :)

…12-reapply-followup

melvin-bot · 2025-10-23T12:05:57Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…12-reapply-followup

github-actions · 2025-10-23T13:14:50Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

joekaufmanexpensify · 2025-10-23T15:43:16Z

BUG: Modal does not initially appear when paying from reports page

Steps:

Sign into a new account.
Create a workspace and add a business bank account.
Delete the workspace.
Create a new workspace.
Submit a report and approve it.
Go to Reports page.
Try to pay the report.

Expected result

You are prompted to link the bank account.

Actual result

You see option to add a new account. But if you open the report and try there, it works. And if you then go back to reports page it works then. It's only on the first attempt it doesn't work.

2025-10-23_11-41-10.mp4

joekaufmanexpensify · 2025-10-23T15:48:14Z

BUG: not updating pay button if you disconnect bank account

Steps:

Sign into a new account.
Create a workspace and add a business bank account.
Delete the workspace.
Create a new workspace.
Submit a report and approve it.
Pay the report and select the bank account.
Verify you now see the split pay button with the bank account listed in the main portion of the button.
Go to Workflows and disconnect the bank account.
Go back to the report.

Expected result

You no longer see the split pay button or the bank account listed in the pay button because it was removed.

Actual result

We remove the split pay button but continue to show the disconnected bank account in it (confirmed this doesn't happen in staging).

2025-10-23_11-45-29.mp4

joekaufmanexpensify · 2025-10-23T16:01:17Z

Still seeing this bug from prior PR

joekaufmanexpensify · 2025-10-23T16:05:40Z

That's it! PR otherwise working well for me 👍

…12-reapply-followup

MrMuzyk · 2025-10-24T12:39:07Z

@joekaufmanexpensify

BUG: Modal does not initially appear when paying from reports page

I've tracked down the bug causing this. When we delete the workspace we do not clear the 'reimbursementAccount' upon successfully removing the workspace. Example of such request - 9938fc39d8fad354-SJC. IMO this is an oversight and should be fixed on FE and BE side but it won't completely solve all our problems.

We were entering this condition that was checking whether reimbrusementAccount was in progress (it was as it wasn't cleared after delete). This was opening first step of the VBBA flow. In that moment the API call was being executed, reimbursementAccount was properly updated to default empty state and everything from now on was back to normal.

Now to why fixing this particular thing won't solve our problems.

When I've started work on this particular issue (few months ago) the reimbursementAccount was the only place in onyx where we could get an account that's in progress. This bit of data was fetched whenever we opened first step of VBBA flow for particular workspace.

Now we have an option to fetch all the bank accounts - even the ones that are partially setup. This condition that I've mentioned before should be rewritten and should check bankAccountList instead of reimbursementAccount for accounts that are being setup. This means two things:

All the stuff that I've mentioned before about clearing reimbursementAccount when deleting the workspace is a NIT. In theory this bug won't happen again because we will not be checking reimbursementAccount onyx entry for partially setup accounts.
The bankAccountList that is returned as part of OpenApp should also return partially setup accounts (recent change from @srikarparsi that we were waiting for). This would also allow us to handle this scenario I've mentioned yesterday on slack

Precondition: Have workspace with connected USD account and have another workspace with different account that is partially connected

create expense for workspace with partially connected account
go to account -> troubleshoot -> clear cache and restart
go to reports -> expenses and find the previously created expense
click on pay button -> pay with business account
Expected result: RHP opens and displays screen where user can continue connecting BA he started connecting before

I could've spotted this earlier but I'm finding out new edge cases everyday 😓 Just haven't thought about this one before even though it seems quite obvious now.

Still seeing #69437 (comment) from prior PR

Fixed this one

BUG: not updating pay button if you disconnect bank account

Fixed this one too

Sorry for the lengthy post 😓

MrMuzyk · 2025-10-27T08:40:37Z

src/libs/actions/BankAccounts.ts

-        onyxData.successData?.push({
-            onyxMethod: Onyx.METHOD.MERGE,
-            key: ONYXKEYS.NVP_LAST_PAYMENT_METHOD,
-            value: {


This has to be set when user succesfully connects the account

OSBotify · 2025-12-11T19:08:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:27:05Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…reapply-followup" This reverts commit 13e0bdc, reversing changes made to bd180d7.

Revert "Merge pull request #71659 from callstack-internal/feat/65912-reapply-followup"

Revert "Merge pull request #71659 from callstack-internal/feat/65912-reapply-followup" (cherry picked from commit 6bf6a8e) (cherry-picked to staging by AndrewGable)

…eat/65912-reapply-followup" This reverts commit f099b1b.

OSBotify · 2025-12-16T22:24:00Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:46:07Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-17T12:23:49Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:45:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:08:42Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-09T20:00:37Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:19:43Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MonilBhavsar · 2026-01-12T05:28:37Z

This seems to have caused #79312 @MrMuzyk @dominictb

nkuoch · 2026-01-12T06:14:58Z

And this too #79317

MrMuzyk · 2026-01-12T07:41:25Z

Im looking into the linked issues

OSBotify · 2026-01-13T03:11:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MrMuzyk added 2 commits October 1, 2025 10:20

Reapply "feat: Followup show link existing account page when attempti…

6ca093c

…ng to pay" This reverts commit f44b425.

feat: Show page to link existing account when attempting to pay

84bb3aa

melvin-bot bot assigned MrMuzyk Oct 1, 2025

MrMuzyk added 2 commits October 2, 2025 13:03

fix: move API calls

f913f4b

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

07362e6

…12-reapply-followup

srikarparsi mentioned this pull request Oct 6, 2025

feat: Followup show link existing account page when attempting to pay #69437

Merged

51 tasks

MrMuzyk added 5 commits October 6, 2025 12:11

fix: util update

0efb2c5

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

446bf61

…12-reapply-followup

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

418772f

…12-reapply-followup

fix: cut api call

2068527

prettier

09c6f6c

MrMuzyk marked this pull request as ready for review October 23, 2025 12:05

MrMuzyk requested a review from a team as a code owner October 23, 2025 12:05

melvin-bot bot requested review from dominictb and removed request for a team October 23, 2025 12:05

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

26d5b78

…12-reapply-followup

This comment has been minimized.

Sign in to view

MrMuzyk added 2 commits October 24, 2025 09:50

Merge branch 'main' of https://github.com/Expensify/App into feat/659…

0b53af4

…12-reapply-followup

fix: testing fixes

4c2cad4

MrMuzyk commented Oct 27, 2025

View reviewed changes

srikarparsi merged commit 13e0bdc into Expensify:main Dec 11, 2025
31 checks passed

github-actions bot mentioned this pull request Dec 11, 2025

Investigate workflow job failing on main: test / test (job 4) #77430

Closed

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

jponikarchuk mentioned this pull request Dec 13, 2025

[$125] Add bank account - Existing bank account not displayed after workspace currency matches account currency #77626

Closed

7 tasks

chuckdries mentioned this pull request Dec 15, 2025

[$250] Expense - Pay with worksapce not procced to adding a bank account #77630

Closed

7 tasks

chuckdries added a commit that referenced this pull request Dec 15, 2025

Revert "Merge pull request #71659 from callstack-internal/feat/65912-…

f099b1b

…reapply-followup" This reverts commit 13e0bdc, reversing changes made to bd180d7.

chuckdries mentioned this pull request Dec 15, 2025

[CP Staging] Revert "Merge pull request #71659 from callstack-internal/feat/65912-reapply-followup" #77691

Merged

53 tasks

francoisl added a commit that referenced this pull request Dec 15, 2025

Merge pull request #77691 from Expensify/revert-71659

6bf6a8e

Revert "Merge pull request #71659 from callstack-internal/feat/65912-reapply-followup"

MrMuzyk added a commit to callstack-internal/Expensify-App that referenced this pull request Dec 16, 2025

Reapply "Merge pull request Expensify#71659 from callstack-internal/f…

1fbcaec

…eat/65912-reapply-followup" This reverts commit f099b1b.

melvin-bot bot mentioned this pull request Dec 16, 2025

[Due for payment 2026-01-20] [Better BBA] Link existing bank account to workspace for reimbursements #65912

Closed

dominictb mentioned this pull request Dec 18, 2025

feat: Show page to link existing account when attempting to pay #77751

Merged

54 tasks

This was referenced Dec 30, 2025

[CP Staging] OpenReport: pass includePartiallySetupBankAccounts=true if Concierge report #78617

Merged

[Payment due] Add BA - Bank account with action required disappears from the page after opening Help panel #78612

Closed

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Closed

77 tasks

jponikarchuk mentioned this pull request Jan 11, 2026

[Due for payment 2026-03-13] Hybrid - New flow BA page briefly shown after selects partial setup BA #79312

Closed

7 tasks

nkuoch mentioned this pull request Jan 12, 2026

Expense - Linked account page opens with no bank account after changing to non-USD currency #79317

Closed

7 tasks

Conversation

MrMuzyk commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 1, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

srikarparsi commented Oct 6, 2025

Uh oh!

MrMuzyk commented Oct 6, 2025

Uh oh!

melvin-bot bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

This comment has been minimized.

joekaufmanexpensify commented Oct 23, 2025

BUG: Modal does not initially appear when paying from reports page

Steps:

Expected result

Actual result

Uh oh!

joekaufmanexpensify commented Oct 23, 2025

BUG: not updating pay button if you disconnect bank account

Steps:

Expected result

Actual result

Uh oh!

joekaufmanexpensify commented Oct 23, 2025

Uh oh!

joekaufmanexpensify commented Oct 23, 2025

Uh oh!

MrMuzyk commented Oct 24, 2025

Uh oh!

MrMuzyk Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 11, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

MonilBhavsar commented Jan 12, 2026

Uh oh!

nkuoch commented Jan 12, 2026

Uh oh!

MrMuzyk commented Jan 12, 2026

Uh oh!

OSBotify commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MrMuzyk commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited by github-actions bot

Loading