fix: "On Hold" status is not removed after expense is moved to Self DM by daledah · Pull Request #70593 · Expensify/App

daledah · 2025-09-15T17:17:41Z

Explanation of Change

Fixed Issues

$ #69109
PROPOSAL: #69109 (comment)

Tests

Open workspace chat
Create a manual expense
Open the just created expense
Tap on "More" and select "Hold"
Enter any reason and hold the expense
Once redireted to report, tap on the report field
Tap on "Remove from report"
Navigate to Self DM
Verify that: hold status is removed from expense.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open workspace chat
Create a manual expense
Open the just created expense
Tap on "More" and select "Hold"
Enter any reason and hold the expense
Once redireted to report, tap on the report field
Tap on "Remove from report"
Navigate to Self DM
Verify that: hold status is removed from expense.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-13.at.12.23.11.mov

Android: mWeb Chrome

Screen.Recording.2025-10-13.at.12.25.21.mov

iOS: Native

Screen.Recording.2025-10-13.at.12.31.12.mov

iOS: mWeb Safari

Screen.Recording.2025-10-13.at.12.32.06.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-13.at.12.32.49.mp4

MacOS: Desktop

Screen.Recording.2025-10-13.at.12.33.42.mov

allgandalf · 2025-10-09T06:44:42Z

src/libs/actions/Transaction.ts

+                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transactionThreadReportID}`,
+                value: {[unHoldAction.reportActionID]: null},
+            });
+        }


Suggested change

}

}

transactionIDToReportActionAndThreadData[transaction.transactionID] = {

...transactionIDToReportActionAndThreadData[transaction.transactionID],

unholdReportActionID: unHoldAction.reportActionID,

};

}

@daledah if you implement the above changes, you should be all set to open this PR for review

c.c. @ahmedGaber93 for viz

codecov · 2025-10-10T04:35:08Z

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/actions/Transaction.ts	16.66%	5 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/actions/Transaction.ts	`43.40% <16.66%> (-0.45%)`	⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-13T05:34:56Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2025-10-13T05:34:57Z

@allgandalf @ahmedGaber93 PR is ready for review.

allgandalf

Tested well for me atleast

ahmedGaber93 · 2025-10-14T15:49:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Failed to build Android app, but it should work well since this a cross-platform feature.

Android: mWeb Chrome

aw.mp4

iOS: HybridApp

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

20251014234411582.mp4

20251014224622706.mp4

MacOS: Desktop

d.mp4

OSBotify · 2025-10-16T20:57:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-16T23:41:21Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-20T09:25:09Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2026-02-02T08:21:44Z

src/libs/actions/Transaction.ts

        }
+
+        // Build unhold report action
+        if (isOnHold(transaction)) {


this caused

[Due for payment 2026-01-29] [$250] Expense - Remove hold message appears each time held expense is moved to different report #78364

we should only add remove unhold message for unimported report

fix: "On Hold" status is not removed after expense is moved to Self DM

747e560

melvin-bot bot assigned daledah Sep 15, 2025

allgandalf mentioned this pull request Oct 6, 2025

Backend - "On Hold" status is not removed after expense is moved to Self DM #70431

Closed

allgandalf reviewed Oct 9, 2025

View reviewed changes

allgandalf mentioned this pull request Oct 10, 2025

[Due for payment 2025-10-27] [$250] Expense - "On Hold" status is not removed after expense is moved to Self DM #69109

Closed

16 tasks

daledah added 2 commits October 10, 2025 10:59

Merge branch 'main' into fix/69109

aec22e7

fix: add missing param to API call

7ae48f3

daledah marked this pull request as ready for review October 13, 2025 05:34

daledah requested a review from a team as a code owner October 13, 2025 05:34

melvin-bot bot requested review from ahmedGaber93 and removed request for a team October 13, 2025 05:34

allgandalf approved these changes Oct 14, 2025

View reviewed changes

ahmedGaber93 approved these changes Oct 14, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable October 14, 2025 20:50

AndrewGable approved these changes Oct 16, 2025

View reviewed changes

AndrewGable merged commit 2b68830 into Expensify:main Oct 16, 2025
24 of 26 checks passed

OSBotify mentioned this pull request Oct 16, 2025

Deploy Checklist: New Expensify 2025-10-16 #72816

Closed

67 tasks

srikarparsi mentioned this pull request Oct 17, 2025

Revert "fix: "On Hold" status is not removed after expense is moved to Self DM" #72893

Closed

ahmedGaber93 mentioned this pull request Nov 3, 2025

Feature: Implement ChangeTransactionsReport #58597

Merged

58 tasks

paulnjs mentioned this pull request Dec 24, 2025

[Due for payment 2026-01-29] [$250] Expense - Remove hold message appears each time held expense is moved to different report #78364

Closed

7 tasks

eh2077 reviewed Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: "On Hold" status is not removed after expense is moved to Self DM#70593

fix: "On Hold" status is not removed after expense is moved to Self DM#70593
AndrewGable merged 3 commits intoExpensify:mainfrom
daledah:fix/69109

daledah commented Sep 15, 2025 •

edited

Loading

Uh oh!

allgandalf Oct 9, 2025

Uh oh!

allgandalf Oct 9, 2025

Uh oh!

allgandalf Oct 9, 2025

Uh oh!

codecov bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Oct 13, 2025

Uh oh!

daledah commented Oct 13, 2025 •

edited

Loading

Uh oh!

allgandalf left a comment

Uh oh!

ahmedGaber93 commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 20, 2025

Uh oh!

eh2077 Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

-        }
+        }
+          transactionIDToReportActionAndThreadData[transaction.transactionID] = {
+              ...transactionIDToReportActionAndThreadData[transaction.transactionID],
+              unholdReportActionID: unHoldAction.reportActionID,
+          };
+      }

Conversation

daledah commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

allgandalf Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 13, 2025

Uh oh!

daledah commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 20, 2025

Uh oh!

eh2077 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

daledah commented Sep 15, 2025 •

edited

Loading

codecov bot commented Oct 10, 2025 •

edited

Loading

daledah commented Oct 13, 2025 •

edited

Loading

ahmedGaber93 commented Oct 14, 2025 •

edited

Loading