Skip to content

[CP Staging] Revert "Create super wide RHP modal to display expense reports when accessed via Reports page or report previews"#75713

Merged
rlinoz merged 2 commits intomainfrom
revert-73731-nav/swrhp
Nov 21, 2025
Merged

[CP Staging] Revert "Create super wide RHP modal to display expense reports when accessed via Reports page or report previews"#75713
rlinoz merged 2 commits intomainfrom
revert-73731-nav/swrhp

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 21, 2025 •
edited
Loading

Reverts #73731

The PR introduced a "super wide RHP" and that led to bunch of smaller issues in various flows since this touches really many user flows. We are going to revert now and try to regroup for v2 instead of trying to push through and hold the deploy.

Issues:
$ #75746
$ #75753
$ #75730
$ #75756
$ #75755
$ #75737
$ #75738
$ #75765
$ #75734
$ #75761
$ #75735
$ #75741
$ #75750
$ #75747
$ #75751
$ #75758
$ #75770
$ #75772
$ #75774
$ #75776
$ #75786

@mountiny
Revert "Create super wide RHP modal to display expense reports when a…
5448e84 
…ccessed via Reports page or report previews"
@mountiny mountiny self-assigned this Nov 21, 2025
@mountiny mountiny mentioned this pull request Nov 21, 2025
Merged
54 tasks
@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ROUTES.ts 12.27% <ø> (-0.29%) ⬇️
src/SCREENS.ts 100.00% <ø> (ø)
...stReportView/MoneyRequestReportTransactionItem.tsx 7.14% <ø> (+0.24%) ⬆️
...stReportView/MoneyRequestReportTransactionList.tsx 4.12% <ø> (+0.04%) ⬆️
src/components/ParentNavigationSubtitle.tsx 62.50% <ø> (+7.32%) ⬆️
...ReportPreview/MoneyRequestReportPreviewContent.tsx 61.59% <100.00%> (ø)
...portActionItem/MoneyRequestReportPreview/index.tsx 93.10% <ø> (ø)
src/components/Search/index.tsx 34.54% <ø> (+0.18%) ⬆️
...components/WideRHPContextProvider/index.native.tsx 100.00% <100.00%> (+5.55%) ⬆️
...tion/AppNavigator/useRootNavigatorScreenOptions.ts 80.00% <ø> (+16.00%) ⬆️
... and 27 more
... and 4 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #75713.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/75713/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/75713/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/75713/NewExpensify.dmg https://75713.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny mentioned this pull request Nov 21, 2025
Merged
@mountiny mountiny marked this pull request as ready for review November 21, 2025 18:11
@mountiny mountiny requested review from a team as code owners November 21, 2025 18:11
@melvin-bot melvin-bot bot requested review from inimaga and trjExpensify and removed request for a team November 21, 2025 18:11
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2025

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 21, 2025 18:11
mountiny
mountiny commented Nov 21, 2025
View reviewed changes
src/components/Search/index.tsx
const {accountID, email} = useCurrentUserPersonalDetails();
const [isActionLoadingSet = new Set<string>()] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}`, {canBeMissing: true, selector: isActionLoadingSetSelector});

const isExpenseReportType = type === CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT;
Copy link
Contributor Author

@mountiny mountiny Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had minor conflict here, where the isExpenseReportType was introduced by one pr

@rlinoz rlinoz merged commit 4628c33 into main Nov 21, 2025
31 of 34 checks passed
@rlinoz rlinoz deleted the revert-73731-nav/swrhp branch November 21, 2025 18:14
@melvin-bot melvin-bot bot added the Emergency label Nov 21, 2025
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2025

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@rlinoz
Copy link
Contributor

rlinoz commented Nov 21, 2025

straight revert

@mountiny
Copy link
Contributor Author

mountiny commented Nov 21, 2025

Basically straight revert with a minor line change noted above, no need to wait

@OSBotify
Copy link
Contributor

OSBotify commented Nov 21, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@iwiznia iwiznia mentioned this pull request Nov 21, 2025
Closed
8 tasks
@os-botify os-botify bot mentioned this pull request Nov 21, 2025
Merged
52 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 21, 2025
mountiny pushed a commit that referenced this pull request Nov 21, 2025
@rlinoz @mountiny
Merge pull request #75713 from Expensify/revert-73731-nav/swrhp
3fa68f9 
[CP Staging] Revert "Create super wide RHP modal to display expense reports when accessed via Reports page or report previews"

(cherry picked from commit 4628c33)

(cherry-picked to staging by mountiny)
Julesssss added a commit that referenced this pull request Nov 21, 2025
@Julesssss
Merge pull request #75800 from Expensify/cherry-pick-staging-75713-19…
e5a47f8 
…585208383-1

🍒 Cherry pick PR #75713 to staging 🍒
@OSBotify OSBotify mentioned this pull request Nov 21, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 21, 2025

🚀 Cherry-picked to staging by https://github.com/rlinoz in version: 9.2.62-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

WojtekBoman added a commit to software-mansion-labs/expensify-app-fork that referenced this pull request Nov 24, 2025
@WojtekBoman
Revert "Merge pull request Expensify#75713 from Expensify/revert-7373…
7460c88 
…1-nav/swrhp"

This reverts commit 4628c33, reversing
changes made to 78666bb.
@OSBotify
Copy link
Contributor

OSBotify commented Nov 24, 2025

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 24, 2025

🚀 Cherry-picked to staging by https://github.com/rlinoz in version: 9.2.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 26, 2025

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlinoz rlinoz rlinoz approved these changes

@trjExpensify trjExpensify Awaiting requested review from trjExpensify

@inimaga inimaga Awaiting requested review from inimaga

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @rlinoz @OSBotify