Skip to content

[CP Staging] Revert "fix:(search) update optimistic transactions pending action in search snapshot"#75890

Merged
mountiny merged 1 commit intomainfrom
revert-71199-fix/expense-not-greyed-out-offline-delete
Nov 24, 2025
Merged

[CP Staging] Revert "fix:(search) update optimistic transactions pending action in search snapshot"#75890
mountiny merged 1 commit intomainfrom
revert-71199-fix/expense-not-greyed-out-offline-delete

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 24, 2025

Reverts #71199

Straight revert

This was a PR to fix a quite minor issue but seems to have brought two new minor issues so instead of pushing this ahead, lets revert and let the author handle these in v2 @marufsharifi @eVoloshchak

Fixes #75835
Fixes #75837

@mountiny mountiny self-assigned this Nov 24, 2025
@mountiny mountiny requested review from a team as code owners November 24, 2025 12:46
@melvin-bot melvin-bot bot requested review from carlosmiceli and joekaufmanexpensify and removed request for a team November 24, 2025 12:46
@melvin-bot
Copy link

melvin-bot bot commented Nov 24, 2025

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny merged commit 43da5d3 into main Nov 24, 2025
28 of 34 checks passed
@mountiny mountiny deleted the revert-71199-fix/expense-not-greyed-out-offline-delete branch November 24, 2025 12:50
@melvin-bot
Copy link

melvin-bot bot commented Nov 24, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 24, 2025
…-greyed-out-offline-delete

[CP Staging] Revert "fix:(search) update optimistic transactions pending action in search snapshot"

(cherry picked from commit 43da5d3)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/MoneyRequestHeader.tsx 0.83% <ø> (+0.01%) ⬆️
src/libs/ReportUtils.ts 75.51% <100.00%> (-0.05%) ⬇️
src/libs/SearchUIUtils.ts 72.95% <ø> (-0.01%) ⬇️
src/pages/ReportDetailsPage.tsx 59.42% <ø> (-0.24%) ⬇️
...ort/ContextMenu/PopoverReportActionContextMenu.tsx 41.82% <ø> (-0.28%) ⬇️
src/hooks/useDeleteTransactions.ts 16.12% <0.00%> (-1.34%) ⬇️
src/libs/actions/IOU.ts 64.36% <66.66%> (-0.26%) ⬇️
src/pages/Search/SearchPage.tsx 23.63% <0.00%> (-0.59%) ⬇️
src/libs/actions/Search.ts 22.68% <9.09%> (+0.91%) ⬆️
... and 10 files with indirect coverage changes

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.62-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

3 participants