fix:(search) update optimistic transactions pending action in search snapshot by marufsharifi · Pull Request #71199 · Expensify/App

marufsharifi · 2025-09-24T14:10:14Z

Explanation of Change

Fixed Issues

$ #69559
PROPOSAL: (comment #69559)

Tests

Submit an expense
Go to Reports > Expenses
Go offline
Click on the submitted expense
Click More > Delete
Delete the expense
Expense row should be greyed out, and the texts should be struck through

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.1404-07-03.at.10.34.19.AM.mov

Screen.Recording.1404-07-11.at.7.31.02.PM.mov

Android: mWeb Chrome

Screen.Recording.1404-07-03.at.10.49.09.AM.mov

Screen.Recording.1404-07-11.at.7.33.56.PM.mp4

iOS: Native

Screen.Recording.1404-07-03.at.10.55.59.AM.mov

Screen.Recording.1404-07-11.at.6.51.14.PM.mp4

iOS: mWeb Safari

Screen.Recording.1404-07-03.at.10.59.03.AM.mov

Screen.Recording.1404-07-11.at.7.22.45.PM.mov

MacOS: Chrome / Safari

Screen.Recording.1404-07-03.at.10.22.45.AM.mov

Screen.Recording.1404-07-11.at.6.42.46.PM.mov

MacOS: Desktop

Screen.Recording.1404-07-03.at.10.51.14.AM.mov

Screen.Recording.1404-07-11.at.7.39.32.PM.mp4

…snapshot

…moneyRequest page

melvin-bot · 2025-09-25T06:46:22Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2025-09-28T22:41:22Z

Bug 1:

Delete button should not be hidden when offline

Screen.Recording.2025-09-29.at.00.36.48.mov

src/libs/actions/IOU.ts

marufsharifi · 2025-09-30T16:18:26Z

Bug 1:

Delete button should not be hidden when offline

Screen.Recording.2025-09-29.at.00.36.48.mov

@eVoloshchak, thank you for the review! This issue doesn’t seem to be related to the changes in my PR—it also occurs on the latest main. Would you prefer that I address it here, or should I open a follow-up PR instead?

eVoloshchak · 2025-10-02T07:19:59Z

This issue doesn’t seem to be related to the changes in my PR—it also occurs on the latest main.

Yeah, this was discussed here and we decided to go with the following option:

Do not hide the delete button when offline for Reports and implement the same deletion functionality for them as well

marufsharifi · 2025-10-02T07:50:39Z

@eVoloshchak Good catch—my mistake. I’ll fix it too. thanks

marufsharifi · 2025-10-02T16:41:57Z

I will make this PR ready for review tomorrow. Thanks for your patience

marufsharifi · 2025-10-03T15:26:33Z

Bug 1:

Delete button should not be hidden when offline

Screen.Recording.2025-09-29.at.00.36.48.mov

@eVoloshchak Thanks for your patience. covered this and added new test records.

eVoloshchak · 2025-10-06T12:36:25Z

@marufsharifi, this bug is still reproducible for me, could you double-check please?

Screen.Recording.2025-10-06.at.14.33.52.mov

marufsharifi · 2025-10-07T19:41:42Z

@eVoloshchak, yes, it only happens for bulk actions. I will fix it today. thanks

marufsharifi · 2025-10-08T06:19:22Z

@eVoloshchak, thanks for your patience. The pr is ready for review, please review it when you get a chance

src/libs/actions/IOU.ts

marufsharifi · 2025-11-17T20:22:34Z

I will do more tests tomorrow, and then it will be ready to review again because it had code conflicts.

marufsharifi · 2025-11-18T05:47:23Z

@eVoloshchak, the pr is ready for your review. Thanks for your patience

luacmartins · 2025-11-18T18:06:44Z

@marufsharifi conflicts. @eVoloshchak let's get this reviewed when you're online please!

marufsharifi · 2025-11-19T03:55:45Z

conflicts resolved.

src/libs/actions/IOU.ts

src/libs/actions/Search.ts

eVoloshchak · 2025-11-19T12:31:24Z

src/libs/actions/Search.ts

+    const {optimisticData: loadingOptimisticData, finallyData} = getOnyxLoadingData(hash);
+    const optimisticData: OnyxUpdate[] = [...loadingOptimisticData];
+    const failureData: OnyxUpdate[] = [];
+


Can we just generate/subsribe to allSnapshotKeys here? That would mean we don't have to pass it from each file separately and don't have to create it on each page

@eVoloshchak Do you mean creating a helper function that generates allSnapshotKeys, so I only need to pass allSnapshots to it instead of generating allSnapshotKeys in each file and passing it down to this function?

marufsharifi · 2025-11-19T19:42:28Z

@eVoloshchak, thanks for the review. I have applied your feedback. Please take another look when you get a chance.

eVoloshchak · 2025-11-20T16:09:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-20.at.19.56.42.mov

Android: mWeb Chrome

Screen.Recording.2025-11-20.at.19.58.35.mov

iOS: HybridApp

Screen.Recording.2025-11-20.at.20.03.01.mov

iOS: mWeb Safari

Screen.Recording.2025-11-20.at.20.07.27.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-20.at.19.53.56.mov

MacOS: Desktop

Screen.Recording.2025-11-20.at.20.14.01.mov

eVoloshchak

LGTM!

OSBotify · 2025-11-20T20:05:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-21T12:25:45Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-24T20:00:47Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix:(search) update optimistic transactions pending action in search …

88a080a

…snapshot

melvin-bot bot assigned marufsharifi Sep 24, 2025

marufsharifi added 3 commits September 25, 2025 08:50

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

320fb50

fix(search): update snapshot optimistic data when delete from search/…

970bc19

…moneyRequest page

fix(search): handle update optimistic data for search snapshot

d77b81b

marufsharifi marked this pull request as ready for review September 25, 2025 06:46

marufsharifi requested a review from a team as a code owner September 25, 2025 06:46

melvin-bot bot requested a review from eVoloshchak September 25, 2025 06:46

melvin-bot bot removed the request for review from a team September 25, 2025 06:46

eVoloshchak reviewed Sep 28, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

f165a42

fix(search): update deleted transaction in all search snapshots

6e4c8d2

marufsharifi requested a review from eVoloshchak September 30, 2025 17:24

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

3b0bb1c

marufsharifi added 2 commits October 3, 2025 18:47

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

7b4d0e4

fix(search): allow users to delete expenses and reports in offline mode

503d3fa

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

f0cdcbe

marufsharifi added 2 commits October 8, 2025 08:23

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

9b1164e

fix(search): covered update optimistic data in bulk delete

da5ba47

eVoloshchak reviewed Oct 9, 2025

View reviewed changes

src/libs/actions/IOU.ts Show resolved Hide resolved

marufsharifi added 2 commits November 18, 2025 09:03

fixed remained eslint issues

ed748e8

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

4e45479

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

66eec9b

eVoloshchak suggested changes Nov 19, 2025

View reviewed changes

marufsharifi added 2 commits November 19, 2025 21:34

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

3f1d27b

unified getSnapshotKeys to and helper function

05f6d01

marufsharifi requested a review from eVoloshchak November 19, 2025 19:41

marufsharifi added 5 commits November 20, 2025 09:19

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

8799725

removed unused useMemo

0c8a397

replaced SearchTransaction with Transaction it was deprecated

277e833

replaced SearchTransaction for ReportUtils with Transaction

9822a94

fixed report utils type error

600ec50

Merge branch 'main' into fix/expense-not-greyed-out-offline-delete

fa1f66b

eVoloshchak approved these changes Nov 20, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins November 20, 2025 19:20

luacmartins approved these changes Nov 20, 2025

View reviewed changes

luacmartins merged commit 8901fa7 into Expensify:main Nov 20, 2025
31 checks passed

OSBotify mentioned this pull request Nov 21, 2025

Deploy Checklist: New Expensify 2025-11-21 #75728

Closed

This was referenced Nov 24, 2025

[$250] Reports - Expense is accessible and report is selectable when deleted offline on Reports #75835

Closed

[$250] Reports - Delete option is still present when the report is approved or paid offline #75837

Closed

mountiny mentioned this pull request Nov 24, 2025

[CP Staging] Revert "fix:(search) update optimistic transactions pending action in search snapshot" #75890

Merged

Conversation

marufsharifi commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 25, 2025

Uh oh!

eVoloshchak commented Sep 28, 2025

Uh oh!

Uh oh!

marufsharifi commented Sep 30, 2025

Uh oh!

eVoloshchak commented Oct 2, 2025

Uh oh!

marufsharifi commented Oct 2, 2025

Uh oh!

marufsharifi commented Oct 2, 2025

Uh oh!

marufsharifi commented Oct 3, 2025

Uh oh!

eVoloshchak commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marufsharifi commented Oct 7, 2025

Uh oh!

marufsharifi commented Oct 8, 2025

Uh oh!

Uh oh!

marufsharifi commented Nov 17, 2025

Uh oh!

marufsharifi commented Nov 18, 2025

Uh oh!

luacmartins commented Nov 18, 2025

Uh oh!

marufsharifi commented Nov 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

marufsharifi Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marufsharifi commented Nov 19, 2025

Uh oh!

eVoloshchak commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 20, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

marufsharifi commented Sep 24, 2025 •

edited

Loading

eVoloshchak commented Oct 6, 2025 •

edited

Loading

eVoloshchak Nov 19, 2025 •

edited

Loading

eVoloshchak commented Nov 20, 2025 •

edited

Loading