follow-up: Reports - Workspace quick filter has no search field when there are at least 12 workspaces#76318
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Screenshots and videos good to me 👍 |
|
@Expensify/design Not really related to this PR, but is there a reason we don't include a little avatar for Workspaces like we do for Members (like in the |
That's a good call out. I think the answer is that it was missed. I like cleaning up that inconsistency now. |
|
If we want to do that here - let's just make sure the avatar size and spacing matches the |
|
Yeah I like adding that now 👍 |
…are at least 12 workspaces
c823d38 to
49ed3df
Compare
Done. Also updated the screenshots. You can check them out. |
|
Looking good! |
|
PR is ready for review @Pujan92 |
…kspace-when-a-user-is-a-member-of-several-workspaces
…kspace-when-a-user-is-a-member-of-several-workspaces
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-12-10.at.18.35.53.moviOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-12-10.at.18.28.02.movMacOS: Chrome / SafariScreen.Recording.2025-12-10.at.18.20.34.movScreen.Recording.2025-12-10.at.18.21.15.mov |
…-exposed-filter-for-workspace-when-a-user-is-a-member-of-several-workspaces
…-exposed-filter-for-workspace-when-a-user-is-a-member-of-several-workspaces
…n-a-user-is-a-member-of-several-workspaces
…n-a-user-is-a-member-of-several-workspaces
…-exposed-filter-for-workspace-when-a-user-is-a-member-of-several-workspaces
…-exposed-filter-for-workspace-when-a-user-is-a-member-of-several-workspaces
|
@TaduJR Let's merge main to fix Typescript check. |
…kspace-when-a-user-is-a-member-of-several-workspaces
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.2.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀
|

Explanation of Change
This PR fixes the missing search field in the Workspace quick filter when there are 8+ workspaces (now updated to 12+ per team discussion).
Fixed Issues
$ #75939
PROPOSAL:
Tests
Precondition:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari