Make SelectionScreen use new SelectionList#79080
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
I have requested QA to do a full regression suite here - https://expensify.slack.com/archives/C9YU7BX5M/p1767874101908179 Instructions are to stop if there are >5 issues |
This comment has been minimized.
This comment has been minimized.
Expense - Unable to delete expense from expense previewIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Version Number: v9.2.95-3 PR:79080 Action Performed:
Expected Result:Expense will be deleted. Actual Result:Expense is not deleted. Workaround:Unknown Platforms:
Screenshots/VideosBug7043733_1767881727201.1.mp4 |
|
I'm able to reproduce this issue on main without my changes, so not related |
Reports - Report details RHP does not close after deleting the expenseVersion Number: v9.2.95-3 PR:79080 Action Performed:
Expected Result:Report details RHP will close after deleting the expense. Actual Result:Report details RHP does not close after deleting the expense. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Workflows - Error shows up when saving workflow when the report limit is not savedIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Version Number: v9.2.95-3 PR:79080 Action Performed:
Expected Result:No error will show up because the report limit is not saved. Actual Result:Error shows up when saving workflow when the report limit is not saved. Workaround:Unknown Platforms:
Screenshots/VideosBug7043759_1767884479474.3.mp4 |
Integrations-Android- Detail page doesn't have any content in all the integrations pageIf you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! Version Number: v9.2.95-3 Adhoc Action Performed:
Expected Result:There should be a list of options Actual Result:No options displayed in the list of detail page Workaround:Unknown Platforms:
Screenshots/VideosBug7043758_1767884457514.QBOo.mp4 |
|
First three issues are not related to my PR, the last one I'm looking into |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
Hey @zfurtak, why don't we split it into many smaller PRs? And which wave does this PR belong to? |
We can connect it to the 5th one as this is the very last PR from the whole migration.
We discussed this case with @grgia and agreed that splitting this into so many PRs would be overcomplicated and unnecessary. However to minimise possibility of regressions QA regression suite is ongoing |
Company card - RHP loads infinitely after adding a direct feedVersion Number: v9.2.95-3 PR:79080 Action Performed:
Expected Result:RHP will close. Actual Result:RHP loads infinitely after adding a direct feed. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
Import contacts - Device's Contacts don't appear in the contacts list after allowing accessVersion Number: v9.2.95-3 PR:79080 Action Performed:
Expected Result:The device's Contacts appear in the contacts list. Actual Result:The device's Contacts don't appear in the contacts list. Workaround:Unknown Platforms:
Screenshots/Videos1.mp4 |
|
The only issue that seems related to my changes has been addressed by my last commit |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
Retriggered a test build to reset IOS @IuliiaHerets Could we retest #79080 (comment) to confirm it is fixed on latest? |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@grgia is it correct build? |
Not reproducible v9.2.96-4 Ad-Hoc Screen_Recording_20260109_211114_Expensify.Adhoc.mp4 |
|
@dukenv0307 could you review the code? 😊 |
|
@zfurtak Sure, on it now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-12.at.23.21.02.movAndroid: mWeb ChromeScreen.Recording.2026-01-12.at.23.17.17.moviOS: HybridAppScreen.Recording.2026-01-12.at.23.25.58.moviOS: mWeb SafariScreen.Recording.2026-01-12.at.23.15.49.movMacOS: Chrome / SafariScreen.Recording.2026-01-12.at.23.14.21.movScreen.Recording.2026-01-12.at.23.31.32.movScreen.Recording.2026-01-12.at.23.34.25.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|

Explanation of Change
Fixed Issues
$ #65655
PROPOSAL:
Tests
This PR modifies many pages among workspace accounting integrations (Xero, Sage Intacct, Quickbooks, Net Suite)
Offline tests
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Quickbooks
Screen.Recording.2026-01-08.at.13.03.11.mov