Skip to content

Make SelectionScreen use new SelectionList#79080

Merged
grgia merged 10 commits intoExpensify:mainfrom
software-mansion-labs:@zfurtak/migrate-SelectionScreen
Jan 12, 2026
Merged

Make SelectionScreen use new SelectionList#79080
grgia merged 10 commits intoExpensify:mainfrom
software-mansion-labs:@zfurtak/migrate-SelectionScreen

Conversation

@zfurtak
Copy link
Contributor

@zfurtak zfurtak commented Jan 8, 2026

Explanation of Change

Fixed Issues

$ #65655
PROPOSAL:

Tests

This PR modifies many pages among workspace accounting integrations (Xero, Sage Intacct, Quickbooks, Net Suite)

  1. Go to a workspace
  2. Connect with each accounting system
  3. Verify accounting pages work correctly
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Quickbooks

Screen.Recording.2026-01-08.at.13.03.11.mov

@codecov
Copy link

codecov bot commented Jan 8, 2026

@grgia grgia self-requested a review January 8, 2026 12:06
@zfurtak zfurtak marked this pull request as ready for review January 8, 2026 12:06
@zfurtak zfurtak requested review from a team as code owners January 8, 2026 12:06
@melvin-bot melvin-bot bot requested review from dukenv0307 and trjExpensify and removed request for a team January 8, 2026 12:06
@melvin-bot
Copy link

melvin-bot bot commented Jan 8, 2026

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 8, 2026 12:06
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@grgia
Copy link
Contributor

grgia commented Jan 8, 2026

I have requested QA to do a full regression suite here - https://expensify.slack.com/archives/C9YU7BX5M/p1767874101908179

Instructions are to stop if there are >5 issues

@github-actions

This comment has been minimized.

@nlemma
Copy link

nlemma commented Jan 8, 2026

Expense - Unable to delete expense from expense preview

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.95-3 PR:79080
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): sdnsdhiubhsdiudhsui@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 79080.pr-testing.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Right click on the expense preview > Delete expense.
  5. Click Delete.

Expected Result:

Expense will be deleted.

Actual Result:

Expense is not deleted.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7043733_1767881727201.1.mp4

View all open jobs on GitHub

@zfurtak
Copy link
Contributor Author

zfurtak commented Jan 8, 2026

I'm able to reproduce this issue on main without my changes, so not related

@jponikarchuk
Copy link

Reports - Report details RHP does not close after deleting the expense

Version Number: v9.2.95-3 PR:79080
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdnsdhiubhsdiudhsui@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 79080.pr-testing.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Reports > Expenses.
  5. Open the expense.
  6. Click on the report header.
  7. Click Delete expense.
  8. Delete the expense.

Expected Result:

Report details RHP will close after deleting the expense.

Actual Result:

Report details RHP does not close after deleting the expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@nlemma
Copy link

nlemma commented Jan 8, 2026

Workflows - Error shows up when saving workflow when the report limit is not saved

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.95-3 PR:79080
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): sdnsdhiubhsdiudwhsui@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 79080.pr-testing.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click on the default workflow.
  4. Click Approver.
  5. Enter Report amount.
  6. Click RHP back button.
  7. Click Save.
    → No error shows up.
  8. Click on the default workflow.
  9. Click Approver.
  10. Enter Report amount.
  11. Click Additional approver.
  12. Click RHP back button.
  13. Click RHP back button again
  14. Click Save button.

Expected Result:

No error will show up because the report limit is not saved.

Actual Result:

Error shows up when saving workflow when the report limit is not saved.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7043759_1767884479474.3.mp4

View all open jobs on GitHub

@nlemma
Copy link

nlemma commented Jan 8, 2026

Integrations-Android- Detail page doesn't have any content in all the integrations page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.95-3 Adhoc
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung s10/ android 12

Action Performed:

  1. Navigate to Android app
  2. Connect QBO or Xero
  3. Go to Import > Classes > Display as
  4. Open other places as well

Expected Result:

There should be a list of options

Actual Result:

No options displayed in the list of detail page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7043758_1767884457514.QBOo.mp4

View all open jobs on GitHub

@zfurtak
Copy link
Contributor Author

zfurtak commented Jan 8, 2026

First three issues are not related to my PR, the last one I'm looking into

@trjExpensify
Copy link
Contributor

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

@trjExpensify trjExpensify removed their request for review January 8, 2026 15:31
@dukenv0307
Copy link
Contributor

Hey @zfurtak, why don't we split it into many smaller PRs? And which wave does this PR belong to?

@zfurtak
Copy link
Contributor Author

zfurtak commented Jan 8, 2026

And which wave does this PR belong to?

We can connect it to the 5th one as this is the very last PR from the whole migration.

Hey @zfurtak, why don't we split it into many smaller PRs?

We discussed this case with @grgia and agreed that splitting this into so many PRs would be overcomplicated and unnecessary. However to minimise possibility of regressions QA regression suite is ongoing

@jponikarchuk
Copy link

Company card - RHP loads infinitely after adding a direct feed

Version Number: v9.2.95-3 PR:79080
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): sdnsdhiubhsdiudhsui@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome

Action Performed:

  1. Go to 79080.pr-testing.expensify.com
  2. Go to workspace settings > Company cards.
  3. Add Wells Fargo direct feed.
  4. After returning from Plaid flow, click Submit on Statement close date.

Expected Result:

RHP will close.

Actual Result:

RHP loads infinitely after adding a direct feed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk
Copy link

Import contacts - Device's Contacts don't appear in the contacts list after allowing access

Version Number: v9.2.95-3 PR:79080
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): applausetester+poiyu@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy S21 Ultra/Android 15
App Component: undefined

Action Performed:

  1. Launch Expensify Android app Ad-Hoc build: v9.2.95-3
  2. Login with Expensifail account
  3. Tap the '+' button
  4. Select 'create expense' from the menu
  5. Navigate to the create expenses page
  6. Tap "Scan" option
  7. Take a photo of expenses
  8. On the soft permission modal to import your contacts, tap "Continue"
  9. On native modal to import the contacts allow access to the device contacts

Expected Result:

The device's Contacts appear in the contacts list.

Actual Result:

The device's Contacts don't appear in the contacts list.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@zfurtak
Copy link
Contributor Author

zfurtak commented Jan 9, 2026

The only issue that seems related to my changes has been addressed by my last commit

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@grgia
Copy link
Contributor

grgia commented Jan 9, 2026

Retriggered a test build to reset IOS @IuliiaHerets

Could we retest #79080 (comment) to confirm it is fixed on latest?

@IuliiaHerets
Copy link

@grgia is it correct build?
IMG_6020

@IuliiaHerets
Copy link

@grgia

Could we retest #79080 (comment) to confirm it is fixed on latest?

Not reproducible v9.2.96-4 Ad-Hoc

Screen_Recording_20260109_211114_Expensify.Adhoc.mp4

@zfurtak
Copy link
Contributor Author

zfurtak commented Jan 12, 2026

@dukenv0307 could you review the code? 😊

@dukenv0307
Copy link
Contributor

@zfurtak Sure, on it now

@dukenv0307
Copy link
Contributor

dukenv0307 commented Jan 12, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-01-12.at.23.21.02.mov
Android: mWeb Chrome
Screen.Recording.2026-01-12.at.23.17.17.mov
iOS: HybridApp
Screen.Recording.2026-01-12.at.23.25.58.mov
iOS: mWeb Safari
Screen.Recording.2026-01-12.at.23.15.49.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-12.at.23.14.21.mov
Screen.Recording.2026-01-12.at.23.31.32.mov
Screen.Recording.2026-01-12.at.23.34.25.mov

@grgia grgia merged commit e3978fb into Expensify:main Jan 12, 2026
31 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants