[Side Panel] Concierge Everywhere AB tests by blazejkustra · Pull Request #79122 · Expensify/App

blazejkustra · 2026-01-08T17:29:58Z

Explanation of Change

New signup admins who select 1-10 employees in onboarding currently land in #admins full-width after completing onboarding. We want to test different landing experiences:

Control: Current behavior (#admins full-width, Side Panel closed)
Variant A: Workspace Editor (/workspaces/<policyID>/overview) with Concierge DM open in the Side Panel
Variant B: Workspace Editor (/workspaces/<policyID>/overview) with #admins open in the Side Panel

Fixed Issues

$ #78413
PROPOSAL: N/A

Tests

Test all A/B/Control cases

Log in to a new account
While doing the onboarding click on: "Manage my team's expenses" > "1-10" > continue to the last screen of the onboarding
Check what value was generated for the user in the console: Onyx.get('nvp_onboardingRHPVariant')

Based on the value test if:
a) control: Side Panel is closed and Your space or #admins room is be displayed
b) rhpConciergeDm: Side Panel is opened automatically and user is redirected to the Workspace Editor (/workspaces/<policyID>/overview). Concierge is displayed in the Side Panel
c) rhpAdminsRoom: Side Panel is opened automatically and user is redirected to the Workspace Editor (/workspaces/<policyID>/overview). #admins room is displayed in the Side Panel

Check that onboarding works as before in all other cases (other than "Manage my team's expenses" > "1-10")

Offline tests

N/A

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-01-09.at.15.32.53.1.mov

codecov · 2026-01-08T17:38:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.76% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
...omponents/SidePanel/RHPVariantTest/index.native.ts	`100.00% <100.00%> (ø)`
...dePanel/isSidePanelReportSupported/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/API/index.ts	`92.70% <100.00%> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
.../components/SidePanel/SidePanelContextProvider.tsx	`76.74% <92.30%> (+6.74%)`	⬆️
src/components/SidePanel/SidePanelReport/index.tsx	`0.00% <0.00%> (ø)`
...ents/SidePanel/isSidePanelReportSupported/index.ts	`0.00% <0.00%> (ø)`
...components/TestDrive/Modal/AdminTestDriveModal.tsx	`0.00% <0.00%> (ø)`
... and 5 more
... and 25 files with indirect coverage changes

… SidePanel definition.

…ds, change complete onboarding from write to makeRequestWithSideEffects

staszekscp

Good job! 🎉

src/components/SidePanel/SidePanelContextProvider.tsx

src/components/SidePanel/SidePanelReport/index.tsx

…remove report ID handling.

melvin-bot · 2026-01-09T17:41:18Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2026-01-09T17:42:15Z

I think @aimane-chnaif should review this one, but not sure tbh so I'm just tagging him for visibility :)

blazejkustra · 2026-01-09T17:42:25Z

@marcochavezf take a look please 🙇

aimane-chnaif · 2026-01-09T17:43:26Z

yes I can

marcochavezf · 2026-01-09T18:05:30Z

@bernhardoj, I assigned @aimane-chnaif since they reviewed the implementation of Concierge in the RHP previously 🙇🏽

aimane-chnaif · 2026-01-13T07:17:46Z

src/components/SidePanel/RHPVariantTest/index.ts

+// We use Onyx.connectWithoutView because we do not use this in React components and this logic is not tied directly to the UI.
+Onyx.connectWithoutView({
+    key: ONYXKEYS.NVP_ONBOARDING_RHP_VARIANT,
+    callback: (value) => {
+        onboardingRHPVariant = value;
+    },
+});
+
+Onyx.connectWithoutView({


Not sure if guys working on Onyx.connect deprecation will mark this as regression

We should not use even connectWithoutView. And why is this file in /components folder as all the functions are utils, not connected to UI.

In this case I would advise against using useOnyx, It's just a beta that will be removed in couple of weeks/months. It's much easier to keep the logic in one place instead of using useOnyx and making a bigger refactor.

The whole project is blocked by this so I would prefer to continue with this approach, wdyt @marcochavezf?

ok, I think that reason would be enough to treat this as not regression.

Yup, I agree with @blazejkustra that we should continue with this approach. This is a temporary A/B experiment, and we will update the code again once we have a winning variant (which hopefully can be seen in a couple of weeks)

aimane-chnaif · 2026-01-13T07:31:15Z

Is it expected that onboarding modal is popped up while RHP is open?
Maybe not blocker but after skip, composer is not focused automatically.

aimane-chnaif · 2026-01-13T07:37:02Z

Bug: [iOS safari] black screen shows before opening admins page

Screen.Recording.2026-01-13.at.8.36.10.am.mov

aimane-chnaif · 2026-01-13T07:59:50Z

Bug: console error on iOS

ios.mov

blazejkustra · 2026-01-13T10:27:54Z

Is it expected that onboarding modal is popped up while RHP is open? Maybe not blocker but after skip, composer is not focused automatically.

Yes, that was discussed on slack here

blazejkustra · 2026-01-13T10:30:25Z

Bug: [iOS safari] black screen shows before opening admins page

This is a performance issue, you can clearly see that a lot of things happen at the same time (onboarding, test drive, concierge and other calculations). I don't think we can do mucha about it.

…ation into onboarding logic

blazejkustra · 2026-01-13T10:45:35Z

Bug: console error on iOS

Good catch, just fixed it @aimane-chnaif

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2026-01-13.at.11.44.31.mov

blazejkustra · 2026-01-13T10:46:11Z

Back to you @aimane-chnaif!

…here-ab-tests

src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

aimane-chnaif · 2026-01-13T12:12:27Z

To confirm, when nvp_onboardingRHPVariant is rhpAdminsRoom, side panel becomes "#admins Everywhere" instead of "Concierge Everywhere" and not able to open concierge chat in RHP, right?

Screen.Recording.2026-01-13.at.1.09.26.pm.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96da54f0bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx

aimane-chnaif · 2026-01-13T12:21:03Z

No more blockers found

trjExpensify

Implementing this A/B test is part of an agreed plan for the onboarding enhancements in #concierge-ai 👍

blazejkustra · 2026-01-13T13:37:06Z

To confirm, when nvp_onboardingRHPVariant is rhpAdminsRoom, side panel becomes "#admins Everywhere" instead of "Concierge Everywhere" and not able to open concierge chat in RHP, right?

Screen.Recording.2026-01-13.at.1.09.26.pm.mov

Yep!

…d a try-catch block around the onboarding completion process

marcochavezf

Great! Let's 🚀

marcochavezf · 2026-01-13T16:19:38Z

src/components/SidePanel/RHPVariantTest/index.ts

+// We use Onyx.connectWithoutView because we do not use this in React components and this logic is not tied directly to the UI.
+Onyx.connectWithoutView({
+    key: ONYXKEYS.NVP_ONBOARDING_RHP_VARIANT,
+    callback: (value) => {
+        onboardingRHPVariant = value;
+    },
+});
+
+Onyx.connectWithoutView({


Yup, I agree with @blazejkustra that we should continue with this approach. This is a temporary A/B experiment, and we will update the code again once we have a winning variant (which hopefully can be seen in a couple of weeks)

OSBotify · 2026-01-13T16:31:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-14T03:24:08Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T21:32:16Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

blazejkustra added 2 commits January 8, 2026 18:27

Add onboarding RHP variant type for A/B/C testing

90181f2

Introduce SidePanelReport component to display any report.

47a5f50

melvin-bot bot assigned blazejkustra Jan 8, 2026

blazejkustra mentioned this pull request Jan 8, 2026

[Due for payment 2026-01-21] Implement RHP navigation variants for 1-10 admin onboarding experiment #78413

Open

blazejkustra added 6 commits January 9, 2026 15:16

Remove unused SidePanelContent type and related content property from…

886a5b2

… SidePanel definition.

Add ONBOARDING_RHP_VARIANT constants for new onboarding variants

615d2de

Refactor onboarding process to include waitForWrites for write comman…

24a91f5

…ds, change complete onboarding from write to makeRequestWithSideEffects

Handle side panel navigation with specific content.

2ffa3cd

Fix lint

c763497

Fix prettier

04bef66

staszekscp approved these changes Jan 9, 2026

View reviewed changes

src/components/SidePanel/SidePanelContextProvider.tsx Show resolved Hide resolved

src/components/SidePanel/SidePanelReport/index.tsx Show resolved Hide resolved

blazejkustra added 2 commits January 9, 2026 18:07

Refactor SidePanel navigation logic to simplify opening behavior and …

b26735a

…remove report ID handling.

Check if policy is deleted

d2c5721

blazejkustra changed the title ~~Concierge everywhere ab tests~~ [Side Panel] Concierge Everywhere AB tests Jan 9, 2026

blazejkustra marked this pull request as ready for review January 9, 2026 17:41

blazejkustra requested review from a team as code owners January 9, 2026 17:41

melvin-bot bot requested review from bernhardoj and trjExpensify and removed request for a team January 9, 2026 17:41

melvin-bot bot removed the request for review from a team January 9, 2026 17:41

marcochavezf requested review from aimane-chnaif and marcochavezf January 9, 2026 18:03

marcochavezf removed the request for review from bernhardoj January 9, 2026 18:05

aimane-chnaif reviewed Jan 13, 2026

View reviewed changes

Add RHP Variant logic for native platform with no-op implementations

c53d48c

Add isSidePanelReportSupported logic with type definitions and integr…

042cb72

…ation into onboarding logic

Merge branch 'main' of github.com:Expensify/App into concierge-everyw…

96da54f

…here-ab-tests

aimane-chnaif reviewed Jan 13, 2026

View reviewed changes

src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 13, 2026

View reviewed changes

src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx Outdated Show resolved Hide resolved

aimane-chnaif approved these changes Jan 13, 2026

View reviewed changes

trjExpensify previously approved these changes Jan 13, 2026

View reviewed changes

Refactor onboarding logic to include error handling and logging. Adde…

08b8da5

…d a try-catch block around the onboarding completion process

blazejkustra dismissed trjExpensify’s stale review via 08b8da5 January 13, 2026 13:49

marcochavezf approved these changes Jan 13, 2026

View reviewed changes

marcochavezf merged commit 1a97ec1 into Expensify:main Jan 13, 2026
34 checks passed

OSBotify mentioned this pull request Jan 14, 2026

Deploy Checklist: New Expensify 2026-01-14 #79522

Closed

39 tasks

daledah mentioned this pull request Jan 26, 2026

[$250] WS overview page opens after creating an account with "Manage my team's expenses" #80303

Closed

7 tasks

situchan mentioned this pull request Feb 17, 2026

[$250] Onboarding - Manage teams expenses - User land on the Self DM instead of Concierge chat #79532

Closed

7 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 4] Migrate Onboarding usages #83065

Open

OSBotify mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-24] Onboarding - Test Drive modal appears when selecting "Manage my team's..." option #85162

Closed

7 tasks

Conversation

blazejkustra commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

staszekscp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

blazejkustra commented Jan 9, 2026

Uh oh!

blazejkustra commented Jan 9, 2026

Uh oh!

aimane-chnaif commented Jan 9, 2026

Uh oh!

marcochavezf commented Jan 9, 2026

Uh oh!

aimane-chnaif Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

marcochavezf Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

blazejkustra commented Jan 13, 2026

Uh oh!

blazejkustra commented Jan 13, 2026

Uh oh!

blazejkustra commented Jan 13, 2026

Uh oh!

blazejkustra commented Jan 13, 2026

Uh oh!

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aimane-chnaif commented Jan 13, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra commented Jan 13, 2026

Uh oh!

marcochavezf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcochavezf Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

blazejkustra commented Jan 8, 2026 •

edited

Loading

codecov bot commented Jan 8, 2026 •

edited by github-actions bot

Loading

marcochavezf Jan 13, 2026 •

edited

Loading

marcochavezf left a comment •

edited

Loading

marcochavezf Jan 13, 2026 •

edited

Loading