show not found page for deleted duplicate expense.#79530
show not found page for deleted duplicate expense.#79530dangrous merged 38 commits intoExpensify:mainfrom
Conversation
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c3298d594
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
@marufsharifi could you please check this comment and update the test steps? We can navigate twice with the forward button. |
@Krishna2323, thanks for the review. applied. |
|
@marufsharifi did you forgot to push the commit? I don't see any fix for this. |
|
@Krishna2323, thanks for your patience. I updated the code and resolved the conflicts. |
|
@Krishna2323, kindly bump. thanks. |
|
@Krishna2323, thanks for the review. I applied your feedback. |
|
@Krishna2323, kindly bump. thanks |
|
I was OOO for the last five days; I’ll review it today. |
|
@marufsharifi please merge main |
|
@marufsharifi the issue is still reproducible, could you please check? Monosnap.screencast.2026-01-28.15-45-23.mp4 |
|
@Krishna2323, kindly bump. thanks. |
Krishna2323
left a comment
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM and works well! 🚀
@marufsharifi could you please add tests in the OP from here? Thanks!
|
Looks good to me but we've got conflicts, can you update please? Thank you! |
|
@dangrous, resolved the conflicts. thanks |
|
@marufsharifi prettier error should be resolved by merging main and running it locally! #83231 |
|
@dangrous, this is ready. Could you please take another look? thanks. |
|
augh now conflicts again.... we'll get there soon! |
|
@dangrous, resolved again. thanks. |
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.26-0 🚀
|
|
@marufsharifi This PR is failing because of a regression issue #83519, #83521 , and #83532 The issue is reproducible in: Web issue #83519 [Test 2: Basic duplicate delete + forward button (offline)] Bug7088609_1772050708997.Screen_Recording_2026-02-25_at_11.00.21_at_night.mp4issue #83521 [Test 4: Delete single expense from ReportDetailsPage (existing flow)] Bug7088623_1772052012444.Screen_Recording_2026-02-25_at_11.29.09_at_night.mp4issue #83532 [Test 10: "Keep All" on Review Duplicates] Uploading Bug7088660_1772054906158!bug33.mp4… |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀
|
6 participants
Explanation of Change
This change will show
Not foundpage instead of infinte loading state when deleting a duplicated expense and clicking on the forward button of the browser.Fixed Issues
$ #78338
PROPOSAL: #78338 (Comment)
Tests
Test 1: Basic duplicate delete + forward button (online)
Go to a workspace chat
Create two expenses with the same amount (e.g., $10.00 each)
Open the expense report
Click "Review duplicates" in the header
Click on the first expense preview to open it
Click More → Delete → confirm deletion
You should navigate back to the Review Duplicates page
Click the browser forward button once
✅ Expected: "Not Found" page (NOT the deleted expense)
Click the browser forward button again (if possible)
✅ Expected: Still "Not Found" or no navigation
Test 2: Basic duplicate delete + forward button (offline)
Repeat steps 1-6 from Test 1
Turn off network (airplane mode / disconnect)
Click the browser forward button once
✅ Expected: "Not Found" page
Click the browser forward button again
✅ Expected: "Not Found" page
Turn network back on
✅ Expected: Page remains "Not Found", no errors in console
Test 3: No brief "Not Found" flash during deletion
Repeat steps 1-6 from Test 1
Watch the screen carefully during step 6 (the delete action)
✅ Expected: No brief flash of "Not Found" page before navigating back. Should see smooth transition (possibly a loading skeleton, then the Review page).
🟡 Regression Tests — Existing Deletion Flows
Test 4: Delete single expense from ReportDetailsPage (existing flow)
Go to a chat and create a single expense
Open the expense
Click the report details (header/3-dot menu)
Delete the expense from the details page
✅ Expected: Navigates back smoothly, no "Not Found" flash, no errors
Click the browser forward button
✅ Expected: "Not Found" page (same behavior as staging/main)
Test 5: Delete expense from MoneyRequestHeader (transaction thread)
Open a chat with a single expense
Click on the expense to open the transaction thread
Click More → Delete → confirm
✅ Expected: Smooth navigation back, no "Not Found" flash
Click the browser forward button
✅ Expected: "Not Found" page
Test 6: Delete expense from MoneyReportHeader (expense report with multiple transactions)
Create a workspace with 3+ expenses in a report
Open the expense report
Open one of the individual expenses
Click More → Delete → confirm
✅ Expected: Navigates back to the expense report (now with fewer transactions), no flash
Check the expense report displays correctly
Test 7: Delete last transaction on a report from search
Open Search, find an expense report with a single transaction
Click on the report to open it in the RHP
Delete the transaction
✅ Expected: Should navigate back or show "Not Found" cleanly — no infinite loading spinner
Click the browser forward button
✅ Expected: "Not Found" page
Test 8: Delete from expense report with multiple transactions from search
Open Search, find an expense report with 2+ transactions
Open the report in the RHP
Delete one transaction
✅ Expected: Report updates to show remaining transactions, no flash
Check that the remaining transaction(s) display correctly
🟢 Edge Case Tests
Test 9: Navigate away from Review Duplicates WITHOUT deleting
Create duplicate expenses → open expense report → click "Review duplicates"
Click on an expense preview
Click the browser back button (don't delete anything)
✅ Expected: Returns to Review Duplicates page normally
Click forward/back a few times
✅ Expected: Normal navigation, no "Not Found" showing
Test 10: "Keep All" on Review Duplicates
Create duplicate expenses → open expense report → click "Review duplicates"
Click "Keep All"
✅ Expected: Navigates back normally
Click the browser forward button
✅ Expected: Should NOT show the duplicates review page (or show Not Found)
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not Applicable.
Android: mWeb Chrome
Screen.Recording.1404-10-24.at.11.35.44.AM.mov
iOS: Native
Not Applicable.
iOS: mWeb Safari
Screen.Recording.1404-10-24.at.11.41.05.AM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-10-24.at.11.24.50.AM.mov