fix: The Expense Policy RHP auto-closes unexpectedly by paulnjs · Pull Request #81313 · Expensify/App

paulnjs · 2026-02-03T15:31:11Z

Explanation of Change

Fixed Issues

$#80457
PROPOSAL:#80457 (comment)

Tests

Precondition:

Log in with Expensifail account.

Open the app
Go to workspace settings > Overview.
Click Expense policy.
Verify Expense policy RHP not auto close.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Log in with Expensifail account.

Open the app
Go to workspace settings > Overview.
Click Expense policy.
Verify Expense policy RHP not auto close.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android_chorme.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_sfr.mov

MacOS: Chrome / Safari

chorme.mov

codecov · 2026-02-03T15:44:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/pages/workspace/rules/RulesCustomPage.tsx	`0.00% <0.00%> (ø)`
... and 23 files with indirect coverage changes

melvin-bot · 2026-02-03T15:56:34Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da1c8e11fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-03T16:04:51Z

src/pages/workspace/rules/RulesCustomPage.tsx

        <AccessOrNotFoundWrapper
            policyID={policyID}
            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
-            featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}
+            shouldBeBlocked={!isBetaEnabled(CONST.BETAS.CUSTOM_RULES)}


Keep rules feature gating for custom rules page

This removes featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED} and only blocks on the user beta flag. That means a workspace with areRulesEnabled=false (rules feature disabled in More Features) but a user in the CUSTOM_RULES beta can still access this page and submit updateCustomRules, while all other rules pages still require the rules feature gate (e.g., PolicyRulesPage and RulesMaxExpenseAmountPage). If rules are disabled for the policy, this bypass lets admins edit custom rules that the feature toggle is supposed to block and won’t redirect them back to More Features, which is inconsistent with the rest of the rules section.

Useful? React with 👍 / 👎.

@JmillsExpensify, what do you think from a product perspective?

Hmm, I'm not sure I understand what the custom rules beta is. @JS00001 is this something we're using at the moment?

I'm not sure what the custom rules beta is. Its not related to merchant or personal rules

Thanks, not sure what I'm being ask for an opinion on then. Qichen Zhu, mind explaining a bit more?

@JmillsExpensify @JS00001, the beta flag controls whether the Expense policy section shows on the Workspace Overview page. However, it does not function correctly when Rules is disabled in More features.

Should Expense policy work regardless of whether the Rules feature is enabled?

Yes, it should. I don't see how it's related to the Rules feature.

JmillsExpensify

Good product polish

QichenZhu · 2026-02-22T22:46:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-23.at.11.41.17.AM.mov

Android: mWeb Chrome

Screen.Recording.2026-02-23.at.11.44.55.AM.mov

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.17.-.2026-02-23.at.11.44.08.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.17.-.2026-02-23.at.11.43.06.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-23.at.11.39.35.AM.mov

QichenZhu

Thanks!

OSBotify · 2026-02-25T14:49:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-25T14:52:59Z

🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T14:57:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81313.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-89d678d-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-89d678d-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://81313.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:23:34Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:55:06Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: The Expense Policy RHP auto-closes unexpectedly

da1c8e1

melvin-bot bot assigned paulnjs Feb 3, 2026

paulnjs marked this pull request as ready for review February 3, 2026 15:56

paulnjs requested review from a team as code owners February 3, 2026 15:56

melvin-bot bot requested review from JmillsExpensify and QichenZhu and removed request for a team February 3, 2026 15:56

melvin-bot bot removed the request for review from a team February 3, 2026 15:56

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

JmillsExpensify approved these changes Feb 13, 2026

View reviewed changes

QichenZhu approved these changes Feb 22, 2026

View reviewed changes

melvin-bot bot requested a review from MarioExpensify February 22, 2026 22:46

MarioExpensify approved these changes Feb 25, 2026

View reviewed changes

MarioExpensify merged commit 89d678d into Expensify:main Feb 25, 2026
34 of 42 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

QichenZhu mentioned this pull request Mar 6, 2026

Fix: Taxes page still shown when disable the taxes from other browser #76611

Merged

53 tasks

Conversation

paulnjs commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Feb 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

paulnjs commented Feb 3, 2026 •

edited

Loading

codecov bot commented Feb 3, 2026 •

edited by github-actions bot

Loading

JS00001 Feb 13, 2026 •

edited

Loading