feat: handle the Distance and Rate fields for splits by ZhenjaHorbach · Pull Request #82257 · Expensify/App

ZhenjaHorbach · 2026-02-12T13:15:47Z

Explanation of Change

Fixed Issues

$ #78891
#82122
#82120
#82119
#82116
#82134

Tests

Preconditions: User is an Expensifail account and admin have a Workspace

Open App
Create a distance expense ( manual or map)
Tap on the expense detail
Tap on the More button
Tap on the Split
Tap on any split item
Verify that the distance and rate field rows should get added to the Edit Splits screen, which can be changed as well
Try to increase or decrease amounts for splits to be more or less than the original, and try to save
Verify that the user can save these splits (Still show the warning in the split table, but allow them to save)
After creating splits, try to press on the distance or rate field on the transaction details screen
Verify that the user can edit the distance rate and distance on individual splits without opening the split table

Verify that no errors appear in the JS console

Offline tests

Preconditions: User is an Expensifail account and admin have a Workspace

Open App
Create a distance expense ( manual or map)
Tap on the expense detail
Tap on the More button
Tap on the Split
Tap on any split item
Verify that the distance and rate field rows should get added to the Edit Splits screen, which can be changed as well
Try to increase or decrease amounts for splits to be more or less than the original, and try to save
Verify that the user can save these splits (Still show the warning in the split table, but allow them to save)
After creating splits, try to press on the distance or rate field on the transaction details screen
Verify that the user can edit the distance rate and distance on individual splits without opening the split table

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Preconditions: User is an Expensifail account and admin have a Workspace

Open App
Create a distance expense ( manual or map)
Tap on the expense detail
Tap on the More button
Tap on the Split
Tap on any split item
Verify that the distance and rate field rows should get added to the Edit Splits screen, which can be changed as well
Try to increase or decrease amounts for splits to be more or less than the original, and try to save
Verify that the user can save these splits (Still show the warning in the split table, but allow them to save)
After creating splits, try to press on the distance or rate field on the transaction details screen
Verify that the user can edit the distance rate and distance on individual splits without opening the split table

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-01-13.13.21.34.mov

…pr-79099" This reverts commit e0a6b4e, reversing changes made to 9df3d2d.

codecov · 2026-02-12T13:23:11Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.43% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <ø> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.44% <ø> (+<0.01%)`	⬆️
src/hooks/useSelectedTransactionsActions.ts	`83.33% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/pages/iou/SplitExpenseCreateDateRagePage.tsx	`0.00% <ø> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`92.20% <50.00%> (-0.19%)`	⬇️
src/pages/Search/SearchPage.tsx	`23.21% <0.00%> (-0.10%)`	⬇️
.../iou/request/step/IOURequestStepDistanceManual.tsx	`0.00% <0.00%> (ø)`
... and 11 more
... and 9 files with indirect coverage changes

github-actions · 2026-02-17T20:58:09Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-02-18T09:48:02Z

@mkhutornyi @lakchote One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-02-18T09:48:08Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mitarachim · 2026-02-26T01:27:49Z

Deploy Blocker #83514 was identified to be related to this PR.

mitarachim · 2026-02-26T01:57:06Z

Deploy Blocker #83518 was identified to be related to this PR.

mitarachim · 2026-02-26T05:40:56Z

Deploy Blocker #83535 was identified to be related to this PR.

mitarachim · 2026-02-26T06:06:50Z

Deploy Blocker #83536 was identified to be related to this PR.

mitarachim · 2026-02-26T06:50:13Z

Deploy Blocker #83538 was identified to be related to this PR.

jponikarchuk · 2026-02-26T12:21:21Z

Deploy Blocker #83564 was identified to be related to this PR.

jponikarchuk · 2026-02-26T12:41:43Z

Deploy Blocker #83570 was identified to be related to this PR.

lanitochka17 · 2026-02-26T16:54:17Z

Deploy Blocker #83594 was identified to be related to this PR.

jponikarchuk · 2026-02-26T17:10:43Z

Deploy Blocker #83599 was identified to be related to this PR.

lanitochka17 · 2026-02-26T18:48:16Z

Deploy Blocker #83606 was identified to be related to this PR.

lanitochka17 · 2026-02-26T19:15:25Z

Deploy Blocker #83610 was identified to be related to this PR.

mitarachim · 2026-02-27T04:37:52Z

Deploy Blocker #83652 was identified to be related to this PR.

mitarachim · 2026-02-27T04:50:12Z

Deploy Blocker #83654 was identified to be related to this PR.

jponikarchuk · 2026-02-27T13:58:27Z

Deploy Blocker #83690 was identified to be related to this PR.

OSBotify · 2026-02-27T14:56:00Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ShridharGoel · 2026-03-20T14:31:50Z

src/libs/actions/IOU/index.ts

    const updatedReportAction = shouldBuildOptimisticModifiedExpenseReportAction
        ? buildOptimisticModifiedExpenseReportAction(transactionThreadReport, transaction, transactionChanges, isFromExpenseReport, policy, updatedTransaction, allowNegative)
        : null;
    if (!hasPendingWaypoints && !(hasModifiedDistanceRate && isFetchingWaypointsFromServer(transaction)) && updatedReportAction) {


Coming from #83500, we had to relax the condition for split transactions to allow the optimistic MODIFIED_EXPENSE to be created even when waypoints are pending.

Revert "Merge pull request Expensify#82147 from ZhenjaHorbach/revert-…

70e137d

…pr-79099" This reverts commit e0a6b4e, reversing changes made to 9df3d2d.

melvin-bot bot assigned ZhenjaHorbach Feb 12, 2026

ZhenjaHorbach changed the title ~~Revert "Merge pull request #82147 from ZhenjaHorbach/revert-pr-79099"~~ Handle the Distance and Rate fields for splits Feb 12, 2026

ZhenjaHorbach added 7 commits February 12, 2026 17:06

Fix few bugs

20a28f6

Improve logic for DistanceErrorModalDescription

ec321b5

Fix conflicts

f10958e

Update logic for distance splits

8a85235

Fix issue with selected rate after editing amount

8f14b06

Fix conflicts

490f1fd

Fix ts issues

b53d78c

lakchote mentioned this pull request Feb 17, 2026

Fix: Error message isn't displayed when create expence with 0 distance #81922

Merged

53 tasks

This comment has been minimized.

Sign in to view

Fix conflicts

c84e631

ZhenjaHorbach changed the title ~~Handle the Distance and Rate fields for splits~~ feat: handle the Distance and Rate fields for splits Feb 18, 2026

lakchote requested a review from suneox February 18, 2026 09:47

ZhenjaHorbach marked this pull request as ready for review February 18, 2026 09:47

ZhenjaHorbach requested review from a team as code owners February 18, 2026 09:47

melvin-bot bot requested review from joekaufmanexpensify, lakchote and mkhutornyi and removed request for a team February 18, 2026 09:48

melvin-bot bot requested review from a team and dukenv0307 and removed request for a team February 18, 2026 09:48

mitarachim mentioned this pull request Feb 26, 2026

[$250] Report -Unexpected error and empty preview when splitting distance expense and deleting split #83518

Closed

7 tasks

mitarachim mentioned this pull request Feb 26, 2026

[$250] Split distance - RHP header shows updated amount with old distance after changing distance #83535

Closed

7 tasks

mitarachim mentioned this pull request Feb 26, 2026

[$250] Split distance - Map is not generated after editing distance from invalid to valid waypoints #83536

Closed

7 tasks

mitarachim mentioned this pull request Feb 26, 2026

[$250] Split distance - Error when creating new split with invalid waypoints offline #83538

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 26, 2026

[$250] Distance - "Please fix the distance rate error" appears when approved split cannot be edited #83564

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 26, 2026

[$250] Distance - Split Expense shows “Amount differs from calculated distance” for long distances #83570

Closed

7 tasks

lanitochka17 mentioned this pull request Feb 26, 2026

Expense - Editing amount into negative, shows amount differs from calculated distance error #83594

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 26, 2026

[$250] Expense - Distance violation clears when split amount is edited to small value #83599

Closed

7 tasks

lanitochka17 mentioned this pull request Feb 26, 2026

[$250] Distance-Split distance shows YER currency instead INR #83606

Closed

7 tasks

lanitochka17 mentioned this pull request Feb 26, 2026

[$250] Expense - Waypoints added while splitting is not shown in distance receipt #83610

Closed

7 tasks

mitarachim mentioned this pull request Feb 27, 2026

[$250] Distance is saved with new value and old unit after changing rate with different unit #83652

Closed

7 tasks

mitarachim mentioned this pull request Feb 27, 2026

[$250] Distance - After changing unit, Distance field keeps the new value with old unit #83654

Closed

7 tasks

jponikarchuk mentioned this pull request Feb 27, 2026

[$250] Distance - Split amounts do not auto redistribute when adding distance split #83690

Closed

7 tasks

melvin-bot bot mentioned this pull request Feb 27, 2026

[Due for payment 2026-03-06] [Due for payment 2026-02-19] [Splits in NewDot] Handle the Distance and Rate fields #78891

Closed

ShridharGoel reviewed Mar 20, 2026

View reviewed changes

Conversation

ZhenjaHorbach commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

This comment has been minimized.

melvin-bot bot commented Feb 18, 2026

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

mitarachim commented Feb 26, 2026

Uh oh!

mitarachim commented Feb 26, 2026

Uh oh!

mitarachim commented Feb 26, 2026

Uh oh!

mitarachim commented Feb 26, 2026

Uh oh!

mitarachim commented Feb 26, 2026

Uh oh!

jponikarchuk commented Feb 26, 2026

Uh oh!

jponikarchuk commented Feb 26, 2026

Uh oh!

lanitochka17 commented Feb 26, 2026

Uh oh!

jponikarchuk commented Feb 26, 2026

Uh oh!

lanitochka17 commented Feb 26, 2026

Uh oh!

lanitochka17 commented Feb 26, 2026

Uh oh!

mitarachim commented Feb 27, 2026

Uh oh!

mitarachim commented Feb 27, 2026

Uh oh!

jponikarchuk commented Feb 27, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

ShridharGoel Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ZhenjaHorbach commented Feb 12, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading