[NoQA] chore: sentry labels for the Search screen by adhorodyski · Pull Request #82272 · Expensify/App

adhorodyski · 2026-02-12T15:57:40Z

Explanation of Change

This is a batch of sentryLabel properties on critical app flows, targeting the Search screen.

Fixed Issues

$ #79930
PROPOSAL:

Tests

Open EApp in a development build.
Add the below snippet into the main <style> tag inside of web/index.html to ease out debugging. It will highlight in red every item with the label.

[data-sentry-label] { 
    outline: 2px solid red !important;
}

Navigate through the Search screen and verify all key interactive elements are labeled with data-sentry-label as per the PR's diff.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

updated

Add new sentryLabel constants for search filters and bulk actions to CONST Apply sentryLabel props to relevant buttons, popups, dropdowns, menus, and checkboxes in Search and SelectionListWithSections components to improve error tracking and monitoring for search filtering interactions.

melvin-bot · 2026-02-12T15:57:49Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-02-12T16:05:15Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/AnimatedCollapsible/index.tsx	`70.96% <ø> (ø)`
...ponents/Search/FilterDropdowns/DateSelectPopup.tsx	`0.00% <ø> (ø)`
...mponents/Search/FilterDropdowns/DropdownButton.tsx	`92.59% <100.00%> (ø)`
...onents/Search/FilterDropdowns/MultiSelectPopup.tsx	`0.00% <ø> (ø)`
...nents/Search/FilterDropdowns/SingleSelectPopup.tsx	`0.00% <ø> (ø)`
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`4.08% <ø> (ø)`
...omponents/Search/SearchFilterPageFooterButtons.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchList/index.tsx	`41.66% <ø> (ø)`
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`65.58% <ø> (ø)`
... and 14 more
... and 9 files with indirect coverage changes

truph01 · 2026-02-12T16:09:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-13.at.22.43.50.mov

rlinoz · 2026-02-12T17:46:34Z

@adhorodyski lint is not happy

truph01 · 2026-02-12T18:24:05Z

@adhorodyski I noticed that there are a few places where we’re missing the sentryLabel:

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 715 in 05f81f7

<MenuItemWithTopDescription

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 731 in b790ec0

<Button

App/src/pages/Search/AdvancedSearchFilters.tsx

Line 738 in b790ec0

<FormAlertWithSubmitButton

App/src/components/SelectionListWithSections/Search/ActionCell.tsx

Line 138 in 89fd19a

<Button

App/src/components/SelectionListWithSections/Search/ActionCell.tsx

Line 158 in 89fd19a

<SettlementButton

App/src/components/SelectionListWithSections/Search/ActionCell.tsx

Line 182 in 89fd19a

<Button

App/src/components/SelectionListWithSections/Search/ExpenseReportListItemRow.tsx

Line 248 in 89fd19a

<Checkbox

App/src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx

Line 531 in 89fd19a

<AnimatedCollapsible

App/src/components/SelectionListWithSections/Search/BaseListItemHeader.tsx

Line 145 in fc97cfc

<Checkbox

App/src/components/SelectionListWithSections/SortableTableHeader.tsx

Line 74 in dc08bf9

<SortableHeaderText

trjExpensify · 2026-02-13T00:00:09Z

PR doesn’t need product input as a tooling PR. Unassigning and unsubscribing myself.

adhorodyski · 2026-02-13T11:06:21Z

Eslint is now happy happy 👌🏻

melvin-bot · 2026-02-13T11:41:00Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

truph01 · 2026-02-13T15:28:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19a76a6ab6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-13T15:56:54Z

src/components/TransactionItemRow/index.tsx

    const theme = useTheme();
    const {isLargeScreenWidth} = useResponsiveLayout();
-    const {accountID: currentUserAccountID} = useCurrentUserPersonalDetails();
+    const [reportAttributes] = useOnyx(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, {canBeMissing: true, selector: reportsSelector});


Remove per-row subscription to global report attributes

TransactionItemRow is instantiated for every result row, and this new useOnyx(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, {selector: reportsSelector}) subscription pulls the full report-attributes map into each row instance. Because columnComponent now depends on reportAttributes, any update to any report attribute can fan out into re-renders across all visible rows, which is a noticeable performance regression on large Search result sets compared with the previous context-based lookup. Please avoid N identical subscriptions here (e.g., pass the needed report name down or subscribe by reportID).

Useful? React with 👍 / 👎.

hmm looks like a blocker, though we have just addressed a lint error. Let me look into this on Monday before we proceed.

is there a better way though? I don't think so.

I mean, doesn't the report title depends on all report attributes?

I think we can skip the ESLint error in this case and revert the attempt to fix it. If that fix introduces any regression, we would need to revert the entire PR, which could lead to unnecessary back-and-forth.

agree it's safer to do so, I'll update early on Monday

truph01 · 2026-02-13T16:02:05Z

@rlinoz Please don't merge this one.

We have a potential regression need to be address here

adhorodyski · 2026-02-16T08:37:38Z

@rlinoz all ready, with a single error we're expecting.

melvin-bot · 2026-02-16T11:52:18Z

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

rlinoz · 2026-02-16T11:52:26Z

Not an emergency, see discussion #82272 (comment)

github-actions · 2026-02-16T11:52:40Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-16T11:56:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82272.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-19cf92bcd2a545d29efcbcc9e3fc8b5a3644db62-4b846a4372e51c3c06c4fd80d74212d69edf0bd2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-19cf92bcd2a545d29efcbcc9e3fc8b5a3644db62-b6556ba27a199f87590bfb25baa9d367d8a75194/index.html

Web 🕸️
https://82272.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-16T11:58:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

m-natarajan · 2026-02-16T15:41:42Z

@adhorodyski @rlinoz Can you please share the QA steps for Applause to run, I think we can't access dev

OSBotify · 2026-02-16T15:50:48Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.20-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-17T23:47:57Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-17T23:59:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

adhorodyski requested review from a team as code owners February 12, 2026 15:57

melvin-bot bot assigned adhorodyski Feb 12, 2026

melvin-bot bot requested a review from truph01 February 12, 2026 15:57

melvin-bot bot requested review from trjExpensify and removed request for a team February 12, 2026 15:57

adhorodyski mentioned this pull request Feb 12, 2026

[Due for payment 2026-03-02] [Due for payment 2026-02-27] [Due for payment 2026-02-26] [Due for payment 2026-02-20] Add sentryLabel to Pressables #79930

Closed

trjExpensify removed their request for review February 13, 2026 00:00

adhorodyski added 3 commits February 13, 2026 08:27

fix eslint for computeReportName

5719231

add more sentry labels as per the last feedback round

4d5bd7e

fix eslint error with computeReportName in AdvancedSearchFilters

19a76a6

rlinoz approved these changes Feb 13, 2026

View reviewed changes

truph01 approved these changes Feb 13, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz February 13, 2026 15:43

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

rlinoz previously approved these changes Feb 13, 2026

View reviewed changes

rlinoz changed the title ~~chore: sentry labels for the Search screen~~ [HOLD] chore: sentry labels for the Search screen Feb 13, 2026

Merge branch 'main' into feat/sentry-labels-search

2d95bd3

adhorodyski dismissed rlinoz’s stale review via 2d95bd3 February 16, 2026 07:24

adhorodyski added 2 commits February 16, 2026 09:24

Use current user details to compute report name in TransactionItemRow

6be7858

conflicts resolve cleanup

f3373d0

rlinoz approved these changes Feb 16, 2026

View reviewed changes

rlinoz merged commit 19cf92b into Expensify:main Feb 16, 2026
28 of 29 checks passed

melvin-bot bot added the Emergency label Feb 16, 2026

rlinoz removed the Emergency label Feb 16, 2026

adhorodyski deleted the feat/sentry-labels-search branch February 16, 2026 12:53

OSBotify mentioned this pull request Feb 16, 2026

Deploy Checklist: New Expensify 2026-02-16 #82567

Closed

51 tasks

mountiny changed the title ~~[HOLD] chore: sentry labels for the Search screen~~ [NoQA] chore: sentry labels for the Search screen Feb 17, 2026

adhorodyski mentioned this pull request Feb 19, 2026

[No QA] Add sentryLabel to sign-in and onboarding flows for INP tracking #82917

Merged

52 tasks

Conversation

adhorodyski commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 12, 2026

Uh oh!

codecov bot commented Feb 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

truph01 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz commented Feb 12, 2026

Uh oh!

truph01 commented Feb 12, 2026

Uh oh!

trjExpensify commented Feb 13, 2026

Uh oh!

adhorodyski commented Feb 13, 2026

Uh oh!

melvin-bot bot commented Feb 13, 2026

Uh oh!

truph01 commented Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlinoz Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

adhorodyski Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhorodyski commented Feb 16, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Feb 16, 2026

Uh oh!

rlinoz commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

m-natarajan commented Feb 16, 2026

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

OSBotify commented Feb 17, 2026

Uh oh!

OSBotify commented Feb 17, 2026

adhorodyski commented Feb 12, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited by github-actions bot

Loading

truph01 commented Feb 12, 2026 •

edited

Loading

adhorodyski Feb 13, 2026 •

edited

Loading

truph01 commented Feb 13, 2026 •

edited

Loading