[No QA] add sentryLabel constants to Workspaces by adhorodyski · Pull Request #82660 · Expensify/App

adhorodyski · 2026-02-17T14:01:57Z

Explanation of Change

This PR adds in missing sentryLabel properties under Workspaces.

Fixed Issues

$ #79930
PROPOSAL:

Tests

Open EApp in a development build.
Add the below snippet into the main <style> tag inside of web/index.html to ease out debugging. It will highlight in red every item with the label.

[data-sentry-label] { 
    outline: 2px solid red !important;
}

Navigate through the Workspaces screens and verify all key interactive elements are labeled with data-sentry-label as per the PR's diff.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-17T14:06:08Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-17T14:13:57Z

Code Review

Overall this is a clean, mechanical PR that adds sentry label constants and wires them through workspace components. A few items to address:

1. Indentation mismatch - `WorkspaceExpensifyCardListPage.tsx:151`

The sentryLabel prop on the ButtonWithDropdownMenu has 4 extra spaces of indentation compared to sibling props (success, onPress, customText, etc.). Run npx prettier --write on this file.

2. Import order - `WorkspacesListPageHeaderButton.tsx:11`

import CONST from '@src/CONST' is placed after import ROUTES from '@src/ROUTES', but alphabetically @src/CONST should come before @src/ROUTES. The linter will likely flag this.

3. Unused constants - `src/CONST/index.ts`

Several constants are defined but have no corresponding sentryLabel prop usage in this PR:

WORKFLOWS.DELAY_SUBMISSION
WORKFLOWS.PAYER
RULES.EXPENSE_REPORTS_MENU_ITEM
ACCOUNTING.CARD_SECTION_ADD_BUTTON
OVERVIEW.SHARE

Are these intentionally pre-defined for a follow-up PR, or were the corresponding component wiring missed?

codecov · 2026-02-17T14:15:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/ApprovalWorkflowSection.tsx	`0.00% <ø> (ø)`
src/components/AvatarButtonWithIcon.tsx	`100.00% <ø> (ø)`
src/components/AvatarWithImagePicker.tsx	`1.92% <ø> (ø)`
src/components/CategorySelector/index.tsx	`0.00% <ø> (ø)`
src/components/FeatureList.tsx	`0.00% <ø> (ø)`
src/pages/settings/Wallet/PaymentMethodList.tsx	`0.00% <ø> (ø)`
src/pages/workspace/WorkspaceInitialPage.tsx	`0.00% <ø> (ø)`
src/pages/workspace/WorkspaceMembersPage.tsx	`61.07% <ø> (ø)`
src/pages/workspace/WorkspaceOverviewPage.tsx	`0.00% <ø> (ø)`
... and 23 more
... and 65 files with indirect coverage changes

adhorodyski · 2026-02-17T14:15:40Z

AI please allow me to save some attention bandwidth, 3 is actually valid and slipped through after some iterations - let me clean that up. 1 and 2 are false, formatter+linter are both happy.

…pport Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adhorodyski · 2026-02-17T18:24:40Z

I will resync with main because the failing test is not related to our changes.

adhorodyski · 2026-02-17T20:47:25Z

Let me look into this fail in the morning before we merge.

adhorodyski · 2026-02-18T09:13:31Z

@truph01 back to you, all jobs are passing

joekaufmanexpensify · 2026-02-18T14:52:50Z

No product review needed

adhorodyski · 2026-02-18T15:02:34Z

Working on the conflicts now

mountiny · 2026-02-18T15:15:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

# Conflicts: # src/pages/workspace/WorkspacesListRow.tsx

truph01 · 2026-02-18T15:47:06Z

We miss a few places:

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 471 in 1bf9444

<MenuItem

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableHeaderButtons.tsx

Line 48 in 1617d72

    
           function WorkspaceCompanyCardsTableHeaderButtons({policyID, feedName, isLoading, showTableControls, CardFeedIcon}: WorkspaceCompanyCardsTableHeaderButtonsProps) {

App/src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

Line 51 in 1617d72

    
           function WorkspaceCompanyCardDetailsPage({route}: WorkspaceCompanyCardDetailsPageProps) {

App/src/components/FeatureList.tsx

Line 123 in 1617d72

<Button

App/src/pages/workspace/travel/GetStartedTravel.tsx

Line 32 in 1617d72

<BookTravelButton

App/src/components/CategorySelector/index.tsx

Line 52 in 1617d72

<MenuItemWithTopDescription

App/src/pages/workspace/distanceRates/UnitSelector/index.tsx

Line 48 in 1617d72

<MenuItemWithTopDescription

App/src/pages/workspace/rules/MerchantRulesSection.tsx

Line 136 in db106b2

<MenuItemWithTopDescription

App/src/pages/workspace/rules/MerchantRulesSection.tsx

Line 151 in 1617d72

<MenuItem

App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx

Line 370 in 1617d72

<MenuItemWithTopDescription

App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx

Line 385 in 1617d72

<FormAlertWithSubmitButton

App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx

Line 403 in 1617d72

<Button

App/src/components/ApprovalWorkflowSection.tsx

Line 78 in db106b2

<MenuItem

App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx

Line 410 in 1617d72

<Button

App/src/components/ApprovalWorkflowSection.tsx

Line 99 in db106b2

<MenuItem

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx

Line 172 in b2711f9

<FormAlertWithSubmitButton

App/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Line 152 in b2711f9

<MenuItemWithTopDescription

App/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Line 178 in b2711f9

<MenuItemWithTopDescription

Addresses reviewer feedback to add sentryLabel props to 18 additional locations across workspace pages, including company card details, merchant rules, approval workflows, and shared components. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

OSBotify · 2026-02-18T17:38:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-18T18:29:05Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-18T18:32:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82660.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8f68fe1-a53e5e7-fd5ad908fd3afa9023fdd959e261483bd1d8279e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8f68fe1-a53e5e7-4960437479a7c00292230144e4a02a2b2bcc51aa/index.html

Web 🕸️
https://82660.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-18T22:21:46Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.22-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:22:36Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	cancelled 🔪
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-19T17:36:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀

platform	result
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Add sentryLabel constants and tracking to /workspace

a1db020

melvin-bot bot assigned adhorodyski Feb 17, 2026

adhorodyski marked this pull request as ready for review February 17, 2026 14:05

adhorodyski requested review from a team as code owners February 17, 2026 14:05

melvin-bot bot requested review from a team, joekaufmanexpensify and truph01 and removed request for a team February 17, 2026 14:06

melvin-bot bot requested review from heyjennahay and removed request for a team February 17, 2026 14:06

adhorodyski added 2 commits February 17, 2026 15:06

fix prettier

3ea367a

satisfy linter

5a375ef

adhorodyski changed the title ~~[No QA] add sentryLabel constants and tracking to /workspace~~ [No QA] add sentryLabel constants to Workspaces Feb 17, 2026

Use unused sentryLabel constants and remove ones without component su…

fba63ed

…pport Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge branch 'Expensify:main' into sentry-labels-workspaces

ca6c3be

rlinoz previously approved these changes Feb 17, 2026

View reviewed changes

adhorodyski changed the title ~~[No QA] add sentryLabel constants to Workspaces~~ HOLD [No QA] add sentryLabel constants to Workspaces Feb 17, 2026

adhorodyski changed the title ~~HOLD [No QA] add sentryLabel constants to Workspaces~~ [No QA] add sentryLabel constants to Workspaces Feb 18, 2026

Expensify deleted a comment from truph01 Feb 18, 2026

Merge remote-tracking branch 'exfy/main' into sentry-labels-workspaces

1ea6e67

# Conflicts: # src/pages/workspace/WorkspacesListRow.tsx

adhorodyski dismissed rlinoz’s stale review via 1ea6e67 February 18, 2026 15:46

adhorodyski and others added 2 commits February 18, 2026 17:40

truph01 approved these changes Feb 18, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz February 18, 2026 17:00

rlinoz approved these changes Feb 18, 2026

View reviewed changes

rlinoz merged commit 8f68fe1 into Expensify:main Feb 18, 2026
30 checks passed

OSBotify mentioned this pull request Feb 18, 2026

Deploy Checklist: New Expensify 2026-02-18 #82863

Closed

76 tasks

adhorodyski mentioned this pull request Feb 19, 2026

[No QA] Add sentryLabel to sign-in and onboarding flows for INP tracking #82917

Merged

52 tasks

melvin-bot bot mentioned this pull request Feb 19, 2026

[Due for payment 2026-03-02] [Due for payment 2026-02-27] [Due for payment 2026-02-26] [Due for payment 2026-02-20] Add sentryLabel to Pressables #79930

Closed

Conversation

adhorodyski commented Feb 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Code Review

1. Indentation mismatch - WorkspaceExpensifyCardListPage.tsx:151

2. Import order - WorkspacesListPageHeaderButton.tsx:11

3. Unused constants - src/CONST/index.ts

Uh oh!

codecov bot commented Feb 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adhorodyski commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhorodyski commented Feb 17, 2026

Uh oh!

adhorodyski commented Feb 17, 2026

Uh oh!

adhorodyski commented Feb 18, 2026

Uh oh!

joekaufmanexpensify commented Feb 18, 2026

Uh oh!

adhorodyski commented Feb 18, 2026

Uh oh!

mountiny commented Feb 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 18, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

OSBotify commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

1. Indentation mismatch - `WorkspaceExpensifyCardListPage.tsx:151`

2. Import order - `WorkspacesListPageHeaderButton.tsx:11`

3. Unused constants - `src/CONST/index.ts`

codecov bot commented Feb 17, 2026 •

edited by github-actions bot

Loading

adhorodyski commented Feb 17, 2026 •

edited

Loading

truph01 commented Feb 18, 2026 •

edited

Loading