Add `Assign new cards` option for direct card feeds by fedirjh · Pull Request #84313 · Expensify/App

fedirjh · 2026-03-05T19:26:51Z

Explanation of Change

Direct card feeds cache their accountList at initial connection. When banks issue new cards, they don't appear in NewDot's assignment UI. This PR adds an "Assign new cards" menu item in the feed settings page (only for direct feeds) that triggers the existing OAuth/Plaid reconnection flow to refresh the card list.

Changes:

Add "Assign new cards" MenuItem in WorkspaceCompanyCardsSettingsPage, conditionally rendered for direct feeds only
Create a dedicated RefreshCardFeedConnectionPage route and component that reuses BankConnection/PlaidConnectionStep
Add isRefreshFlow prop to BankConnection so it always opens bank auth and dismisses the modal after re-auth (instead of proceeding to assign card steps)
Add route infrastructure: SCREENS, ROUTES, navigation types, linking config, modal stack navigator

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/594594
$ #79383
PROPOSAL:

Tests

Navigate to a workspace with a direct (OAuth) card feed
Go to Settings for that feed
Verify "Assign new cards" menu item appears with Sync icon and description "Get the latest cards to assign from your bank"
Tap "Assign new cards" → verify bank auth opens
Complete re-auth → verify modal dismisses
Navigate to a workspace with a commercial card feed → Settings → verify "Assign new cards" does NOT appear

Verify that no errors appear in the JS console

Offline tests

Go offline
Navigate to feed settings → tap "Assign new cards"
Verify the offline blocking view is shown
Go back online → verify the flow resumes

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Navigate to a workspace with a direct card feed → Settings
Verify "Assign new cards" appears only for direct feeds (OAuth/Plaid)
Tap "Assign new cards" and complete re-auth
Verify modal dismisses after re-auth
Verify no errors in JS console

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

CleanShot.2026-03-05.at.21.24.01.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Direct card feeds cache their accountList at initial connection, so newly issued cards don't appear in the assignment UI. This adds a menu item in the feed settings page (only for direct/OAuth/Plaid feeds) that triggers the existing bank reconnection flow to refresh the card list.

Create a dedicated RefreshCardFeedConnectionPage that reuses BankConnection/PlaidConnectionStep with an isRefreshFlow prop. When isRefreshFlow is true, BankConnection always opens the bank auth and dismisses the modal after re-auth instead of proceeding to the assign card flow.

melvin-bot · 2026-03-05T19:26:57Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Enhance user experience by adding success messages for refreshed bank connections in both English and Spanish translations. Update the RefreshCardFeedConnectionPage and related components to handle the new success state, ensuring proper navigation and user feedback upon successful re-authentication.

…on component Update the BankConnection component to ensure proper navigation when a feed connection is broken. The logic for handling broken connections has been streamlined to avoid redundancy, improving code clarity and maintainability. Additionally, adjust header titles to reflect the correct context based on the refresh connection flow.

fedirjh · 2026-03-05T20:34:37Z

@MelvinBot Please generateTranslations for this PR.

MelvinBot · 2026-03-05T20:40:00Z

All translations for this PR are already present in both en.ts and es.ts. Here's a summary:

Key	English	Spanish
`assignNewCards`	Assign new cards	Asignar nuevas tarjetas
`assignNewCardsDescription`	Get the latest cards to assign from your bank	Obtén las últimas tarjetas de tu banco para asignar
`refreshConnectionSuccess`	Connection refreshed	Conexión actualizada
`refreshConnectionSuccessDescription`	Your bank connection has been re-authenticated successfully. You can now assign new cards.	La conexión con tu banco ha sido reautenticada exitosamente. Ahora puedes asignar nuevas tarjetas.

The Spanish translations look accurate. No missing translations were found — all translate() calls in the changed files reference keys that exist in both language files.

codecov · 2026-03-05T20:48:20Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ROUTES.ts	`15.83% <100.00%> (+0.07%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/pages/workspace/withPolicy.tsx	`100.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.30% <0.00%> (-0.01%)`	⬇️
...ace/companyCards/RefreshCardFeedConnectionPage.tsx	`87.50% <87.50%> (ø)`
.../BankConnection/openBankConnection/index.native.ts	`0.00% <0.00%> (ø)`
...kspace/companyCards/addNew/PlaidConnectionStep.tsx	`0.00% <0.00%> (ø)`
...s/workspace/companyCards/addNew/AddNewCardPage.tsx	`0.00% <0.00%> (ø)`
...companyCards/WorkspaceCompanyCardsSettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 4 more
... and 19 files with indirect coverage changes

…anguages

… assignment menu

Introduce a new test file for the RefreshCardFeedConnection component, implementing various test cases to ensure correct rendering and functionality based on different connection steps. The tests cover loading states, bank connection rendering, and plaid connection handling, enhancing overall test coverage and reliability.

fedirjh · 2026-03-05T23:29:23Z

@carlosmiceli Could you please trigger the translation script for this PR: #84313 (comment)

fedirjh · 2026-03-05T23:42:13Z

@MelvinBot Review this PR

MelvinBot · 2026-03-05T23:51:11Z

Code Review — PR #84313

Overall the PR is well-structured and follows established patterns (mirrors BrokenCardFeedConnectionPage). Navigation infrastructure, translations, and tests are solid. I found one logic concern and one minor inconsistency worth discussing.

1. Split `isFeedConnectionBroken` check in BankConnection (both platforms)

In both BankConnection/index.tsx and BankConnection/index.native.tsx, the original single if (isFeedConnectionBroken) block was split into two separate blocks with the refresh flow check inserted between them:

// NEW CODE (both files):
if (isFeedConnectionBroken) {
    updateBrokenConnection();
}
if (isRefreshConnectionFlow && onRefreshComplete) {
    onRefreshComplete();
    return;
}
if (isFeedConnectionBroken) {
    Navigation.goBack(...); // or Navigation.closeRHPFlow() on web
    return;
}

The concern: When isFeedConnectionBroken === true AND isRefreshConnectionFlow === true, updateBrokenConnection() fires, then onRefreshComplete() is called and returns early. The user sees "Connection refreshed successfully" even though isFeedConnectionBroken was true in that render cycle (the Onyx update from updateBrokenConnection hasn't propagated yet).

This might be intentional — the user just re-authenticated, so treating it as a success makes sense. But the original code treated broken connections as an atomic bail-out. If this is intentional, consider restructuring for clarity:

if (isRefreshConnectionFlow && onRefreshComplete) {
    if (isFeedConnectionBroken) {
        updateBrokenConnection();
    }
    onRefreshComplete();
    return;
}
if (isFeedConnectionBroken) {
    updateBrokenConnection();
    Navigation.goBack(...);
    return;
}

This makes the intent explicit rather than relying on fall-through between two identical condition checks.

2. Missing header title update in native BankConnection

BankConnection/index.tsx (web) updates the header title for the refresh flow:

const headerTitleAddCards = !backTo
    ? translate(isRefreshConnectionFlow ? 'workspace.moreFeatures.companyCards.assignNewCards' : 'workspace.companyCards.addCards')
    : undefined;

But BankConnection/index.native.tsx still has the original:

const headerTitleAddCards = !backTo ? translate('workspace.companyCards.addCards') : undefined;

Since the native BankConnection renders its own header (not wrapped by RefreshCardFeedConnectionPage's header in the BANK_CONNECTION case), this means native users would see "Add cards" instead of "Assign new cards" during the refresh flow.

Everything else looks good

Navigation infrastructure (ROUTES, SCREENS, types, linkingConfig, ModalStackNavigators, withPolicy) — all correct and consistent. The new screen correctly omits the legacy backTo param.
RefreshCardFeedConnectionPage — properly follows the BrokenCardFeedConnectionPage pattern. Cleanup effect, HOC usage, and step-based rendering are all correct.
Plaid flow — PlaidConnectionStep transitions to BankConnection via Onyx step change, so it doesn't need onRefreshComplete directly. This is correct.
openBankConnectionFlow — mirrors the existing pattern in WorkspaceCompanyCardsTableHeaderButtons. isDirectFeed, getPlaidInstitutionId, getPlaidCountry, and Navigation.setNavigationActionToMicrotaskQueue are all used correctly.
Translations — all 9 language files updated with appropriate translations.
Tests — comprehensive test coverage for step rendering, success view, and cleanup.
isPlaid/url refactoring in index.tsx — semantically equivalent to the original, cleaner structure.

Updated the logic for handling broken feed connections in the BankConnection component. The update ensures that the `updateBrokenConnection` function is called appropriately during both the assign card flow and the refresh connection flow, improving the reliability of the connection handling. Additionally, modified the header title logic to reflect the current flow more accurately.

melvin-bot · 2026-03-06T00:03:07Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1329a71f3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/pages/workspace/companyCards/BankConnection/index.tsx

fedirjh · 2026-03-12T14:41:20Z

@joekaufmanexpensify @carlosmiceli I have updated the logic in 3cf060b . This will enforce refreshing the feed regardless of the auth expiration time.

carlosmiceli · 2026-03-12T14:44:24Z

@joekaufmanexpensify @carlosmiceli I have updated the logic in 3cf060b . This will enforce refreshing the feed regardless of the auth expiration time.

Great! That's actually a much better solution, I agree, consistent behavior. Thanks Fedi!

joekaufmanexpensify · 2026-03-12T21:31:11Z

@joekaufmanexpensify @carlosmiceli I have updated the logic in 3cf060b . This will enforce refreshing the feed regardless of the auth expiration time.

Nice! Just to make sure I am following, that means:

If your auth hasn't expired, tapping the button will try to get new cards.
if it has expired, you'll be prompted to auth, after which we will also try to get new cards.

Is that right @fedirjh ?

fedirjh · 2026-03-12T21:44:31Z

If your auth hasn't expired, tapping the button will try to get new cards.

@joekaufmanexpensify No. You'll be prompted to auth as well, after which we will also try to get new cards.

joekaufmanexpensify · 2026-03-13T12:35:43Z

@fedirjh I see. Is that because once we've pulled the list, auth is required to get a new list from the bank, even if the token hasn't expired for assigning cards we already have?

carlosmiceli · 2026-03-13T22:18:26Z

@joekaufmanexpensify I think the UX that Fedi implemented is correct: just because you're authenticated, we can't fetch any new cards after the authentication flow is complete. If you're authenticated from minute 0 to 15, if there would be a new card to assign in the feed from minute 5, we can't see it. Each fetch needs the authentication to happen again.

@fedirjh wanna ask Melvin to fix tests and/or merge main?

joekaufmanexpensify

Sounds good, change is fine from my perspective then 👍

github-actions · 2026-03-17T18:37:21Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T18:45:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84313.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-926a075-da2c958-7d7090c1895899b695622f0db921a6b89697c504/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-926a075-da2c958-765ddd9b4770d84050ec15b59ee9ff4d1cd11af2/index.html

Web 🕸️
https://84313.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:29:18Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:05:19Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-03-18T16:27:13Z

Deploy Blocker #85676 was identified to be related to this PR.

lanitochka17 · 2026-03-18T18:42:41Z

Deploy Blocker ##85693 was identified to be related to this PR.

This reverts commit 926a075, reversing changes made to 5814d5b.

carlosmiceli · 2026-03-19T13:59:49Z

@fedirjh we had to revert this PR because it caused some blockers that couldn't be quickly fixed. Mainly, we should reimplement this feature but include:

Coverage for the issues found while testing here: Fix : Assign new cards - Assign new cards tab with infinite spinner #85717
Since we are reverting, we should also request account validation per @joekaufmanexpensify's instructions here.

OSBotify · 2026-03-19T20:24:09Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

fedirjh added 2 commits March 5, 2026 17:18

melvin-bot bot assigned fedirjh Mar 5, 2026

fedirjh added 3 commits March 5, 2026 21:16

Merge branch 'main' into sync-card-feed-on-demand

f4d3bca

fedirjh added 4 commits March 5, 2026 21:51

Add new card assignment and connection refresh messages in multiple l…

1a07661

…anguages

Refactor PlaidConnectionStep component for improved readability

8dd5494

Update WorkspaceCompanyCardsSettingsPage to include Sync icon in card…

30fbb7a

… assignment menu

fedirjh requested a review from carlosmiceli March 5, 2026 23:29

Merge branch 'Expensify:main' into sync-card-feed-on-demand

72012ac

fedirjh requested a review from a team March 6, 2026 00:02

fedirjh marked this pull request as ready for review March 6, 2026 00:02

fedirjh requested review from a team as code owners March 6, 2026 00:02

melvin-bot bot requested review from heyjennahay and hungvu193 and removed request for a team March 6, 2026 00:03

melvin-bot bot removed the request for review from a team March 6, 2026 00:03

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/pages/workspace/companyCards/BankConnection/index.tsx Outdated Show resolved Hide resolved

Merge branch 'Expensify:main' into sync-card-feed-on-demand

0336129

joekaufmanexpensify approved these changes Mar 16, 2026

View reviewed changes

carlosmiceli approved these changes Mar 17, 2026

View reviewed changes

carlosmiceli merged commit 926a075 into Expensify:main Mar 17, 2026
33 checks passed

fedirjh deleted the sync-card-feed-on-demand branch March 17, 2026 18:29

This was referenced Mar 17, 2026

Investigate workflow job failing on main: chooseDeployActions #85580

Closed

Investigate workflow job failing on main: build (Debug, true) #85581

Closed

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

jponikarchuk mentioned this pull request Mar 18, 2026

Company cards - Error shows up after clicking Assign new cards #85676

Open

7 tasks

lanitochka17 mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Assign new cards - Assign new cards tab with infinite spinner isn't close #85693

Open

7 tasks

carlosmiceli added a commit that referenced this pull request Mar 19, 2026

Revert "Merge pull request #84313 from fedirjh/sync-card-feed-on-demand"

c6ac318

This reverts commit 926a075, reversing changes made to 5814d5b.

carlosmiceli mentioned this pull request Mar 19, 2026

Revert "Add Assign new cards option for direct card feeds" #85809

Closed

52 tasks

carlosmiceli added a commit that referenced this pull request Mar 19, 2026

Revert "Merge pull request #84313 from fedirjh/sync-card-feed-on-demand"

7bf1e2c

This reverts commit 926a075, reversing changes made to 5814d5b.

carlosmiceli mentioned this pull request Mar 19, 2026

[CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" #85807

Merged

chatgpt-codex-connector bot mentioned this pull request Mar 19, 2026

🍒 Cherry pick PR #85807 to staging 🍒 #85812

Merged

51 tasks

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] Company Cards not showing up on Workspace #79383

Open

Conversation

fedirjh commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

fedirjh commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Uh oh!

codecov bot commented Mar 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fedirjh commented Mar 5, 2026

Uh oh!

fedirjh commented Mar 5, 2026

Uh oh!

MelvinBot commented Mar 5, 2026

Code Review — PR #84313

1. Split isFeedConnectionBroken check in BankConnection (both platforms)

2. Missing header title update in native BankConnection

Everything else looks good

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fedirjh commented Mar 12, 2026

Uh oh!

carlosmiceli commented Mar 12, 2026

Uh oh!

joekaufmanexpensify commented Mar 12, 2026

Uh oh!

fedirjh commented Mar 12, 2026

Uh oh!

joekaufmanexpensify commented Mar 13, 2026

Uh oh!

carlosmiceli commented Mar 13, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

jponikarchuk commented Mar 18, 2026

Uh oh!

lanitochka17 commented Mar 18, 2026

Uh oh!

carlosmiceli commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fedirjh commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited by github-actions bot

Loading

1. Split `isFeedConnectionBroken` check in BankConnection (both platforms)