[CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" by carlosmiceli · Pull Request #85807 · Expensify/App

carlosmiceli · 2026-03-19T13:36:54Z

…pinner"

melvin-bot · 2026-03-19T13:47:20Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

This reverts commit 926a075, reversing changes made to 5814d5b.

cristipaval · 2026-03-19T13:56:09Z

straight revert

melvin-bot · 2026-03-19T13:56:21Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35b09975d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T13:58:00Z

src/pages/workspace/companyCards/BankConnection/useBankConnection.ts

        }
-        return !isFeedExpired && !isFeedConnectionBroken && (!!prevIsFeedExpired || refreshSuccessHandled);
-    }, [isRefreshConnectionFlow, feed, hasConnectionSource, shouldWaitForData, prevIsFeedExpired, isFeedExpired, isFeedConnectionBroken, refreshSuccessHandled]);
+        return !!prevIsFeedExpired && !isFeedExpired && !isFeedConnectionBroken;


Preserve completion for already-unexpired refresh feeds

This change makes isRefreshComplete depend entirely on prevIsFeedExpired, so refresh flows that render with an already-unexpired feed never reach completion. In the assign-new-cards refresh path (RefreshCardFeedConnectionPage), that means isRefreshComplete can remain false indefinitely and the native BankConnection screen keeps showing the loading indicator after connection completion instead of the success state. Please keep a completion path for the already-unexpired case rather than requiring an expired→unexpired transition.

Useful? React with 👍 / 👎.

codecov · 2026-03-19T14:02:32Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ROUTES.ts	`15.93% <ø> (-0.08%)`	⬇️
src/SCREENS.ts	`100.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.31% <ø> (+<0.01%)`	⬆️
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
...pace/companyCards/BrokenCardFeedConnectionPage.tsx	`0.00% <ø> (ø)`
src/pages/workspace/withPolicy.tsx	`100.00% <ø> (ø)`
...companyCards/WorkspaceCompanyCardsSettingsPage.tsx	`0.00% <0.00%> (ø)`
...s/workspace/companyCards/addNew/AddNewCardPage.tsx	`0.00% <0.00%> (ø)`
...kspace/companyCards/addNew/PlaidConnectionStep.tsx	`0.00% <0.00%> (ø)`
...space/companyCards/BankConnection/index.native.tsx	`0.00% <0.00%> (ø)`
... and 1 more
... and 20 files with indirect coverage changes

OSBotify · 2026-03-19T14:05:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ign-card [CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" (cherry picked from commit beb1f88) (cherry-picked to staging by cristipaval) Made-with: Cursor

github-actions · 2026-03-19T14:41:12Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T14:46:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85807.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-beb1f88-d3345e3-6d74a85387ab550dc3a2f4d86c2010cd50190795/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://85807.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…299211354-1 🍒 Cherry pick PR #85807 to staging 🍒

OSBotify · 2026-03-19T18:36:46Z

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.40-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-19T20:28:00Z

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:31:33Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "Fix : Assign new cards - Assign new cards tab with infinite s…

35b0997

…pinner"

carlosmiceli self-assigned this Mar 19, 2026

carlosmiceli marked this pull request as ready for review March 19, 2026 13:46

carlosmiceli requested review from a team as code owners March 19, 2026 13:46

melvin-bot bot requested review from joekaufmanexpensify and puneetlath and removed request for a team March 19, 2026 13:46

cristipaval previously approved these changes Mar 19, 2026

View reviewed changes

carlosmiceli mentioned this pull request Mar 19, 2026

Revert "Add Assign new cards option for direct card feeds" #85809

Closed

52 tasks

Revert "Merge pull request #84313 from fedirjh/sync-card-feed-on-demand"

7bf1e2c

This reverts commit 926a075, reversing changes made to 5814d5b.

carlosmiceli dismissed cristipaval’s stale review via 7bf1e2c March 19, 2026 13:52

carlosmiceli requested review from cristipaval and removed request for joekaufmanexpensify and puneetlath March 19, 2026 13:52

cristipaval changed the title ~~Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner"~~ [CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" Mar 19, 2026

cristipaval added the CP Staging marks PRs that have been CP'd to staging label Mar 19, 2026

cristipaval approved these changes Mar 19, 2026

View reviewed changes

cristipaval merged commit beb1f88 into main Mar 19, 2026
33 of 41 checks passed

cristipaval deleted the revert-85717-fix-spinner-assign-card branch March 19, 2026 13:56

melvin-bot bot added the Emergency label Mar 19, 2026

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

carlosmiceli mentioned this pull request Mar 19, 2026

Add Assign new cards option for direct card feeds #84313

Merged

52 tasks

os-botify bot mentioned this pull request Mar 19, 2026

🍒 Cherry pick PR #85807 to staging 🍒 #85812

Merged

51 tasks

cristipaval removed the Emergency label Mar 19, 2026

carlosmiceli added a commit that referenced this pull request Mar 19, 2026

Merge pull request #85812 from Expensify/cherry-pick-staging-85807-23…

fd8c630

…299211354-1 🍒 Cherry pick PR #85807 to staging 🍒

cristipaval added a commit that referenced this pull request Mar 19, 2026

Revert "🍒 Cherry pick PR #85807 to staging 🍒"

a988dc4

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

hoangzinh mentioned this pull request Mar 20, 2026

Fix : Assign new cards - Assign new cards tab with infinite spinner #85717

Merged

52 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner"#85807

[CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner"#85807
cristipaval merged 2 commits intomainfrom
revert-85717-fix-spinner-assign-card

carlosmiceli commented Mar 19, 2026 •

edited by cristipaval

Loading

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

cristipaval commented Mar 19, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Uh oh!

codecov bot commented Mar 19, 2026 •

edited by github-actions bot

Loading

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

carlosmiceli commented Mar 19, 2026 • edited by cristipaval Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

cristipaval commented Mar 19, 2026

Uh oh!

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carlosmiceli commented Mar 19, 2026 •

edited by cristipaval

Loading

codecov bot commented Mar 19, 2026 •

edited by github-actions bot

Loading