🍒 Cherry pick PR #85807 to staging 🍒 by os-botify[bot] · Pull Request #85812 · Expensify/App

os-botify · 2026-03-19T14:16:54Z

🍒 Cherry pick #85807 to staging 🍒

This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:

git fetch
git checkout cherry-pick-staging-85807-23299211354-1
git cherry-pick -S -x --mainline 1 beb1f88e311a8c473035f44f6326189488e35829

Then manually resolve conflicts, and commit the change with git cherry-pick --continue. Lastly, please run:

git commit --amend -m "$(git log -1 --pretty=%B)" -m "(cherry-picked to staging by cristipaval)"

This last part is important. It will help us keep track of who triggered this CP, and will ensure that version bumps are tracked correctly. Once all that's done, push your changes with git push origin cherry-pick-staging-85807-23299211354-1, and then open this PR for review.

Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.

Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

(cherry picked from commit e76c7b5) (cherry-picked to staging by cristipaval)

melvin-bot · 2026-03-19T14:17:42Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ign-card [CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" (cherry picked from commit beb1f88) (cherry-picked to staging by cristipaval) Made-with: Cursor

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73c622d8f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T14:26:37Z

package.json

 {
  "name": "new.expensify",
-  "version": "9.3.40-8",
+  "version": "9.3.40-9",


Cherry-pick the actual #85807 revert, not just the version bump

This diff only updates generated release metadata (package.json, Gradle/plists, and the Mobile-Expensify pointer). The PR named in the commit message, #85807, reverts the assign-new-cards spinner change in src/pages/workspace/companyCards/BankConnection/useBankConnection.ts; none of those source changes are present here. If this commit is merged to staging, 9.3.40-9 will be built without the intended revert, so the infinite-spinner regression from #85717/#84313 will still be present.

Useful? React with 👍 / 👎.

github-actions · 2026-03-19T14:30:00Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T14:34:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85812.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://85812.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hoangzinh · 2026-03-19T14:44:19Z

android/app/build.gradle

-        versionCode 1009034008
-        versionName "9.3.40-8"
+        versionCode 1009034009
+        versionName "9.3.40-9"


Can you confirm if you also want to cherry-pick those commits, @cristipaval?

yes, this is expected

hoangzinh · 2026-03-19T14:52:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-19.at.21.48.21.mov

cristipaval · 2026-03-19T14:54:44Z

src/pages/workspace/companyCards/BankConnection/useBankConnection.ts

@@ -1,209 +0,0 @@
-import {useCallback, useEffect, useMemo, useRef} from 'react';


The conflict was in this file that was added in the PR that we reverted. So it should not be any harm here

hoangzinh

LGTM

melvin-bot · 2026-03-19T14:59:00Z

🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #85820.

OSBotify · 2026-03-19T18:37:06Z

🚀 Cherry-picked to staging by https://github.com/carlosmiceli in version: 9.3.40-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify added 2 commits March 19, 2026 14:16

Update version to 9.3.40-9

7d8b82b

(cherry picked from commit e76c7b5) (cherry-picked to staging by cristipaval)

Update Mobile-Expensify submodule version to 9.3.40-9

73c622d

os-botify bot requested a review from a team as a code owner March 19, 2026 14:16

os-botify bot added Engineering Hourly KSv2 CP Staging marks PRs that have been CP'd to staging labels Mar 19, 2026

os-botify bot assigned cristipaval and carlosmiceli Mar 19, 2026

melvin-bot bot requested review from stitesExpensify and removed request for a team March 19, 2026 14:17

Merge pull request #85807 from Expensify/revert-85717-fix-spinner-ass…

970148f

…ign-card [CP Staging] Revert "Fix : Assign new cards - Assign new cards tab with infinite spinner" (cherry picked from commit beb1f88) (cherry-picked to staging by cristipaval) Made-with: Cursor

cristipaval requested a review from a team as a code owner March 19, 2026 14:24

melvin-bot bot requested review from heyjennahay and removed request for a team March 19, 2026 14:24

cristipaval requested a review from hoangzinh March 19, 2026 14:26

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

hoangzinh reviewed Mar 19, 2026

View reviewed changes

cristipaval reviewed Mar 19, 2026

View reviewed changes

hoangzinh approved these changes Mar 19, 2026

View reviewed changes

melvin-bot bot mentioned this pull request Mar 19, 2026

Payment issue for E/App PR#85812 #85820

Closed

carlosmiceli approved these changes Mar 19, 2026

View reviewed changes

carlosmiceli merged commit fd8c630 into staging Mar 19, 2026
8 of 12 checks passed

carlosmiceli deleted the cherry-pick-staging-85807-23299211354-1 branch March 19, 2026 15:04

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🍒 Cherry pick PR #85807 to staging 🍒#85812

🍒 Cherry pick PR #85807 to staging 🍒#85812
carlosmiceli merged 3 commits intostagingfrom
cherry-pick-staging-85807-23299211354-1

os-botify bot commented Mar 19, 2026 •

edited by cristipaval

Loading

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

hoangzinh Mar 19, 2026

Uh oh!

cristipaval Mar 19, 2026

Uh oh!

hoangzinh commented Mar 19, 2026

Uh oh!

cristipaval Mar 19, 2026

Uh oh!

hoangzinh left a comment

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,209 +0,0 @@
		import {useCallback, useEffect, useMemo, useRef} from 'react';

Conversation

os-botify bot commented Mar 19, 2026 • edited by cristipaval Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

hoangzinh Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

cristipaval Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Mar 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

cristipaval Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

os-botify bot commented Mar 19, 2026 •

edited by cristipaval

Loading