Skip to content

[No QA] Update Distance Expenses help doc for selfDM rate selection#87194

Closed
MelvinBot wants to merge 1 commit intomainfrom
claude-updateDistRateHelpDocs
Closed

[No QA] Update Distance Expenses help doc for selfDM rate selection#87194
MelvinBot wants to merge 1 commit intomainfrom
claude-updateDistRateHelpDocs

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md to reflect new behavior from Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM #74967
  • The "personal tracking" section previously stated custom distance rates were not possible outside a Workspace — this is no longer accurate
  • Updated the FAQ about updating distance rate/unit to reflect the new self-DM rate selection capability

Changes:

  1. "Distance expenses created for personal tracking" → "Distance expenses tracked for personal use": Now documents the three scenarios (default Workspace, multiple Workspaces, no Workspace) and the upgrade flow
  2. FAQ "Can I update the Distance expense unit or rate?": Updated to explain that tracked expenses in self-DM now support rate selection

Test plan

Reflects new behavior where tracked distance expenses in selfDM now
allow users to select workspace distance rates, upgrade to create a
workspace, or use their default workspace rates.

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
[Learn how to manage distance rates as a Workspace Admin](https://help.expensify.com/articles/new-expensify/reports-and-expenses/Managing-Distance-Rates)

### Distance expenses created for personal tracking
### Distance expenses tracked for personal use
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading level violation: Per HELP_AUTHORING_GUIDELINES.md Section 4 and the pre-publish checklist (Section 9), only ## should be used for content sections -- ### and deeper are not allowed. This should be promoted to a ## heading.

Additionally, this heading is not task-based (Section 2). It is a noun/topic-only heading, which is forbidden. All headings (except # FAQ) must start with an action verb or question word (How, What, Where, Who, Why, When).

Suggested fix:

Suggested change
### Distance expenses tracked for personal use
## How reimbursement rates work for personal distance tracking

### Distance expenses tracked for personal use

If you're creating expenses outside of a Workspace:
If you're tracking a distance expense in your self-DM (not on a Workspace):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology concern: The term "self-DM" may not match the exact UI terminology shown in the product. Per HELPSITE_NAMING_CONVENTIONS.md, articles must "use the exact text shown in the product UI" and must not "invent synonyms" or "paraphrase labels." If the UI does not literally say "self-DM," consider using the exact label or a clearer description such as "in your personal chat" or whatever the UI calls it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

HelpDot Documentation Review

Overall Assessment

This PR updates the Distance Expenses article to reflect new behavior for personal distance expense tracking, specifically around how rate selection works depending on whether a user has a default Workspace, multiple Workspaces, or no group Workspace. The changes are well-structured and improve accuracy for end users. One file is modified with focused, substantive content updates.

Scores Summary

  • Readability: 8/10 - The three-scenario bullet structure (default Workspace / multiple Workspaces / no group Workspace) is clear and scannable. The FAQ answer rewrite is concise and actionable. Minor deduction: the conditional scenarios could benefit from slightly shorter lead-in phrasing.
  • AI Readiness: 7/10 - The internalScope update is good and accurately reflects the expanded coverage. However, the changed ### heading ("Distance expenses tracked for personal use") is a noun phrase rather than a task-based heading, and ### headings are not permitted per the authoring guidelines (only # and ## are allowed). Note: the ### heading level is pre-existing and not introduced by this PR, but the heading text was changed and remains non-compliant.
  • Style Compliance: 7/10 - UI element Rate is correctly bolded. However, "self-DM" is used twice in the diff and does not appear to be standard UI terminology in the help site. The only related reference in the docs uses "SelfDM" (one word, no hyphen) described as "your personal chat with Concierge." Consider using phrasing that matches the UI or is already established across the help site, such as "your personal chat" or "outside of a Workspace." Additionally, "group Workspace" in the third bullet is not established terminology in the naming conventions -- consider just "Workspace" for consistency.

Key Findings

  • The rewrite of the personal tracking section is a clear improvement: moving from a single default-rate explanation to three distinct user scenarios (default Workspace, multiple Workspaces, no Workspace) provides much better guidance.
  • The removal of the bold Note callout that stated custom rates are impossible for personal expenses is appropriate, since the new behavior now guides users to create a Workspace with a custom rate.
  • The updated FAQ answer for "Can I update the Distance expense unit or rate?" properly reflects the new self-DM rate selection flow.
  • The cross-link to Managing Distance Rates (line 78) uses a full URL rather than a relative link. This is pre-existing and not introduced by this PR, but is worth noting for a future pass.
  • Two ### headings exist under the ## How reimbursement rates are set for Distance expenses section. Per governance, only # and ## are permitted. These are pre-existing but the text of one was changed in this PR.

Recommendations

  1. Terminology (should fix): Replace "self-DM" with established help site terminology. Consider "your personal chat" or restructure to say "outside of a Workspace" which was the phrasing used in the previous version and avoids introducing informal jargon.
  2. Terminology (should fix): Review whether "group Workspace" is the correct UI term. If the UI simply says "Workspace," use that instead.
  3. Heading level (consider for follow-up): The ### headings under the reimbursement rates section predate this PR, but since one heading's text was updated here, this would be a good opportunity to promote both to ## or restructure the section to eliminate ### usage entirely, per the authoring guidelines.
  4. Heading text (consider for follow-up): "Distance expenses tracked for personal use" is a noun phrase. Per governance, headings should be task-based. A revision such as "How rates are applied when tracking distance for personal use" would be more compliant.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md - Content updates to personal distance tracking section and related FAQ answer. Changes are substantively accurate and improve user guidance, with minor terminology and heading compliance items to address.

## Can I update the Distance expense unit or rate?

The distance unit and rate can only be updated by a Workspace Admin on the Workspace. It is not possible to adjust the distance rate or unit at the expense level.
For expenses on a Workspace, rates are managed by the Workspace Admin. For tracked distance expenses in your self-DM, you can tap the **Rate** field to select a rate from one of your Workspaces or create a new Workspace with a custom rate.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology concern: Same as above -- "self-DM" appears here as well. If this is not the exact UI label, it should be replaced with the product's actual terminology for consistency with HELPSITE_NAMING_CONVENTIONS.md ("Use the exact text shown in the product UI").

@github-actions github-actions bot changed the title Update Distance Expenses help doc for selfDM rate selection [No QA] Update Distance Expenses help doc for selfDM rate selection Apr 7, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 7, 2026

A preview of your ExpensifyHelp changes have been deployed to https://bf1af683.helpdot.pages.dev ⚡️

Updated articles:

@FitseTLT
Copy link
Copy Markdown
Contributor

FitseTLT commented Apr 7, 2026

@MelvinBot conflicts

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Closed in favor of #87278 which applies the same doc changes cleanly on top of current main (including the new odometer content). The old branch had unrelated git histories causing 100+ merge conflicts.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Resolved the conflicts by closing #87194 and creating a new draft PR with the same doc changes applied cleanly on top of current main: #87278

The old branch had unrelated git histories with main, causing 100+ file conflicts that couldn't be resolved normally. The new PR preserves the odometer content that was added to main since the original PR was created.

Please mark it as "Ready for review" when it is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants