[No QA] [Payment due @FitseTLT] [No QA] Update Distance Expenses help doc for selfDM rate selection#87278
[No QA] [Payment due @FitseTLT] [No QA] Update Distance Expenses help doc for selfDM rate selection#87278
Conversation
Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://95f1e326.helpdot.pages.dev ⚡️ Updated articles: |
| ## Can I update the Distance expense unit or rate? | ||
|
|
||
| The distance unit and rate can only be updated by a Workspace Admin on the Workspace. It is not possible to adjust the distance rate or unit at the expense level. | ||
| For expenses on a Workspace, rates are managed by the Workspace Admin. For tracked distance expenses in your self-DM, you can tap the **Rate** field to select a rate from one of your Workspaces or create a new Workspace with a custom rate. |
There was a problem hiding this comment.
Reverted this FAQ answer back to the original text in e7c0fe7.
| description: Learn how to create a Distance expense using GPS tracking, map-based routes, manual entry, or odometer readings, and how the reimbursement rate is determined in New Expensify. | ||
| keywords: [New Expensify, distance expense, mileage reimbursement, create expense, distance rate, workspace rate, map route, reimbursement rate, manual mileage, manual distance, global create, track distance, GPS, GPS tracking, start GPS, track route, track mileage, mileage tracking, calculate mileage reimbursement, mileage rate, odometer, odometer reading, odometer image, odometer mileage, odometer distance, start reading, end reading] | ||
| internalScope: Audience is all members. Covers creating Distance expenses using GPS tracking, map-based routes, manual entry, and odometer readings, plus how reimbursement rates are applied. Does not cover configuring Workspace distance rates in detail or broader report submission workflows. | ||
| internalScope: Audience is all members. Covers creating Distance expenses using GPS tracking, map-based routes, manual entry, and odometer readings, plus how reimbursement rates are applied — including selecting or creating Workspace rates for personal tracked expenses. Does not cover configuring Workspace distance rates in detail or broader report submission workflows. |
There was a problem hiding this comment.
Reverted the internalScope line back to the original text in 96af605.
Reverts the "Can I update the Distance expense unit or rate?" FAQ answer back to its original text as requested by FitseTLT. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
Reverts the internalScope frontmatter back to its original text as requested by FitseTLT. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
| [Learn how to manage distance rates as a Workspace Admin](/articles/new-expensify/reports-and-expenses/Managing-Distance-Rates) | ||
|
|
||
| ### Distance expenses created for personal tracking | ||
| ### Distance expenses tracked for personal use |
There was a problem hiding this comment.
@MelvinBot your changes here completely ignored the distance expenses linked with 1v1 DMs which is also included as expenses outside of a workspace
There was a problem hiding this comment.
Good catch — updated in 113c54e. The section now covers both scenarios:
- 1v1 DMs: default P2P rate based on currency, no rate picker
- Self-DM: Workspace rate selection (default Workspace, multiple Workspaces, or no Workspace)
Expands the "Distance expenses outside of a Workspace" section to document both 1v1 DM behavior (default P2P rates, no rate picker) and self-DM behavior (Workspace rate selection) as requested by reviewer. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
|
@MelvinBot make it ready for review |
melvin-bot
bot
changed the title
|
🎯 @FitseTLT, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
Marked this PR as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
bot
requested review from
Kel-Expensify
and removed request for
a team
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| [Learn how to manage distance rates as a Workspace Admin](/articles/new-expensify/reports-and-expenses/Managing-Distance-Rates) | ||
|
|
||
| ### Distance expenses created for personal tracking | ||
| ### Distance expenses created outside of a Workspace |
There was a problem hiding this comment.
Heading level violation: Governance rules require only # and ## headings — ### is not allowed (see HELP_AUTHORING_GUIDELINES.md Section 4 and TEMPLATE.md). This should be changed to a ## heading.
Additionally, this heading is not task-based. All ## headings must start with an action verb or question word (How, What, Where, Who, Why, When). Consider something like:
| ### Distance expenses created outside of a Workspace | |
| ## How distance rates work outside of a Workspace |
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Distance Expenses help article to describe how distance rate selection works in different contexts (1v1 DMs, self-DMs with/without a default Workspace, and users without a group Workspace). The content is informative, well-structured within its section, and addresses a real user scenario. However, there are governance violations in the changed lines that should be addressed. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed changes in the diff, not pre-existing content. |
| ### Distance expenses created outside of a Workspace | ||
|
|
||
| If you're creating expenses outside of a Workspace: | ||
| If you're creating a distance expense outside of a Workspace (e.g., in a 1v1 DM or your self-DM): |
There was a problem hiding this comment.
Style note: The terms "1v1 DM" and "self-DM" appear in this line and the bullets below. Per naming conventions, UI references should use the exact text shown in the product. If the UI labels these as "direct message" or "chat" rather than "1v1 DM" / "self-DM," consider updating to match the actual UI terminology. If these are the established product terms, disregard.
There was a problem hiding this comment.
Ok @MelvinBot change 1v1 dm to dm chat and self-dm to Your space.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 113c54e76e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## Can I update the Distance expense unit or rate? | ||
|
|
||
| The distance unit and rate can only be updated by a Workspace Admin on the Workspace. It is not possible to adjust the distance rate or unit at the expense level. | ||
| The distance unit and rate can only be updated by a Workspace Admin on the Workspace. It is not possible to adjust the distance rate or unit at the expense level. |
There was a problem hiding this comment.
This FAQ now contradicts the newly added self-DM guidance above: the section on expenses outside a Workspace says users can tap Rate and pick a different Workspace rate in self-DM, but this answer states it is not possible to adjust the rate at the expense level. In the self-DM context this will mislead users about a supported flow, so the FAQ should be narrowed (for example, to editing custom rates vs selecting existing rates) or updated to reflect the new behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
There is nothing to change regarding the new changes of behavior in the self dm rate selection because it clearly states it is not possible to update at the expense level.
Per reviewer feedback from FitseTLT. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>
|
Updated terminology in 344f1c3: "1v1 DM" → "DM chat" and "self-DM"/"Self-DM" → "Your space" throughout the doc. |
github-actions
bot
changed the title
|
@stephanieelliott, I've completed my checklist review. Is there anything else left for me to do? |
4 participants
Explanation of Change
Updates
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.mdto reflect new behavior from #74967:This replaces #87194, which had unresolvable merge conflicts due to unrelated git histories.
Fixed Issues
$
Tests
Offline tests
N/A — documentation-only change
QA Steps
// [No QA] — documentation-only change
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — documentation-only change