Skip to content

issue 1006 appium app to call FES mock#1158

Merged
tomholub merged 10 commits intomasterfrom
issue-1006-fes-mock
Dec 4, 2021
Merged

issue 1006 appium app to call FES mock#1158
tomholub merged 10 commits intomasterfrom
issue-1006-fes-mock

Conversation

@tomholub
Copy link
Collaborator

@tomholub tomholub commented Dec 3, 2021

This PR adds first tests that use FES mock to run. They still need some work, will continue with #1162

close #1006
close #1012


Tests:

  • tests extended

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Comment on lines +21 to +23
To run a particular test:
- `npm run-script test.live "user is able to view text email"`
- `npm run-script test.mock "app setup fails with bad EKM URL"`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosnovsky @fcvakintos @ivan-ushakov @Kharchevskyi @ekievsky I have updated the commands to run tests.

So instead of npm run-script only.test.filter "some test"
it now is npn run-script test.live "some test".

@tomholub tomholub changed the title issue 1006 app to call FES mock issue 1006 appium app to call FES mock Dec 4, 2021
@tomholub tomholub marked this pull request as ready for review December 4, 2021 10:19
Comment on lines +14 to +16
// todo - replace the following pause with wait for modal error
// that says "Please check if key manager url set correctly"
await browser.pause(5000);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this passes blindly without checking result, will be finished in #1162

Comment on lines +14 to +15
// todo - replace the following pause with wait for modal error
await browser.pause(5000);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too #1162

@tomholub tomholub merged commit ef81707 into master Dec 4, 2021
@tomholub tomholub deleted the issue-1006-fes-mock branch December 4, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optionally send API requests to a mock URL Create a FES mock for UI tests, make the tested app use it

1 participant