Merged
Conversation
* docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * Testing if PR will be updated on this request * Fixed folder upload * Removed incorrect file upload * Removed incorrect file upload * Node id draw and node-edge color config with sim time control (#30) --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>
* Fix crash when using no visual engine * Fix description in abstract visual engine
* document cleaned for merge * Correction in mkdocs.yml --------- Co-authored-by: bridgesign <eyeoeternity@gmail.com>
Override
Override issues because of improper rebasing
…. Graceful file closing and replay/stop file pointer reset. Added component delete & deregistration
… changes in typing for start/replay raw file pointer.
Collaborator
Author
Brian-Jiang
reviewed
Mar 2, 2025
Brian-Jiang
reviewed
Mar 2, 2025
Brian-Jiang
reviewed
Mar 2, 2025
Collaborator
|
Jai fixed some errors on dev branch, should we update the record branch again before merge? |
Brian-Jiang
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR primarily addresses #24 with recorded component support. The PR is complete with a simple unittest for testing breaking changes. More unittests are required to test all the different cases for record/replay process. To be added at a later date. A new sub-issue to address the lack of unittests will be added.
Given that there is a change in how visual development is going on the side currently, it is likely that somethings might break when running the bare bones replay with visualization.
The documentation for the recorder is not added and a separate issue will be created to address the documentation needs.