Merged
Conversation
Brian-Jiang
reviewed
Jan 15, 2025
Brian-Jiang
reviewed
Jan 15, 2025
minoumao
approved these changes
Jan 15, 2025
Collaborator
minoumao
left a comment
minoumao
left a comment
There was a problem hiding this comment.
Changes work fine on my end. Nothing I can spot that needs addressing. The function names are clear and make sense.
Brian-Jiang
approved these changes
Jan 15, 2025
bridgesign
added a commit
that referenced
this pull request
Jan 23, 2025
* docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * Testing if PR will be updated on this request * Fixed folder upload * Removed incorrect file upload * Removed incorrect file upload * Node id draw and node-edge color config with sim time control (#30) --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>
bridgesign
added a commit
that referenced
this pull request
Feb 18, 2025
* docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * recorder abstraction and implementation , not in context yet * modified typing init and context abstract class for recorder * modified agent_engine and class for record object * fixes to agent_engine.py * added property decorator * added correct op code to write in agent_engine * added recording to sensor_engine * added data as method * spacing * replay * current version for Rohan * noop addded to agent_engine.py * Modified recording for buffered io * Add ctx reference to switch * replay edited along with switch case * some fixes in code * changed op to OpCodes * bye * Recording only current implemented opcodes. Sidestep sensor nonexistence. Add debt * Quick change to agent visual init for replay. Should have proper fix with artists * checked/fixed some errors and fixed valid step * Pickle to ubjson * Convert opcode to int * Opcode to int covert * Termination condition correction * Context recorder stopping criteria correction --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
bridgesign
added a commit
that referenced
this pull request
Mar 2, 2025
* Merge updates into main (#31) * docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * Testing if PR will be updated on this request * Fixed folder upload * Removed incorrect file upload * Removed incorrect file upload * Node id draw and node-edge color config with sim time control (#30) --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com> * Fix crash when running no visual (#32) * Fix crash when using no visual engine * Fix description in abstract visual engine * document cleaned for merge (#34) * document cleaned for merge * Correction in mkdocs.yml --------- Co-authored-by: bridgesign <eyeoeternity@gmail.com> * Override mkdocs as its behind * Update index.md Override * Create strategy.md Override issues because of improper rebasing * Gamms Game Record: Hot fix for v1 (#37) * docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * recorder abstraction and implementation , not in context yet * modified typing init and context abstract class for recorder * modified agent_engine and class for record object * fixes to agent_engine.py * added property decorator * added correct op code to write in agent_engine * added recording to sensor_engine * added data as method * spacing * replay * current version for Rohan * noop addded to agent_engine.py * Modified recording for buffered io * Add ctx reference to switch * replay edited along with switch case * some fixes in code * changed op to OpCodes * bye * Recording only current implemented opcodes. Sidestep sensor nonexistence. Add debt * Quick change to agent visual init for replay. Should have proper fix with artists * checked/fixed some errors and fixed valid step * Pickle to ubjson * Convert opcode to int * Opcode to int covert * Termination condition correction * Context recorder stopping criteria correction --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> * Remove graph file * range sensor * fix * created arc sensor and range sensor and test cases * combine map range and arc sensor into one, rewrote test cases * orientation code * updated angent sensor for fov * tests and added sensortypes * made changes as per PR review for private type and data; degree -> radians * Small changes in type access and interface details --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com> Co-authored-by: Brian <35553805+Brian-Jiang@users.noreply.github.com>
bridgesign
added a commit
that referenced
this pull request
Mar 4, 2025
* recorder abstraction and implementation , not in context yet * modified typing init and context abstract class for recorder * modified agent_engine and class for record object * fixes to agent_engine.py * added property decorator * added correct op code to write in agent_engine * added recording to sensor_engine * added data as method * spacing * replay * current version for Rohan * noop addded to agent_engine.py * Merge updates into main (#31) * docs * Copy comments from main. Remove IVis duplication * Created basic API docs * created start.md * Added getting started * rearrange start * identation and numbering * Some cleaning * link change * latlon to utm (#22) * Testing if PR will be updated on this request * Fixed folder upload * Removed incorrect file upload * Removed incorrect file upload * Node id draw and node-edge color config with sim time control (#30) --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com> * Fix crash when running no visual (#32) * Fix crash when using no visual engine * Fix description in abstract visual engine * document cleaned for merge (#34) * document cleaned for merge * Correction in mkdocs.yml --------- Co-authored-by: bridgesign <eyeoeternity@gmail.com> * Override mkdocs as its behind * Update index.md Override * Create strategy.md Override issues because of improper rebasing * Modified recording for buffered io * Add ctx reference to switch * replay edited along with switch case * some fixes in code * changed op to OpCodes * bye * Recording only current implemented opcodes. Sidestep sensor nonexistence. Add debt * Quick change to agent visual init for replay. Should have proper fix with artists * checked/fixed some errors and fixed valid step * Pickle to ubjson * Convert opcode to int * Opcode to int covert * Termination condition correction * Context recorder stopping criteria correction * Remove pickle file * Intital commit for component recording * Changed recording to handle component record n replay. Testing remaining * Correct struct serialize n deserialize * Updated create agent to exclude extra arguments in agent kwargs * Added opcodes for component delete and deregistration * Changed start/replay to handle raw file pointers. Fixed typing errors. Graceful file closing and replay/stop file pointer reset. Added component delete & deregistration * Added abstract methods for component delete & deregistration. Reflect changes in typing for start/replay raw file pointer. * Unittest for record testing added * Remove unused file for PR * Correction in instance check and deserialization * Use agent property name * Sensor type definitions --------- Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com> Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com> Co-authored-by: Brian <35553805+Brian-Jiang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use utm for osm map so that everything is in meters.
Changes in visualization to remove scaling and make scaling a function of camera size. Turned off grid-draw as it messes up.
Changed base map resolution to 10 meters in the example as 10 meter resolution is expected.
Notes: There is enough delay in drawing when using a high resolution map. @minoumao @Brian-Jiang, is it easy to add conditions to draw only things that are in the viewport? Maybe we can do a quick merge with main so that people do not face issues with latlon conversions.