Skip to content

Node id draw and node-edge color config with sim time control#30

Merged
bridgesign merged 1 commit intodevfrom
28-displaying-node-ids-for-better-usability
Jan 23, 2025
Merged

Node id draw and node-edge color config with sim time control#30
bridgesign merged 1 commit intodevfrom
28-displaying-node-ids-for-better-usability

Conversation

@bridgesign
Copy link
Copy Markdown
Collaborator

This PR extends temporarily the pygame visualization engine to:

  • Draw node ids : draw_id boolean flag in graph visual config
  • Custom node color: node_color Tuple[int, int, int] as part of graph visual config
  • Custom edge color: edge_color Tuple[int, int, int] as part of graph visual config
  • Allow kwarg passing for visualization engine while creating context. Use it to control default config like simulation speed.

@bridgesign bridgesign requested a review from minoumao January 22, 2025 19:21
Copy link
Copy Markdown
Collaborator

@minoumao minoumao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end. Nothing major I can spot on my end.

@bridgesign bridgesign merged commit ac1060d into dev Jan 23, 2025
@bridgesign bridgesign deleted the 28-displaying-node-ids-for-better-usability branch January 23, 2025 04:20
bridgesign added a commit that referenced this pull request Jan 23, 2025
* docs

* Copy comments from main. Remove IVis duplication

* Created basic API docs

* created start.md

* Added getting started

* rearrange start

* identation and numbering

* Some cleaning

* link change

* latlon to utm (#22)

* Testing if PR will be updated on this request

* Fixed folder upload

* Removed incorrect file upload

* Removed incorrect file upload

* Node id draw and node-edge color config with sim time control (#30)

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>
bridgesign added a commit that referenced this pull request Mar 2, 2025
* Merge updates into main (#31)

* docs

* Copy comments from main. Remove IVis duplication

* Created basic API docs

* created start.md

* Added getting started

* rearrange start

* identation and numbering

* Some cleaning

* link change

* latlon to utm (#22)

* Testing if PR will be updated on this request

* Fixed folder upload

* Removed incorrect file upload

* Removed incorrect file upload

* Node id draw and node-edge color config with sim time control (#30)

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>

* Fix crash when running no visual (#32)

* Fix crash when using no visual engine

* Fix description in abstract visual engine

* document cleaned for merge (#34)

* document cleaned for merge

* Correction in mkdocs.yml

---------

Co-authored-by: bridgesign <eyeoeternity@gmail.com>

* Override mkdocs as its behind

* Update index.md

Override

* Create strategy.md

Override issues because of improper rebasing

* Gamms Game Record: Hot fix for v1 (#37)

* docs

* Copy comments from main. Remove IVis duplication

* Created basic API docs

* created start.md

* Added getting started

* rearrange start

* identation and numbering

* Some cleaning

* link change

* latlon to utm (#22)

* recorder abstraction and implementation , not in context yet

* modified typing init and context abstract class for recorder

* modified agent_engine and class for record object

* fixes to agent_engine.py

* added property decorator

* added correct op code to write in agent_engine

* added recording to sensor_engine

* added data as method

* spacing

* replay

* current version for Rohan

* noop addded to agent_engine.py

* Modified recording for buffered io

* Add ctx reference to switch

* replay edited along with switch case

* some fixes in code

* changed op to OpCodes

* bye

* Recording only current implemented opcodes. Sidestep sensor nonexistence. Add debt

* Quick change to agent visual init for replay. Should have proper fix with artists

* checked/fixed some errors and fixed valid step

* Pickle to ubjson

* Convert opcode to int

* Opcode to int covert

* Termination condition correction

* Context recorder stopping criteria correction

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>

* Remove graph file

* range sensor

* fix

* created arc sensor and range sensor and test cases

* combine map range and arc sensor into one, rewrote test cases

* orientation code

* updated angent sensor for fov

* tests and added sensortypes

* made changes as per PR review for private type and data; degree -> radians

* Small changes in type access and interface details

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>
Co-authored-by: Brian <35553805+Brian-Jiang@users.noreply.github.com>
bridgesign added a commit that referenced this pull request Mar 4, 2025
* recorder abstraction and implementation , not in context yet

* modified typing init and context abstract class for recorder

* modified agent_engine and class for record object

* fixes to agent_engine.py

* added property decorator

* added correct op code to write in agent_engine

* added recording to sensor_engine

* added data as method

* spacing

* replay

* current version for Rohan

* noop addded to agent_engine.py

* Merge updates into main (#31)

* docs

* Copy comments from main. Remove IVis duplication

* Created basic API docs

* created start.md

* Added getting started

* rearrange start

* identation and numbering

* Some cleaning

* link change

* latlon to utm (#22)

* Testing if PR will be updated on this request

* Fixed folder upload

* Removed incorrect file upload

* Removed incorrect file upload

* Node id draw and node-edge color config with sim time control (#30)

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>

* Fix crash when running no visual (#32)

* Fix crash when using no visual engine

* Fix description in abstract visual engine

* document cleaned for merge (#34)

* document cleaned for merge

* Correction in mkdocs.yml

---------

Co-authored-by: bridgesign <eyeoeternity@gmail.com>

* Override mkdocs as its behind

* Update index.md

Override

* Create strategy.md

Override issues because of improper rebasing

* Modified recording for buffered io

* Add ctx reference to switch

* replay edited along with switch case

* some fixes in code

* changed op to OpCodes

* bye

* Recording only current implemented opcodes. Sidestep sensor nonexistence. Add debt

* Quick change to agent visual init for replay. Should have proper fix with artists

* checked/fixed some errors and fixed valid step

* Pickle to ubjson

* Convert opcode to int

* Opcode to int covert

* Termination condition correction

* Context recorder stopping criteria correction

* Remove pickle file

* Intital commit for component recording

* Changed recording to handle component record n replay. Testing remaining

* Correct struct serialize n deserialize

* Updated create agent to exclude extra arguments in agent kwargs

* Added opcodes for component delete and deregistration

* Changed start/replay to handle raw file pointers. Fixed typing errors. Graceful file closing and replay/stop file pointer reset. Added component delete & deregistration

* Added abstract methods for component delete & deregistration. Reflect changes in typing for start/replay raw file pointer.

* Unittest for record testing added

* Remove unused file for PR

* Correction in instance check and deserialization

* Use agent property name

* Sensor type definitions

---------

Co-authored-by: Jai Malegaonkar <jai.malegaonkar@gmail.com>
Co-authored-by: minoumao <142881432+minoumao@users.noreply.github.com>
Co-authored-by: Brian <35553805+Brian-Jiang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants