Skip to content

Conversation

@ionphractal
Copy link

This is a hotfix for #300

@appinteractive
I know this is not very elegant and I would rather prefer storing this temporarily in the store, but I wanted to get this fix out fast. We can refactor it later and/or maybe someone has good idea.

@appinteractive
Copy link
Member

This will introduce another issue, when loosing connection while sending, you would loose your content or not? Please take some time and use the store. I think we have some more days as it’s not live atm.

Copy link
Member

@appinteractive appinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a better, more sustainable solution like a store or something like that.

@ionphractal
Copy link
Author

@appinteractive No, actually it would not lead to loosing content. It is just unintuitive, which is also why I find it not elegant, but it does not empty any textbox anywhere. It just fakes that the someone put in nothing by sending the event, which is then interpreted by the mixin like there is no text in the fields.

But I'll work on it later this week.

@Lulalaby Lulalaby self-requested a review September 25, 2018 07:12
Copy link
Contributor

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appinteractive No, actually it would not lead to loosing content. It is just unintuitive, which is also why I find it not elegant, but it does not empty any textbox anywhere. It just fakes that the someone put in nothing by sending the event, which is then interpreted by the mixin like there is no text in the fields.

But I'll work on it later this week.

If it's so, you would have my ok

@appinteractive appinteractive merged commit 90e3ea5 into Human-Connection:develop Oct 9, 2018
@appinteractive
Copy link
Member

Thanks for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants