Contribution draft confirmation #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
requested review from
a user,
Lulalaby,
appinteractive and
roschaefer
and removed request for
appinteractive
Lulalaby
approved these changes
Oct 4, 2018
appinteractive
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the form elements are validated, the 'validate' is emitted to signal validation is complete and the submission process begins. I found this suitable to also set the submit flag, so I extended the function. The state is reset in case of an error along with the same animation which seems appropriate to me. This is also applied to the edit page.
@appinteractive @roschaefer @mimicc83 Please review.
fixes #300
closes #301