[WIP] Readd contribution draft confirmation #308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please do NOT use the $parent scope!!! That’s really bad practice and can lead to bad sideeffects. Use the $emit method to dispatch an event and catch it explicitly on the parent. |
appinteractive
requested changes
Oct 2, 2018
Member
appinteractive
left a comment
appinteractive
left a comment
There was a problem hiding this comment.
Please do NOT use $parent but $emit or equal to maintain component encapsulation
Author
|
Something learned again. |
Member
|
Hey why did you deleted the pr completely? |
Author
|
Well, I found it to be junk (the history is still here for reference for everyone to see) and rewrote it from scratch. And I wanted to re-use the branch for it, so had to delete it anyway as I don't like force push as long as I can avoid it. Force push would've probably messed up the history here. This is the new one I opened for this: #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a more explicit way without using the store (respectively creating a new one). The $parent object is the right scope to set value for isSubmitting which will then be used in the mixin.
Still have to test this a little but I wanted to know your thoughts on this. @roschaefer @appinteractive @mimicc83
fixes #300
closes #301